Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable janitor for scalability presubmits' project #7556

Merged
merged 1 commit into from
Apr 4, 2018
Merged

Enable janitor for scalability presubmits' project #7556

merged 1 commit into from
Apr 4, 2018

Conversation

shyamjvs
Copy link
Member

@shyamjvs shyamjvs commented Apr 4, 2018

Follows #7547

/cc @krzyzacy

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Apr 4, 2018
@krzyzacy
Copy link
Member

krzyzacy commented Apr 4, 2018

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 4, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: krzyzacy, shyamjvs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit f8af110 into kubernetes:master Apr 4, 2018
@shyamjvs shyamjvs deleted the enable-janitor-for-scale-presubmits branch April 4, 2018 22:08
@shyamjvs
Copy link
Member Author

shyamjvs commented Apr 4, 2018

Ref umbrella - #4445

@shyamjvs
Copy link
Member Author

Ref kubernetes/kubernetes#62267

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BenTheElder BenTheElder Awaiting requested review from BenTheElder

@krzyzacy krzyzacy Awaiting requested review from krzyzacy

Assignees

@krzyzacy krzyzacy

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shyamjvs @krzyzacy @k8s-ci-robot