Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make scalability presubmits non-blocking #7558

Conversation

shyamjvs
Copy link
Member

@shyamjvs shyamjvs commented Apr 4, 2018

Follows from #7547 (comment)
We'll make it blocking once we're sure that the presubmit is running smoothly.

Ref umbrella - #4445

/cc @BenTheElder

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Apr 4, 2018
Copy link
Member

@BenTheElder BenTheElder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
Thanks!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 4, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BenTheElder, shyamjvs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link
Contributor

@shyamjvs: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-test-infra-verify-config 7399f98 link /test pull-test-infra-verify-config
pull-test-infra-bazel 7399f98 link /test pull-test-infra-bazel

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@BenTheElder
Copy link
Member

ah need to update security jobs, please run hack/update-config.sh

@k8s-ci-robot k8s-ci-robot merged commit 7399f98 into kubernetes:master Apr 4, 2018
@k8s-ci-robot
Copy link
Contributor

@shyamjvs: Updated the config configmap

In response to this:

Follows from #7547 (comment)
We'll make it blocking once we're sure that the presubmit is running smoothly.

Ref umbrella - #4445

/cc @BenTheElder

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@krzyzacy
Copy link
Member

krzyzacy commented Apr 4, 2018

the configmap might be outdated since this commit is within two PRs?

@BenTheElder
Copy link
Member

hmmm are we updating the configmap for both? this seems like an interesting edge case for the configmap updater. cc @cjwagner @fejta

@cjwagner
Copy link
Member

cjwagner commented Apr 5, 2018

@krzyzacy Why would that make the configmap outdated?
Updating the configmap for both shouldn't be problematic because we use the merged file, not the file from the PR branch.

@krzyzacy
Copy link
Member

krzyzacy commented Apr 5, 2018

ah, @cjwagner you are right, we've fixed that already

@shyamjvs shyamjvs deleted the make-scalability-presubmits-nonblocking branch April 5, 2018 00:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants