Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add AWS EBS CSI driver to prow job #9872

Merged
merged 3 commits into from
Oct 23, 2018

Conversation

leakingtapan
Copy link

@leakingtapan leakingtapan commented Oct 19, 2018

@k8s-ci-robot
Copy link
Contributor

Welcome @leakingtapan! It looks like this is your first PR to kubernetes/test-infra 🎉🎉

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 19, 2018
@k8s-ci-robot k8s-ci-robot added the area/config Issues or PRs related to code in /config label Oct 19, 2018
@krzyzacy
Copy link
Member

please use podutil rather than good-old bootstrap to make new jobs :-)

ref https://github.com/kubernetes/test-infra#create-a-new-job

a good example you can copy-paste from: https://github.com/kubernetes/test-infra/blob/master/config/jobs/kubernetes-sigs/cluster-api-provider-openstack/cluster-api-provider-openstack-presubmits.yaml

@leakingtapan
Copy link
Author

/assign @krzyzacy

@leakingtapan leakingtapan force-pushed the ebs-csi branch 2 times, most recently from 1cb96f0 to c816e3b Compare October 23, 2018 20:33
@krzyzacy
Copy link
Member

job config lgtm

last comment is add a trigger entry for your repo to https://github.com/kubernetes/test-infra/blob/master/prow/plugins.yaml

@k8s-ci-robot k8s-ci-robot added the area/prow Issues or PRs related to prow label Oct 23, 2018
@leakingtapan
Copy link
Author

Added trigger entry. Let me know if this is good. Thx

Copy link
Member

@krzyzacy krzyzacy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 8ad6bfe0fcd338ebbf88bed0ebbb9ccad043c395

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 23, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: krzyzacy, leakingtapan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 23, 2018
@k8s-ci-robot k8s-ci-robot merged commit 54cc1b3 into kubernetes:master Oct 23, 2018
@k8s-ci-robot
Copy link
Contributor

@leakingtapan: Updated the following 2 configmaps:

  • job-config configmap using the following files:
    • key aws-ebs-csi-driver-presubmits.yaml using file config/jobs/kubernetes-sigs/aws-ebs-csi-driver/aws-ebs-csi-driver-presubmits.yaml
  • plugins configmap using the following files:
    • key plugins.yaml using file prow/plugins.yaml

In response to this:

Ref #9814

Ref kubernetes-sigs/aws-ebs-csi-driver#36

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/prow Issues or PRs related to prow area/testgrid cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants