-
Notifications
You must be signed in to change notification settings - Fork 14.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Temporarily remove Hugo Pipes Sass conversion #10373
Merged
k8s-ci-robot
merged 5 commits into
kubernetes:master
from
lucperkins:lperkins/node-sass-revision
Oct 1, 2018
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
5e79dd2
Add new Sass generation system
lucperkins f784bad
Remove resources folder
lucperkins 830343f
Add develop Sass command and sourcemaps
lucperkins ed68110
Add Hugo version shortcode for use in docs
lucperkins e538468
Add OWNERS file to ./sass folder
lucperkins File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -490,7 +490,7 @@ Slack channel or the | |
If you aren't ready to create a pull request but you want to see what your | ||
changes look like, you can use the `hugo` command to stage the changes locally. | ||
|
||
1. Install Hugo version `0.40.3` or later. | ||
1. Install Hugo version {{< hugoVersion >}} or later. | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Nice update! ✨ |
||
|
||
2. In a terminal, go to the root directory of your clone of the Kubernetes | ||
docs, and enter this command: | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
{{ getenv "HUGO_VERSION" }} |
1 change: 0 additions & 1 deletion
1
...ces/_gen/assets/sass/sass/case_study_styles.sass_cb957da2191fde4902dd41b139c8069d.content
This file was deleted.
Oops, something went wrong.
1 change: 0 additions & 1 deletion
1
resources/_gen/assets/sass/sass/case_study_styles.sass_cb957da2191fde4902dd41b139c8069d.json
This file was deleted.
Oops, something went wrong.
1 change: 0 additions & 1 deletion
1
resources/_gen/assets/sass/sass/styles.sass_cb957da2191fde4902dd41b139c8069d.content
This file was deleted.
Oops, something went wrong.
1 change: 0 additions & 1 deletion
1
resources/_gen/assets/sass/sass/styles.sass_cb957da2191fde4902dd41b139c8069d.json
This file was deleted.
Oops, something went wrong.
File renamed without changes.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor nit: HUGO_VERSION is set in Makefile and netlify.toml. Is there a better place to set this variable that all scripts/configuration can use?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unfortunately there really isn't a way around that AFAIK. Netlify needs to have that information in the config and the
Makefile
needs it for people to be able to easily build the Docker image. Ideally theDockerfile
could extract that information from the Netlify config but I'm not sure there's a way to do that that doesn't add a lot of complexity.