Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove reference to get-k8s-versions #10451

Conversation

emmanuelCarre
Copy link

Problem:

Since PR kubernetes/minikube#2911, get-k8s-versions option has been removed. Reference this option in documentation is not needed any more.

Proposed Solution:

Remove reference get-k8s-versions option in documentation.

Page to Update:

https://kubernetes.io/docs/setup/minikube/

Additional Information:

get-k8s-versions option has been removed into Minikube 0.29.0.

@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 1, 2018
@k8sio-netlify-preview-bot
Copy link
Collaborator

k8sio-netlify-preview-bot commented Oct 1, 2018

Deploy preview for kubernetes-io-master-staging ready!

Built with commit 2ad86ab

https://deploy-preview-10451--kubernetes-io-master-staging.netlify.com

@emmanuelCarre
Copy link
Author

I signed it

@zparnold
Copy link
Member

zparnold commented Oct 3, 2018

Hey there! @emmanuelCarre, looks like you haven't signed the CLA yet. Could I please have you do that? https://github.com/kubernetes/community/blob/master/CLA.md

@emmanuelCarre emmanuelCarre force-pushed the remove_minikube_get-k8s-versions_option branch from a6c85f4 to 9b141f1 Compare October 7, 2018 22:46
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: zacharysarah

If they are not already assigned, you can assign the PR to them by writing /assign @zacharysarah in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@emmanuelCarre emmanuelCarre force-pushed the remove_minikube_get-k8s-versions_option branch from 9b141f1 to 15de506 Compare October 7, 2018 22:56
Since PR kubernetes/minikube#2911, get-k8s-versions option has been
removed. Reference this option in documentation is not needed any more.
@emmanuelCarre emmanuelCarre force-pushed the remove_minikube_get-k8s-versions_option branch from 15de506 to 2ad86ab Compare October 7, 2018 23:02
@emmanuelCarre
Copy link
Author

I signed it

@emmanuelCarre
Copy link
Author

@zparnold, sorry for delay. Yes I did it but I think I made a mistake during process...

I already fix one issue: my commit is correctly tag as signed (verified). I added noreply email address provide by github to my GPG key.
Now I will re-read documentation about CLA. Maybe the issue is about my email address too.

@emmanuelCarre
Copy link
Author

I signed it

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Oct 7, 2018
@kubernetes-docs-i18n-bot kubernetes-docs-i18n-bot added the language/en Issues or PRs related to English language label Oct 7, 2018
@emmanuelCarre
Copy link
Author

It is fixed! I missed a step to signe CLA.

Sorry for delay and thanks to @zparnold and people who review my PR.

@emmanuelCarre
Copy link
Author

Maybe my PR is not more need since PR #10423

@stewart-yu
Copy link
Contributor

Thanks for your contribution! 👍
/close
If you think necessary, you can reopen it

@k8s-ci-robot
Copy link
Contributor

@stewart-yu: Closing this PR.

In response to this:

Thanks for your contribution! 👍
/close
If you think necessary, you can reopen it

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants