-
Notifications
You must be signed in to change notification settings - Fork 14.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove reference to get-k8s-versions #10451
Remove reference to get-k8s-versions #10451
Conversation
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Deploy preview for kubernetes-io-master-staging ready! Built with commit 2ad86ab https://deploy-preview-10451--kubernetes-io-master-staging.netlify.com |
I signed it |
Hey there! @emmanuelCarre, looks like you haven't signed the CLA yet. Could I please have you do that? https://github.com/kubernetes/community/blob/master/CLA.md |
a6c85f4
to
9b141f1
Compare
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: If they are not already assigned, you can assign the PR to them by writing The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
9b141f1
to
15de506
Compare
Since PR kubernetes/minikube#2911, get-k8s-versions option has been removed. Reference this option in documentation is not needed any more.
15de506
to
2ad86ab
Compare
I signed it |
@zparnold, sorry for delay. Yes I did it but I think I made a mistake during process... I already fix one issue: my commit is correctly tag as signed (verified). I added noreply email address provide by github to my GPG key. |
I signed it |
It is fixed! I missed a step to signe CLA. Sorry for delay and thanks to @zparnold and people who review my PR. |
Maybe my PR is not more need since PR #10423 |
Thanks for your contribution! 👍 |
@stewart-yu: Closing this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Problem:
Since PR kubernetes/minikube#2911,
get-k8s-versions
option has been removed. Reference this option in documentation is not needed any more.Proposed Solution:
Remove reference
get-k8s-versions
option in documentation.Page to Update:
https://kubernetes.io/docs/setup/minikube/
Additional Information:
get-k8s-versions
option has been removed into Minikube 0.29.0.