Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add "grpc load balancing on kubernetes without tears" blog post #10891

Merged
merged 4 commits into from
Nov 7, 2018
Merged

add "grpc load balancing on kubernetes without tears" blog post #10891

merged 4 commits into from
Nov 7, 2018

Conversation

wmorgan
Copy link
Contributor

@wmorgan wmorgan commented Nov 6, 2018

I put the images directly in the /images/blog directory which I saw some other posts doing. Can also host these externally in a pinch.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Nov 6, 2018
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Nov 6, 2018
@kbarnard10 kbarnard10 self-assigned this Nov 6, 2018
@k8sio-netlify-preview-bot
Copy link
Collaborator

Deploy preview for kubernetes-io-master-staging ready!

Built with commit 5e7fcac

https://deploy-preview-10891--kubernetes-io-master-staging.netlify.com

@k8sio-netlify-preview-bot
Copy link
Collaborator

k8sio-netlify-preview-bot commented Nov 6, 2018 •
edited
Loading

Deploy preview for kubernetes-io-master-staging ready!

Built with commit d19af3e

https://deploy-preview-10891--kubernetes-io-master-staging.netlify.com

@wmorgan
Copy link
Contributor Author

wmorgan commented Nov 6, 2018

Preview link for the blog post is https://deploy-preview-10891--kubernetes-io-master-staging.netlify.com/blog/1/01/01/grpc-load-balancing-on-kubernetes-without-tears/ because I added no date (per instructions)

@kbarnard10
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 7, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kbarnard10

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 7, 2018
@k8s-ci-robot k8s-ci-robot merged commit 08d0e1b into kubernetes:master Nov 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kbarnard10 kbarnard10 Awaiting requested review from kbarnard10

@stewart-yu stewart-yu Awaiting requested review from stewart-yu

Assignees

@kbarnard10 kbarnard10

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@wmorgan @k8sio-netlify-preview-bot @kbarnard10 @k8s-ci-robot