Create a ref doc for scheduled jobs #1123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PTAL |
This was referenced Aug 29, 2016
|
LGTM |
|
|
||
| ## Creating a Scheduled Job | ||
|
|
||
| Here is an example Scheduled Job. Every minute, it runs a simple job to compute π to 2000 places and prints it out. |
There was a problem hiding this comment.
The sample job prints date and Hello from the Kubernetes cluster not computes PI.
There was a problem hiding this comment.
Nice catch, fixed, thanks
|
Since I have a few comments, I allow myself to remove Tech Review approval label. |
|
Good eye, thanks Maciej On Tue, Aug 30, 2016 at 3:07 AM, Maciej Szulik notifications@github.com
|
|
Thanks! All comments addressed, PTAL |
|
LGTM |
16 tasks
|
Looks like we don't separate Tech LGTM and Docs LGTM anymore. So manually merging. |
mikutas
pushed a commit
to mikutas/k8s-website
that referenced
this pull request
Sep 22, 2022
Fixes linkerd/linkerd2#6237 - Since a few releases ago, `linkerd inject` will fail outright if `automountServiceAccountToken` is not `true`. Reshuffled the instructions to account for that. - Added note about adding the `config.linkerd.io/skip-outbound-ports: 8001` annotation when in ingress mode. - Removed the `spec.routes.services.namespace` field from the sample `HTTPProxy` resource, which doesn't appear in the resource API doc. - Replaced `127.0.0.1.xip.io` with `127.0.0.1.nip.io` as the former is down. Co-authored-by: cpretzer <cpretzer@users.noreply.github.com>
mikutas
pushed a commit
to mikutas/k8s-website
that referenced
this pull request
Sep 22, 2022
* update: june meetup - add video schema - add featured image Signed-off-by: Christian Mejlak <chris@mejlak.com> * Update Contour instructions (kubernetes#1123) Fixes linkerd/linkerd2#6237 - Since a few releases ago, `linkerd inject` will fail outright if `automountServiceAccountToken` is not `true`. Reshuffled the instructions to account for that. - Added note about adding the `config.linkerd.io/skip-outbound-ports: 8001` annotation when in ingress mode. - Removed the `spec.routes.services.namespace` field from the sample `HTTPProxy` resource, which doesn't appear in the resource API doc. - Replaced `127.0.0.1.xip.io` with `127.0.0.1.nip.io` as the former is down. Co-authored-by: cpretzer <cpretzer@users.noreply.github.com> * update: june meetup - add video schema - add featured image Signed-off-by: Christian Mejlak <chris@mejlak.com> Co-authored-by: Alejandro Pedraza <alejandro@buoyant.io> Co-authored-by: cpretzer <cpretzer@users.noreply.github.com>
Okabe-Junya
pushed a commit
to Okabe-Junya/website
that referenced
this pull request
Dec 4, 2023
* Localize service.md for Korean Signed-off-by: HongJu Jeong <sub06038@naver.com> Co-authored-by: Yunkon Kim <7975459+yunkon-kim@users.noreply.github.com> Co-authored-by: Seokho Son <shsongist@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supersedes #1111, since this doc needs to be merged into 1.4 branch (instead of master). All comments in #1111 are addressed.
Ref kubernetes/kubernetes#28496, kubernetes/enhancements#19
@soltysh @erictune @jaredbhatti @kubernetes/docs
This change is