-
Notifications
You must be signed in to change notification settings - Fork 14.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding user guides for federation events and namespaces #1224
Conversation
--- | ||
--- | ||
|
||
This guide explains how to use events in federation control plane to help in debugging |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing full stop at the end of the sentence.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed
This guide talks about how we can manage multiple kubernetes clusters using | ||
federation. | ||
[Federation proposal](https://github.com/kubernetes/kubernetes/blob/{{page.githubbranch}}/docs/proposals/federation.md) | ||
details the use cases why that will be useful. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
use cases motivating cluster federation. (or something like that)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed
Thanks @nikhiljindal @kelseyhightower ! LGTM barring minor comments. Feel free to apply the label once addressed to your satisfaction. |
753839f
to
27f0b6f
Compare
Thanks @quinton-hoole for the comments. Updated the doc as per comments. |
Adding LGTM as per comment from @quinton-hoole above |
LGTM from me as well. I'll merge. |
You can do that using kubectl by running: | ||
|
||
``` shell | ||
kubectl --context=federation-cluster create -f myns.yaml |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I could not find file myns.yaml in the whole project.
I tried using federation.yaml from Kelsey's page:
https://github.com/kelseyhightower/kubernetes-cluster-federation/tree/master/ns
But, after 'finalizer' was added to the coded, federation-controller-manager returns:
"[namespace_controller.go:371] Failed to ensure delete object from underlying clusters finalizer in namespace federation: failed to add finalizer orphan to namespace : Operation cannot be fulfilled on namespaces "federation": the object has been modified; please apply your changes to the latest version and try again"
As a result, even though namespace 'federation' can be added successfully, it cannot be deleted, i.e., stays in 'Terminating' forever.
Is there any other yaml config that I can try?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes myns.yaml is just an example file name. Any yaml describing a namespace is fine.
That failed to ensure finalizer error is fine as long as it eventually succeeds (federated namespace controller keeps retrying).
Namespace remains in terminating state until all resources in that namespace are deleted. Can you list all the resources in the namespace?
Please feel free to file a separate issue. kubectl delete ns
should work. Its a bug if it doesnt.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fwiw, I tried it just now and it worked fine for me.
I ran kubectl create -f myns.yaml
followed by kubectl delete ns myns
, with kubectl pointing to federation-apiserver.
myns.yaml:
apiVersion: v1
kind: Namespace
metadata:
name: "myns"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't use --context=federation-cluster
because I have my federation-apiserver and federation-controller-manager running on the OS.
Instead I use kubectl -s <federation-apiserver IP address>:<federation-apiserver port> create -f myns.yaml
Should I expect it not working b/c of that?
BTW, I filed Issue #38133
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Continuing the discussion in kubernetes/kubernetes#38133.
Ref #1215
Adding user guides for federation events and namespaces.
cc @kubernetes/sig-cluster-federation @quinton-hoole @kelseyhightower
This change is