Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #12434 - Empty continuation line warning while building docker image #12435

Merged
merged 1 commit into from
Feb 1, 2019
Merged

Conversation

daminisatya
Copy link
Contributor

@daminisatya daminisatya commented Jan 30, 2019

This is a parsing error for docker versions <= "17.09.0-ce" where it checks for both empty line and a comment line after a command.

But there is a fix for lastest docker versions - docker-archive/docker-ce@e25514e

which only checks for empty lines.

Please let me know if there is a need for this change. Thank you.

@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 30, 2019
@daminisatya daminisatya changed the title Fix ##12434 - Empty continuation line warning while building docker i… Fix #12434 - Empty continuation line warning while building docker i… Jan 30, 2019
@daminisatya
Copy link
Contributor Author

Check CLA

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Jan 30, 2019
@daminisatya daminisatya changed the title Fix #12434 - Empty continuation line warning while building docker i… Fix #12434 - Empty continuation line warning while building docker image Jan 30, 2019
@daminisatya
Copy link
Contributor Author

/assign @bradtopol
/assign @tengqm

@netlify
Copy link

netlify bot commented Jan 30, 2019

Deploy preview for kubernetes-io-master-staging ready!

Built with commit f258a62

https://deploy-preview-12435--kubernetes-io-master-staging.netlify.com

@tengqm
Copy link
Contributor

tengqm commented Jan 31, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 31, 2019
@daminisatya
Copy link
Contributor Author

/assign @cody-clark

@cody-clark
Copy link
Contributor

Thanks!

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cody-clark

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 1, 2019
@k8s-ci-robot k8s-ci-robot merged commit d3f5001 into kubernetes:master Feb 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants