Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Placeholder for Windows GMSA docs #12869

Closed
wants to merge 3 commits into from
Closed

Placeholder for Windows GMSA docs #12869

wants to merge 3 commits into from

Conversation

ddebroy
Copy link
Member

@ddebroy ddebroy commented Feb 27, 2019

Signed-off-by: Deep Debroy ddebroy@docker.com

^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Please delete this note before submitting the pull request.

For 1.14 Features: set Milestone to 1.14 and Base Branch to dev-1.14

For Chinese localization, base branch to release-1.12

For Korean Localization: set Base Branch to dev-1.13-ko.

Help editing and submitting pull requests:
https://kubernetes.io/docs/contribute/start/#improve-existing-content.

Help choosing which branch to use:
https://kubernetes.io/docs/contribute/start#choose-which-git-branch-to-use.
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

@ddebroy
Placeholder for Windows GMSA
51516cf 
Signed-off-by: Deep Debroy <ddebroy@docker.com>
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 27, 2019
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 27, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: cody-clark

If they are not already assigned, you can assign the PR to them by writing /assign @cody-clark in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ddebroy ddebroy changed the title Placeholder for Windows GMSA Placeholder for Windows GMSA docs Feb 27, 2019
@k8s-ci-robot k8s-ci-robot added the language/en Issues or PRs related to English language label Feb 27, 2019
@netlify
Copy link

netlify bot commented Feb 27, 2019 •
edited
Loading

Deploy preview for kubernetes-io-master-staging ready!

Built with commit 48730dc

https://deploy-preview-12869--kubernetes-io-master-staging.netlify.com

@ddebroy ddebroy mentioned this pull request Feb 27, 2019
Closed
sftim
sftim reviewed Feb 27, 2019
View reviewed changes
Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments that I hope are useful.

content/en/docs/getting-started-guides/windows/_index.md Outdated
@@ -350,6 +350,10 @@ Starting with kubernetes v1.11, kubelet and kube-proxy can run as Windows servic

This means that you can now register them as Windows services via `sc` command. More details about how to create Windows services with `sc` can be found [here](https://support.microsoft.com/en-us/help/251192/how-to-create-a-windows-service-by-using-sc-exe).

### GMSA support

Starting with Kubernetes v1.14, Windows container workloads can be configured with a GMSA credential spec JSON. Operators can configure a set of GMSA credential specs that can be used in Windows worker nodes across the Kubernetes cluster
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd use a feature state shortcode here.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we expand GMSA to Group Managed Service Account?

@ddebroy
Address review comments
cdd4dde 
Signed-off-by: Deep Debroy <ddebroy@docker.com>
@ddebroy
Address review comments
48730dc 
Signed-off-by: Deep Debroy <ddebroy@docker.com>
@ddebroy ddebroy closed this Mar 2, 2019
@ddebroy
Copy link
Member Author

ddebroy commented Mar 2, 2019 •
edited
Loading

Superseded by #12936 . This one was opened against Master and not the 1.14 branch for docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sftim sftim sftim left review comments

@errordeveloper errordeveloper Awaiting requested review from errordeveloper

@xiangpengzhao xiangpengzhao Awaiting requested review from xiangpengzhao

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ddebroy @k8s-ci-robot @sftim