Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarifications and fixes in GMSA doc #13226

Merged
merged 10 commits into from
Mar 18, 2019
Merged

Clarifications and fixes in GMSA doc #13226

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
7bd07e7
Clarifications and fixes in GMSA doc
ddebroy Mar 17, 2019
86fa8b2
Update configure-gmsa.md
JeremyWx Mar 17, 2019
e4c14f9
Merge pull request #5 from JeremyWx/dev-1.14
ddebroy Mar 17, 2019
7a539c7
Reformat to align headings and pre-reqs better
ddebroy Mar 18, 2019
7bb1c06
Reformat to align headings and pre-reqs better
ddebroy Mar 18, 2019
4f8d6bf
Reformat to fix bullets
ddebroy Mar 18, 2019
1a2911b
Reword application of sample gmsa
ddebroy Mar 18, 2019
8ac0598
Update configure-gmsa.md
michmike Mar 18, 2019
ebec933
Address feedback to use active voice
ddebroy Mar 18, 2019
4765032
Address feedback to use active voice
ddebroy Mar 18, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion content/en/docs/tasks/configure-pod-container/configure-gmsa.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -193,7 +193,7 @@ spec:
beta.kubernetes.io/os: windows
```

As pod specs with GMSA annotations (as described above) are applied in a cluster configured for GMSA, the following sequence of events will take place:
As pod specs with GMSA annotations (as described above) are applied in a cluster configured for GMSA, the following sequence of events take place:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit takes place

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh it is merged. don't worry about it :)


1. The mutating webhook resolves and expands all references to GMSA credential spec resources to the contents of the GMSA credential spec.

Expand Down