Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add content/es/docs/concepts/architecture/nodes.md #13881

Merged

Conversation

glo-pena
Copy link
Contributor

Spanish translation of the content/es/docs/concepts/architecture/nodes.md documentation page.

This is a long one. Make sure you get a cuppa before reviewing.

Thanks

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. language/es Issues or PRs related to Spanish language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Apr 18, 2019
@netlify
Copy link

netlify bot commented Apr 18, 2019

Deploy preview for kubernetes-io-master-staging ready!

Built with commit 33257cd

https://deploy-preview-13881--kubernetes-io-master-staging.netlify.com

@raelga raelga self-assigned this Apr 18, 2019
content/es/docs/concepts/architecture/nodes.md Outdated Show resolved Hide resolved
content/es/docs/concepts/architecture/nodes.md Outdated Show resolved Hide resolved
content/es/docs/concepts/architecture/nodes.md Outdated Show resolved Hide resolved
content/es/docs/concepts/architecture/nodes.md Outdated Show resolved Hide resolved
content/es/docs/concepts/architecture/nodes.md Outdated Show resolved Hide resolved
content/es/docs/concepts/architecture/nodes.md Outdated Show resolved Hide resolved
content/es/docs/concepts/architecture/nodes.md Outdated Show resolved Hide resolved
@glo-pena glo-pena force-pushed the feature/es_docs-concepts-arch-nodes branch from fefbb54 to 0c423b1 Compare April 19, 2019 07:35
content/es/docs/concepts/architecture/nodes.md Outdated Show resolved Hide resolved
content/es/docs/concepts/architecture/nodes.md Outdated Show resolved Hide resolved
content/es/docs/concepts/architecture/nodes.md Outdated Show resolved Hide resolved
content/es/docs/concepts/architecture/nodes.md Outdated Show resolved Hide resolved
content/es/docs/concepts/architecture/nodes.md Outdated Show resolved Hide resolved
content/es/docs/concepts/architecture/nodes.md Outdated Show resolved Hide resolved
content/es/docs/concepts/architecture/nodes.md Outdated Show resolved Hide resolved
content/es/docs/concepts/architecture/nodes.md Outdated Show resolved Hide resolved
content/es/docs/concepts/architecture/nodes.md Outdated Show resolved Hide resolved
content/es/docs/concepts/architecture/nodes.md Outdated Show resolved Hide resolved
@raelga raelga changed the title localization-es docs concepts architecture nodes Add /es/docs/concepts/architecture/nodes.md Apr 19, 2019
@raelga raelga changed the title Add /es/docs/concepts/architecture/nodes.md Add content/es/docs/concepts/architecture/nodes.md Apr 22, 2019
content/es/docs/concepts/architecture/nodes.md Outdated Show resolved Hide resolved
content/es/docs/concepts/architecture/nodes.md Outdated Show resolved Hide resolved
content/es/docs/concepts/architecture/nodes.md Outdated Show resolved Hide resolved
content/es/docs/concepts/architecture/nodes.md Outdated Show resolved Hide resolved
content/es/docs/concepts/architecture/nodes.md Outdated Show resolved Hide resolved
content/es/docs/concepts/architecture/nodes.md Outdated Show resolved Hide resolved
content/es/docs/concepts/architecture/nodes.md Outdated Show resolved Hide resolved
content/es/docs/concepts/architecture/nodes.md Outdated Show resolved Hide resolved
@raelga raelga added this to the 2019 KubeCon Barcelona milestone May 1, 2019
@glo-pena glo-pena force-pushed the feature/es_docs-concepts-arch-nodes branch from d7859ee to a8009be Compare May 3, 2019 02:10
@raelga
Copy link
Member

raelga commented May 3, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 3, 2019
@raelga
Copy link
Member

raelga commented May 3, 2019

Hello @alexbrand, can you lgtm the changes requested if they look good to you?

@alexbrand
Copy link
Contributor

Overall this LGTM. There is that small nit but I am not sure there's a good solution to it.

Happy to move forward with this PR if you both are as well @raelga @glo-pena

/lgtm

@raelga
Copy link
Member

raelga commented May 3, 2019

Tracked in #13948

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 8, 2019
@glo-pena glo-pena force-pushed the feature/es_docs-concepts-arch-nodes branch from 898276a to cd0667c Compare May 8, 2019 12:54
@glo-pena
Copy link
Contributor Author

glo-pena commented May 8, 2019

Please do check the latest update. Then I think I need to do the whole upstream rebase to squash github generated merge commits. But lets get first the content right

@raelga
Copy link
Member

raelga commented May 12, 2019

Hello @glo-pena, the content looks legit to me.

Once the merge commits are removed we can approve this PR.

Thanks!

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 12, 2019
@glo-pena glo-pena force-pushed the feature/es_docs-concepts-arch-nodes branch from cd0667c to d0ee68e Compare May 12, 2019 11:05
content/es/docs/concepts/architecture/nodes.md Outdated Show resolved Hide resolved
content/es/docs/concepts/architecture/nodes.md Outdated Show resolved Hide resolved
content/es/docs/concepts/architecture/nodes.md Outdated Show resolved Hide resolved
corrections after inital review

More fixes after review

More fixes after review

further corrections on spanish transalation

final corrections
@glo-pena glo-pena force-pushed the feature/es_docs-concepts-arch-nodes branch from d0ee68e to 33257cd Compare May 12, 2019 14:56
@raelga
Copy link
Member

raelga commented May 12, 2019

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 12, 2019
@raelga
Copy link
Member

raelga commented May 12, 2019

Muchísimas gracias @glo-pena.
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 12, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: raelga

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 12, 2019
@k8s-ci-robot k8s-ci-robot merged commit 624fd0c into kubernetes:master May 12, 2019
yoonian pushed a commit to yoonian/kubernetes-website that referenced this pull request May 28, 2019
corrections after inital review

More fixes after review

More fixes after review

further corrections on spanish transalation

final corrections
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/es Issues or PRs related to Spanish language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants