Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

setup page replaces picking the right solutions page #14427

Closed
wants to merge 14 commits into from
Closed

setup page replaces picking the right solutions page #14427

wants to merge 14 commits into from

Conversation

Rajakavitha1
Copy link
Contributor

@Rajakavitha1 Rajakavitha1 commented May 20, 2019 •
edited by zacharysarah
Loading

Fixes #9710

All the information in https://kubernetes.io/docs/setup/pick-right-solution/ is now available in https://kubernetes.io/docs/setup/.

The content in https://kubernetes.io/docs/setup/ also ensures that:
a. kubernetes is vendor neutral.
b. references to private git repos not maintained anymore are not listed
c. most recent update to picking the right solution page #14269 has been updated in https://kubernetes.io/docs/setup/
d. vendor specific support level is not listed in the table

Launch card in https://kubernetes.io/docs/home/ has been updated in the latest version of the setup page.

All references/links to Table of Solutions in Picking the right solution page has been removed.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 20, 2019
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels May 20, 2019
@Rajakavitha1
Copy link
Contributor Author

/assign @cody-clark
/assign @zacharysarah
/assign @kbhawkey

@k8s-ci-robot
Copy link
Contributor

@Rajakavitha1: GitHub didn't allow me to assign the following users: kbhawkey.

Note that only kubernetes members and repo collaborators can be assigned and that issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

/assign @cody-clark
/assign @zacharysarah
/assign @kbhawkey

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@netlify
Copy link

netlify bot commented May 20, 2019 •
edited
Loading

Deploy preview for kubernetes-io-master-staging ready!

Built with commit 5305013

https://deploy-preview-14427--kubernetes-io-master-staging.netlify.com

@Rajakavitha1
Copy link
Contributor Author

Please review the preview here:
https://deploy-preview-14427--kubernetes-io-master-staging.netlify.com/docs/home/
https://deploy-preview-14427--kubernetes-io-master-staging.netlify.com/docs/setup/

@zacharysarah
Copy link
Contributor

Tangentially:

GitHub didn't allow me to assign the following users: kbhawkey.

@kbhawkey It looks like you're not yet a member of the Kubernetes org. For someone who's closed almost 60 PRs in k/website, that feels like an oversight on our part. 😅 Would you please open a new membership request in k/org? I'm happy to sponsor you, and I bet @Rajakavitha1 would be as well.

@zacharysarah
Copy link
Contributor

@Rajakavitha1 Can you say more about the addition of the card: attribute to the front matter and what changes we should see consequently?

@kbhawkey
Copy link
Contributor

@Rajakavitha1, adjoining pages from the Setup section have links to Table of solutions. The links should be updated to the new table from the Setup page? See https://kubernetes.io/docs/setup/turnkey/aws/ as an example.

@zacharysarah
Copy link
Contributor

@Rajakavitha1 Great issue description btw! ✨

@Rajakavitha1
Copy link
Contributor Author

@Rajakavitha1, adjoining pages from the Setup section have links to Table of solutions. The links should be updated to the new table from the Setup page? See https://kubernetes.io/docs/setup/turnkey/aws/ as an example.

Thank you so much!!!! I missed it :)

@tengqm
Copy link
Contributor

tengqm commented May 21, 2019

whoops, there is a conflict!!!

@Rajakavitha1
Copy link
Contributor Author

@Rajakavitha1 Can you say more about the addition of the card: attribute to the front matter and what changes we should see consequently?

Thanks @zacharysarah !!! The card attribute changes reflect in https://deploy-preview-14427--kubernetes-io-master-staging.netlify.com/docs/home/ under "Set up a cluster" card that contained the links to headings in Picking the right solutions page.

@Rajakavitha1
Copy link
Contributor Author

@tengqm I just resolved the conflicts :)

@zacharysarah
Copy link
Contributor

@Rajakavitha1 Please squash your commits so we can merge this PR. 👍

Jaice Singer DuMars and others added 8 commits May 21, 2019 18:05
@Rajakavitha1
Create blog post draft (kubernetes#14384)
b4006dc 
* Create blog post draft

* Fixed comma problem and updated Cloud
@zacharysarah @Rajakavitha1
Edits for clarity (kubernetes#14423)
2b1a233
@Rajakavitha1
Fix link (kubernetes#14438)
388ee7c 
* Update imperative-command.md

* Update imperative-command.md
@Rajakavitha1
removed the junk character (kubernetes#14430)
9098f45
@abuango @Rajakavitha1
Switch to long command option (kubernetes#14422)
05b7ac2
@kbhawkey @Rajakavitha1
fix links to tool install (kubernetes#14418)
b3abeba
@41tair @Rajakavitha1
Remove extra '**' (kubernetes#14413)
5efe0b8 
remove extra '*' from the end of the aritcle；
or they have other meanings :D
@Rajakavitha1
Updated links to vendor specific implementions (kubernetes#14400)
5cd7bbb 
The following links where broken

* AZURE
* GCE
* AWS

In case of GCE I assume it changed to GCP, but please confirm if that is correct.
yuchengwu and others added 5 commits May 21, 2019 18:09
@yuchengwu @Rajakavitha1
document pod downwardAPI fieldRef & resourceFiledRef values (kubernet…
6870c1f 
…es#14321)

* document pod downwardAPI fieldRef & resourceRef values of en version

* document pod downwardAPI fieldRef & resourceRef values of zh version

* typo correction
@sftim @Rajakavitha1
Add containerd and CRI-O to glossary (kubernetes#14309)
ad76ca0
@sftim @Rajakavitha1
Use relevant glossary definitions (kubernetes#14414)
f443237
@alex-slynko @Rajakavitha1
Link upgrade to skewed version page (kubernetes#14421)
ac74c8d 
* Link upgrade to skewed version page

It provides the order of upgrade and shows which versions are supported.
Solves (at least partially ) kubernetes#14420

* Update cluster-management.md

* Update cluster-management.md
@gochist @Rajakavitha1
setup page replaces picking the right solutions page
5305013 
Describe language specific style guide in l10n guide (kubernetes#14437)

removed references to Table of solutions

moved [Nutanix Karbon] under the right column
@k8s-ci-robot
Copy link
Contributor

@Rajakavitha1: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 21, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: cody-clark

If they are not already assigned, you can assign the PR to them by writing /assign @cody-clark in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. area/blog Issues or PRs related to the Kubernetes Blog subproject language/zh Issues or PRs related to Chinese language and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 21, 2019
@Rajakavitha1
Copy link
Contributor Author

@zacharysarah !!! Please help.... I messed the squash commits

@Rajakavitha1
Copy link
Contributor Author

was not able to squash commits . inadvertently reverted the commits

@Rajakavitha1 Rajakavitha1 deleted the rajie branch May 21, 2019 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brendandburns brendandburns Awaiting requested review from brendandburns

@mikedanese mikedanese Awaiting requested review from mikedanese

Assignees

@zacharysarah zacharysarah

@cody-clark cody-clark

Labels
area/blog Issues or PRs related to the Kubernetes Blog subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language language/zh Issues or PRs related to Chinese language needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Refactor Picking the Right Solution