Review and update #15074
Review and update #15074
Conversation
k8s-ci-robot
added
cncf-cla: yes
|
/assign @steveperry-53 |
|
Deploy preview for kubernetes-io-master-staging ready! Built with commit 7294207 https://deploy-preview-15074--kubernetes-io-master-staging.netlify.com |
|
/assign @tengqm |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
| This Service will also be assigned an IP address (sometimes called the "cluster IP"), | ||
| which is used by the service proxies | ||
| This Service also assigns an IP address (sometimes called the "cluster IP"), | ||
| which is used by the Service proxies |
There was a problem hiding this comment.
nit: This specification creates a new Service named "my-service", ...
nit, could the link be cleaned up a bit:
This Service also assigns an IP address, or "cluster IP", which is used by the Virtual IPs and service proxies.
| This offers a lot of flexibility for deploying and evolving your Services. | ||
| For example, you can change the port number that pods expose in the next | ||
| For example, you can change the port number the Pods are exposed in the next |
There was a problem hiding this comment.
nit: Not sure about this change.
There was a problem hiding this comment.
This was fixed by a previous commit. Thank you!
There was a problem hiding this comment.
Yup, 🚫 passive voice.
| backend sets. For each Endpoint object, it installs iptables rules which | ||
| select a backend Pod. | ||
|
|
||
| By default, kube-proxy in iptables mode chooses a backend at random. | ||
|
|
||
| Using iptables to handle traffic has a lower system overhead, because traffic | ||
| is handled by Linux netfilter without the need switch between userspace and the | ||
| is handled by Linux netfilter. It removes the need to switch between userspace and the | ||
| kernel space. This approach is also likely to be more reliable. |
There was a problem hiding this comment.
What is the it, iptables or Linux netfilter?
There was a problem hiding this comment.
true.. That's confusing.. am reverting back to the old sentence and did a small nit there.
| When kube-proxy starts in IPVS proxy mode, it will verify whether IPVS | ||
| kernel modules are available, and if those are not detected then kube-proxy | ||
| When kube-proxy starts in IPVS proxy mode, it verifies whether IPVS | ||
| kernel modules are available, and if those are not detected, then kube-proxy |
There was a problem hiding this comment.
nit: fall vs. falls
nit: could the sentence be broken up?
k8s-ci-robot
removed
the
lgtm
|
Hi @kbhawkey and team, Will you be able to help lgtm and approve the PR if the content is good to go, please? :) |
|
hello @shavidissa. I read through the changes. Seems fine. Nice cleanup.
|
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: zacharysarah The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
@kbhawkey 👋 I'm giving the LGTM/approve here to keep things moving, but your feedback here is great and I don't want it to get lost. |
* Review and update * Fix issue 3735 * Update as per the comments * Update as per the comments
Updates the following: