Adding content for allowVolumeExpansion field in StorageClass #15604
Conversation
k8s-ci-robot
added
cncf-cla: yes
|
Deploy preview for kubernetes-io-master-staging ready! Built with commit 94c92c9 https://deploy-preview-15604--kubernetes-io-master-staging.netlify.com |
|
/assign @Rajakavitha1 |
k8s-ci-robot
added
the
do-not-merge/invalid-commit-message
|
thanks for fixing this. lgtm note: please squash the commits into one. |
|
@poothia I have squashed all the commits related to allowVolumeExpansion into one. Should I squash all the commits that are showing up in this PR into one? Apologies for a lot of commit and amends, this is my second PR and I am still learning. |
k8s-ci-robot
removed
the
do-not-merge/invalid-commit-message
|
/lgtm thanks @snathan13 |
k8s-ci-robot
added
the
lgtm
|
/assign @gnufied |
|
good catch, thanks @msau42 |
k8s-ci-robot
removed
the
lgtm
| The following types of volumes support volume expansion, when the underlying | ||
| Storage Class has the field `allowVolumeExpansion` set to true. | ||
|
|
||
| * gcePersistentDisk |
There was a problem hiding this comment.
@gnufied, can you verify which version all of these plugins were implemented in?
There was a problem hiding this comment.
ping @gnufied for confirmation :)
There was a problem hiding this comment.
here is support/version matrix of various volume types look like:
- EBS (1.11)
- Cinder (1.11)
- Glusterfs (1.11)
- GCE PD (1.11)
- Portworx (1.11)
- Azure File (1.11)
- RBD (1.11)
- Azure Disk(1.11)
- Flex Volume (1.13)
- CSI (1.14, 1.15 - Alpha, 1.16 beta)
There was a problem hiding this comment.
It might be worth updating this document and explicitly specify which version of k8s the volume plugin type supported expansion.
@snathan13, Sorry for the late reply. Yes you should squash all the commits for this change and mention all the changes you made in one commit. As it will help in keeping git history concise and clean. We should make multiple commits only when there are a lot of changes in multiple files to make reviewing easy.
Please don't apologise, Even I am still learning! |
There was a problem hiding this comment.
@snathan13 Thanks for this PR! ✨ You're off to a good start. Be sure to respond to reviewer feedback and squash your commits. 👍
|
This lgtm but would like @gnufied to confirm the releases where each of the plugins were implemented. |
|
it's been 19+ days. let's merge and iterate /approve |
k8s-ci-robot
added
the
lgtm
|
/assign @Rajakavitha1 |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dims, jimangel The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
I will create another PR with changes that @gnufied mentioned in the comments above. |
This PR is in reference to issue - #15587. I have added allowVolumeExpansion in the example and have written a paragraph to explain what it is. I have added supported types and a note telling that it cannot be used to shrink volumes. Please review and help me correct if any of the content is not up-to date and if anything else is missing. Thanks!