Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: CRD v1 #15982

Merged
merged 1 commit into from
Sep 6, 2019
Merged

docs: CRD v1 #15982

merged 1 commit into from
Sep 6, 2019

Conversation

sttts
Copy link
Contributor

@sttts sttts commented Aug 21, 2019 •
edited
Loading

TODO:

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 21, 2019
@k8sio-netlify-preview-bot
Copy link
Collaborator

k8sio-netlify-preview-bot commented Aug 21, 2019 •
edited
Loading

Deploy preview for kubernetes-io-vnext-staging processing.

Building with commit e308bcc

https://app.netlify.com/sites/kubernetes-io-vnext-staging/deploys/5d6e82dc9712ff0009f7228b

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Aug 21, 2019
@sttts sttts mentioned this pull request Aug 21, 2019
Closed
@liggitt liggitt mentioned this pull request Aug 23, 2019
Closed
8 tasks
@simplytunde
Copy link
Contributor

@sttts We need this PR ready for review before Sep 3.

@VineethReddy02
Copy link
Contributor

@sttts Is this PR ready or review? As today i.e 3rd Sept is the deadline for docs to be in ready for review state.

@k8s-ci-robot k8s-ci-robot added language/en Issues or PRs related to English language size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 3, 2019
@sttts sttts mentioned this pull request Sep 3, 2019
Closed
@sttts sttts force-pushed the sttts-1.16-crd branch 5 times, most recently from a2ecbc5 to 9206cc3 Compare September 3, 2019 10:09
@liggitt liggitt mentioned this pull request Sep 3, 2019
Merged
@liggitt
Copy link
Member

liggitt commented Sep 3, 2019

remaining items added in sttts#1

@liggitt liggitt mentioned this pull request Sep 3, 2019
Closed
@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 3, 2019
@liggitt
Copy link
Member

liggitt commented Sep 3, 2019

preview links at:

@liggitt
Copy link
Member

liggitt commented Sep 3, 2019

/milestone 1.16

@k8s-ci-robot
Copy link
Contributor

@liggitt: You must be a member of the kubernetes/website-milestone-maintainers GitHub team to set the milestone. If you believe you should be able to issue the /milestone command, please contact your Website milestone maintainers and have them propose you as an additional delegate for this responsibility.

In response to this:

/milestone 1.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

This was referenced Sep 3, 2019
Closed
Closed
Closed
Closed
@liggitt
Copy link
Member

liggitt commented Sep 3, 2019

@VineethReddy02 this is ready for review

@liggitt liggitt mentioned this pull request Sep 3, 2019
Closed
@simplytunde
Copy link
Contributor

/milestone 1.16

@k8s-ci-robot k8s-ci-robot added this to the 1.16 milestone Sep 4, 2019
sftim
sftim reviewed Sep 6, 2019
View reviewed changes
Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall this looks fine to me. I spotted some things that could do with a cleanup, but they're in the existing page.

@simplytunde
Copy link
Contributor

@liggitt can I get a technical lgtm on this if its good to go?

@liggitt
Copy link
Member

liggitt commented Sep 6, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 6, 2019
@simplytunde
Copy link
Contributor

/lgtm

@simplytunde
Copy link
Contributor

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: simplytunde

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 6, 2019
@k8s-ci-robot k8s-ci-robot merged commit 99482ef into kubernetes:dev-1.16 Sep 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sftim sftim sftim left review comments

@Rajakavitha1 Rajakavitha1 Awaiting requested review from Rajakavitha1

@zhangxiaoyu-zidif zhangxiaoyu-zidif Awaiting requested review from zhangxiaoyu-zidif

Assignees

@liggitt liggitt

@simplytunde simplytunde

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
1.16
Development

Successfully merging this pull request may close these issues.
7 participants
@sttts @k8sio-netlify-preview-bot @simplytunde @VineethReddy02 @liggitt @k8s-ci-robot @sftim