Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Persistent Volume documentation for Windows #16017

Merged
merged 1 commit into from
Sep 7, 2019
Merged

Update Persistent Volume documentation for Windows #16017

merged 1 commit into from
Sep 7, 2019

Conversation

ddebroy
Copy link
Member

@ddebroy ddebroy commented Aug 22, 2019 •
edited
Loading

Update support for Persistent Volumes on Windows including new stuff in 1.16:

  1. EBS support
  2. vSphereVolume support
  3. CSI support [Alpha]

@k8sio-netlify-preview-bot
Copy link
Collaborator

k8sio-netlify-preview-bot commented Aug 22, 2019 •
edited
Loading

Deploy preview for kubernetes-io-vnext-staging processing.

Building with commit d007adf

https://app.netlify.com/sites/kubernetes-io-vnext-staging/deploys/5d742ab9620604000cd469ad

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 22, 2019
@ddebroy ddebroy mentioned this pull request Aug 22, 2019
Closed
@k8s-ci-robot k8s-ci-robot added language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Aug 22, 2019
sftim
sftim reviewed Aug 23, 2019
View reviewed changes
content/en/docs/setup/production-environment/windows/intro-windows-in-kubernetes.md Outdated
@@ -111,6 +111,8 @@ Kubernetes Volumes enable complex applications with data persistence and Pod vol
* [azureFile](/docs/concepts/storage/volumes/#azurefile)
* [gcePersistentDisk](/docs/concepts/storage/volumes/#gcepersistentdisk)

Starting with v1.16, Alpha support for CSI plugins will be introduced in Windows nodes.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(In case anyone doesn't spot that this is a placeholder commit), the final text should
avoid making statements about the future.

@simplytunde
Copy link
Contributor

/milestone 1.16

@k8s-ci-robot k8s-ci-robot added this to the 1.16 milestone Aug 28, 2019
@sethmccombs
Copy link
Contributor

Hey team! Today is the day all Docs PRs must be ready for review. Is there a status update for this docs change?

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 4, 2019
@ddebroy ddebroy changed the title Placeholder docs PR for CSI Alpha for Windows Expand Persistent Volume documentation for Windows Sep 4, 2019
@ddebroy ddebroy changed the title Expand Persistent Volume documentation for Windows Update Persistent Volume documentation for Windows Sep 4, 2019
@ddebroy
Copy link
Member Author

ddebroy commented Sep 4, 2019

This is now ready for review.
cc @wk8

wk8
wk8 approved these changes Sep 5, 2019
View reviewed changes
Copy link

@wk8 wk8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
Thanks! :)

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 5, 2019
@simplytunde
Copy link
Contributor

@ddebroy I really appreciate your work on this. Please let's address the reviews so that we can get this in.

@kbhawkey
Copy link
Contributor

kbhawkey commented Sep 5, 2019

Page preview:
https://5d6f15a85e9fbc0007ee79af--kubernetes-io-vnext-staging.netlify.com/docs/setup/production-environment/windows/intro-windows-in-kubernetes/

@simplytunde
Copy link
Contributor

simplytunde commented Sep 6, 2019 •
edited
Loading

@ddebroy This PR is due for merging on Monday Sep 9. We will appreciate any help we can get on addressing the reviews to make sure we have this in before the deadline.

@ddebroy
Update Persisent Volumes doc for Windows
d007adf 
Signed-off-by: Deep Debroy <ddebroy@docker.com>
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 7, 2019
@ddebroy
Copy link
Member Author

ddebroy commented Sep 7, 2019

@kbhawkey thanks for the review! I have addressed the suggestions.

@simplytunde
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 7, 2019
@simplytunde
Copy link
Contributor

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: simplytunde

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 7, 2019
@k8s-ci-robot k8s-ci-robot merged commit 7c513d3 into kubernetes:dev-1.16 Sep 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sftim sftim sftim left review comments

@kbhawkey kbhawkey kbhawkey left review comments

@wk8 wk8 wk8 approved these changes

@michmike michmike Awaiting requested review from michmike

@PatrickLang PatrickLang Awaiting requested review from PatrickLang

Assignees

@wk8 wk8

@simplytunde simplytunde

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
1.16
Development

Successfully merging this pull request may close these issues.
8 participants
@ddebroy @k8sio-netlify-preview-bot @simplytunde @sethmccombs @kbhawkey @k8s-ci-robot @wk8 @sftim