Upgrade 1.13 to Hugo 0.57.2 #16104
Upgrade 1.13 to Hugo 0.57.2 #16104
Conversation
k8s-ci-robot
added
do-not-merge/work-in-progress
|
Deploy preview for k8s-v1-13 ready! Built with commit bba51a0 |
zacharysarah
force-pushed
the
release-1.13
branch
from
8b0dddc to
6bf1a3b
Compare
|
The current commit (6bf1a3b) uses a different variable invocation but produces identical results to the production build. |
Invoke site param as a string Invoke site param as text Remove leading dot Invoke as a page variable Tweak the page param invocation lower case Update Hugo version to 0.57.2
zacharysarah
force-pushed
the
release-1.13
branch
from
6bf1a3b to
b7595a0
Compare
zacharysarah
changed the title
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
|
After poking around at possible solutions, this PR changed course to address similar behavior described in gohugoio/hugo#5615. @BenTheElder Thanks for raising visibility! 🙇 To verify the fix:
|
|
/assign @sftim |
|
👀 |
There was a problem hiding this comment.
I found that whilst https://v1-13.docs.kubernetes.io/docs/tasks/configure-pod-container/assign-memory-resource/ works fine, https://deploy-preview-16104--k8s-v1-13.netlify.com/docs/tasks/configure-pod-container/assign-memory-resource/ shows an error. https://deploy-preview-16104--k8s-v1-13.netlify.com/docs/concepts/ shows no error but the page body is blank.
Similar story:
|
I have a suspicion that Hugo is having problems turning |
|
Same here: That's pretty gross. @sftim If apostrophes are the breaking cause, it seems random. See: |
|
https://github.com/kubernetes/website/blame/abde92139926cfb22cecf06acca207c2b0f85f86/content/en/docs/tasks/configure-pod-container/assign-memory-resource.md#L129 has an apostrophe in a second-level heading. It seems OK to have a What's next section that renders (in the English localization) with an apostrophe. My hypothesis is that apostrophes in the source markdown (lines starting |
That checks out. The "What's Next" line populates from a template: {{% capture whatsnext %}}But it scrambles any content that follows. It also looks like Hugo is trying to populate "error" sections with another template: https://github.com/kubernetes/website/blob/master/layouts/partials/templates/errorthrower.html UPDATE 1: Escaping the apostrophe in the title doesn't resolve the error. ## Exceed a Container\'s memory limitUPDATE 2: It's more than punctuation. Check out https://deploy-preview-16104--k8s-v1-13.netlify.com/docs/concepts/overview/kubernetes-api/, which has no punctuation in any of its headings: https://raw.githubusercontent.com/kubernetes/website/master/content/en/docs/concepts/overview/kubernetes-api.md I think we're looking at broken template handling between 0.53 and 0.57.2. |
zacharysarah
force-pushed
the
release-1.13
branch
from
ce82ba1 to
b7595a0
Compare
|
I've opened a Hugo issue: gohugoio/hugo#6277 In the meantime, there is literally no way this PR should merge. /close |
|
@zacharysarah: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
From gohugoio/hugo#6277 (comment):
The commit hash for #13680 is Only one file affected by #13680 has received subsequent updates: At https://kubernetes.io/case-studies/ the <img src=https://d33wubrfki0l68.cloudfront.net/1f25fd3bb7209410ad60613770321deb5959c2e6/e2c98/images/case_studies/story.png alt="Tell your story"></a>UPDATE: I think we may need to cherry-pick |
|
[I hope] I can also take some time this coming Sunday to look into the issue more. |
|
trying something re:travis EDIT: no such luck 😞 |
|
@BenTheElder: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/reopen |
|
@BenTheElder: Reopened this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
I think a repo admin can |
|
Looks like it passed? /lgtm |
k8s-ci-robot
added
the
lgtm
|
@chenopis 👋 Hey there, PR wrangler! Could you please |
|
hi @zacharysarah . I read through the changes. For my information, this branch built a month ago with Hugo 0.57.2? I am trying to understand the open/close and back/forth of this PR. What changed to make the branch pass? |
|
@kbhawkey Thanks for the review.
See 16104#issuecomment-526452509 ☝️ EDIT: I'm pretty sure I cherry-picked the Travis-killing commit and squashed it. In any case, I'm not about to look a gift horse in the mouth. 🐴 👀 😴 🤞 |
|
/approve |
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jimangel, kbhawkey The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Modify apparmor.md and delete .profile to enable the site to build with Hugo 0.57.2. Could not cherry pick PR 16531 because the Korean translation was added in 1.14. See also PRs #16104 and #16151. zh/docs/reference/setup-tools/kubeadm/generated/README.md updated to fix 'invalid YAML delimiter' compile error caused by HTML comment. Signed-off-by: Aimee Ukasick <aimeeu.opensource@gmail.com>
Fixes #16066
EDIT: #16066 exhibits behavior characteristic of gohugoio/hugo#5615. To resolve the issue, we need to upgrade Hugo to a version that includes the solution.