-
Notifications
You must be signed in to change notification settings - Fork 14.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename architecture section #16286
Merged
k8s-ci-robot
merged 2 commits into
kubernetes:master
from
sftim:20190910_cluster_architecture
Oct 9, 2019
Merged
Rename architecture section #16286
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,5 @@ | ||
--- | ||
title: "Kubernetes Architecture" | ||
title: "Cluster Architecture" | ||
weight: 30 | ||
--- | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My only gripe with this is that, interestingly enough, the term "cluster" isn't really defined in the Concepts pages. The "What is Kubernetes" page doesn't mention "cluster" anywhere. The "Kubernetes Components" page mentions cluster plenty of times but doesn't actually define it. The Glossary does have a term for "cluster", though:
So, while I totally agree that "Kubernetes" is redundant, I guess I'd prefer to replace "Cluster" with "System" or add a "Concepts -> Cluster" page that explains what we mean by "Cluster" first. Thoughts?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's add cluster to the glossary, either as well or instead of what you're suggesting @jaypipesOops, misread!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cluster is in the glossary already with the definition above. I guess what I'm pointing out is that the Concepts section doesn't really have anything that says what a cluster is even though the term cluster is used in a number of the Concepts pages. So, perhaps good to modify the "What is Kubernetes" page to define what the term "cluster" refers to, and then it would be good to go forward with this PR change that changes the "Kubernetes Architecture" title to "Cluster Architecture". Hope that makes sense.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can revise this PR to do that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jaypipes how about this (revised) approach?
If you think it's still short of the mark, please do say so.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sftim It looks like you've addressed the feedback from @jaypipes, and that this PR is headed in the right direction, so I'll
/approve
and @jaypipes can/lgtm
if he agrees./approve