Documentation for NodeLease feature being promoted to GA #17189

wojtek-t · 2019-10-25T11:28:57Z

Ref kubernetes/enhancements#589

k8sio-netlify-preview-bot · 2019-10-25T11:29:02Z

Deploy preview for kubernetes-io-vnext-staging processing.

Building with commit 718d644

https://app.netlify.com/sites/kubernetes-io-vnext-staging/deploys/5dd284e1b4847e0008bd7af2

wojtek-t · 2019-10-25T11:30:19Z

/milestone v1.17

k8s-ci-robot · 2019-10-25T11:30:19Z

@wojtek-t: You must be a member of the kubernetes/website-milestone-maintainers GitHub team to set the milestone. If you believe you should be able to issue the /milestone command, please contact your Website milestone maintainers and have them propose you as an additional delegate for this responsibility.

In response to this:

/milestone v1.17

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

kbhawkey · 2019-10-25T13:25:38Z

content/en/docs/reference/command-line-tools-reference/feature-gates.md

@@ -202,6 +200,9 @@ The following table contains feature gates for graduated or deprecated features.
 | `MountPropagation` | `false` | Alpha | 1.8 | 1.9 |
 | `MountPropagation` | `true` | Beta | 1.10 | 1.11 |
 | `MountPropagation` | `true` | GA | 1.12 | - |
+| `NodeLease` | `false` | Alpha | 1.12 | 1.13 |
+| `NodeLease` | `true` | Beta | 1.14 | 1.16 |
+| `NodeLease` | `true` | Beta | 1.17 | - |
 | `PersistentLocalVolumes` | `false` | Alpha | 1.7 | 1.9 |


hello @wojtek-t . Some initial suggestions:

Line 205: Is the state GA?

Line 177: the kubelet or the Kubelet?

Line 182: This sentence could be reworded and possibly add more explanation, spelling too. Does this make sense?
Compared to the Node resource, the Lease object is lightweight. The Lease resource improves the performance of the node heartbeats as the cluster scales?

From the KEP:
We will use that object to represent node heartbeat - for each Node there will be a corresponding Lease object with Name equal to Node name in a newly created dedicated namespace

sftim

Informal feedback

sftim · 2019-10-25T16:43:16Z

content/en/docs/concepts/architecture/nodes.md

-node lease is much more lightweight than NodeStatus, this feature makes node
-heartbeat significantly cheaper from both scalability and performance
-perspectives.
+Each node has an associated `Lease` object in `kube-node-lease` namespace.


nit

Suggested change

Each node has an associated `Lease` object in `kube-node-lease` namespace.

Each Node has an associated `Lease` object in the `kube-node-lease` namespace.

Alternatively (see other comment) omit this line.

sftim · 2019-10-25T16:45:20Z

content/en/docs/concepts/architecture/nodes.md

+Node leases are renewed frequently while NodeStatus is reported from node to
+master only where there is some change or enough time has passed (default is
+5 minutes, which is longer than the default timeout of 40 seconds for
+unreachable nodes). Since Lease is much more lighweigh object than Node,


Typo: “lighweigh”

This page is about Nodes, and the reader could be totally new to Kubernetes. This page is a lot of detail to explain what a Node is. If anything, I'd prefer to slim it further.

How about a heading: “Node leases” plus 100 words on the control plane issuing Node leases to keep track of Node health / failures.

Does NodeStatus even need mentioning here?

I think it does - the reason is that for the last 5 years, NodeStatus was the only signal for heartbeat. Now this is only treated as an additional one.

That said, I tried to rephrase it a bit (applied suggestions by @kbhawkey ) and slightly better organize.

makoscafee · 2019-11-04T23:18:23Z

/milestone 1.17

wojtek-t

Comments applied - PTAL

wojtek-t · 2019-11-07T13:31:52Z

content/en/docs/concepts/architecture/nodes.md

-node lease is much more lightweight than NodeStatus, this feature makes node
-heartbeat significantly cheaper from both scalability and performance
-perspectives.
+Each node has an associated `Lease` object in `kube-node-lease` namespace.


wojtek-t · 2019-11-08T07:29:35Z

content/en/docs/concepts/architecture/nodes.md

+Node leases are renewed frequently while NodeStatus is reported from node to
+master only where there is some change or enough time has passed (default is
+5 minutes, which is longer than the default timeout of 40 seconds for
+unreachable nodes). Since Lease is much more lighweigh object than Node,


I think it does - the reason is that for the last 5 years, NodeStatus was the only signal for heartbeat. Now this is only treated as an additional one.

wojtek-t · 2019-11-08T07:30:17Z

content/en/docs/reference/command-line-tools-reference/feature-gates.md

@@ -202,6 +200,9 @@ The following table contains feature gates for graduated or deprecated features.
 | `MountPropagation` | `false` | Alpha | 1.8 | 1.9 |
 | `MountPropagation` | `true` | Beta | 1.10 | 1.11 |
 | `MountPropagation` | `true` | GA | 1.12 | - |
+| `NodeLease` | `false` | Alpha | 1.12 | 1.13 |
+| `NodeLease` | `true` | Beta | 1.14 | 1.16 |
+| `NodeLease` | `true` | Beta | 1.17 | - |
 | `PersistentLocalVolumes` | `false` | Alpha | 1.7 | 1.9 |


wojtek-t · 2019-11-08T07:31:05Z

content/en/docs/concepts/architecture/nodes.md

+Node leases are renewed frequently while NodeStatus is reported from node to
+master only where there is some change or enough time has passed (default is
+5 minutes, which is longer than the default timeout of 40 seconds for
+unreachable nodes). Since Lease is much more lighweigh object than Node,


That said, I tried to rephrase it a bit (applied suggestions by @kbhawkey ) and slightly better organize.

sftim

Some feedback - hope it's useful.

sftim · 2019-11-08T08:51:58Z

content/en/docs/concepts/architecture/nodes.md

+#### Heartbeats
+
+Each Node  has an associated `Lease` object in `kube-node-lease` namespace.
+It is periodically renewed by the kubelet and both NodeStatus and the Lease


Suggested change

It is periodically renewed by the kubelet and both NodeStatus and the Lease

The kubelet updates its Lease object frequently to show that its Node is healthy. In the control plane, both NodeStatus and the Lease

sftim · 2019-11-08T08:54:16Z

content/en/docs/concepts/architecture/nodes.md

+Each Node  has an associated `Lease` object in `kube-node-lease` namespace.
+It is periodically renewed by the kubelet and both NodeStatus and the Lease
+are treated as heartbeats from the node.
+Node leases are renewed frequently while NodeStatus is reported from node to


If accepting the previous suggestion, how about this wording?

The kubelet updates NodeStatus either when there is change in status, or if there has been no update for a configured interval. The default interval for NodeStatus updates is 5 minutes (much longer than the 40 second default timeout for unreachable nodes).

sftim · 2019-11-08T08:55:48Z

content/en/docs/concepts/architecture/nodes.md

+Node leases are renewed frequently while NodeStatus is reported from node to
+master only where there is some change or enough time has passed (default is
+5 minutes, which is longer than the default timeout of 40 seconds for
+unreachable nodes). Compared to the Node resource, the Lease object is


Compared to the Node resource, the Lease object is lightweight. The Lease resource improves the performance of the node heartbeats as the cluster scales.

As NodeLease is GA (once this is merged, at least), and the oldest supported Kubernetes version will have NodeLease enabled by default, it's less important to explain the older method. I think it's OK to assume that readers are using NodeLease and that it pretty much “just works” for them.
I would cut out these 2 sentences.

I'm not sure - this shows why this is even needed.

sftim · 2019-11-08T09:00:01Z

content/en/docs/concepts/architecture/nodes.md

-perspectives.
+#### Heartbeats
+
+Each Node  has an associated `Lease` object in `kube-node-lease` namespace.


Suggested change

Each Node has an associated `Lease` object in `kube-node-lease` namespace.

Each Node has an associated Lease object in the `kube-node-lease` {{< glossary_tooltip term_id="namespace" text="namespace">}}.

wojtek-t · 2019-11-08T14:17:48Z

PTAL

content/en/docs/concepts/architecture/nodes.md

wojtek-t · 2019-11-13T07:36:48Z

@kbhawkey - PTAL

wojtek-t · 2019-11-13T14:01:45Z

PTAL

content/en/docs/concepts/architecture/nodes.md

daminisatya · 2019-11-13T15:52:36Z

@sftim review from your side? Is it a lgtm?

sftim

I'm happy with these changes.

wojtek-t · 2019-11-14T11:13:38Z

Thanks!
Can someone approve these changes then?

sftim · 2019-11-14T15:33:01Z

@daminisatya ?

sftim

I notice a bunch of tiny, nit changes (mainly extra backticks). Also fine to merge as is, IMO.

sftim · 2019-11-14T15:33:55Z

content/en/docs/concepts/architecture/nodes.md

+Compared to the Node resource, the Lease is a lightweight resource, which improves
+the performance of the node heartbeats as the cluster scales.
+
+The `kubelet` is responsible for creating and updating `NodeStatus` and `Lease`.


Late, nit tweaks:

Suggested change

The `kubelet` is responsible for creating and updating `NodeStatus` and `Lease`.

The kubelet is responsible for creating and updating `NodeStatus` and a Lease.

sftim · 2019-11-14T15:34:12Z

content/en/docs/concepts/architecture/nodes.md

+
+The `kubelet` is responsible for creating and updating `NodeStatus` and `Lease`.
+
+- The `kubelet` updates the `NodeStatus` either when there is change in status,


Suggested change

- The `kubelet` updates the `NodeStatus` either when there is change in status,

- The kubelet updates the `NodeStatus` either when there is change in status,

sftim · 2019-11-14T15:34:46Z

content/en/docs/concepts/architecture/nodes.md

+  or if there has been no update for a configured interval. The default interval
+  for `NodeStatus` updates is 5 minutes (much longer than the 40 second default
+  timeout for unreachable nodes).
+- The `kubelet` creates and then updates the `Lease` object every 10 seconds


Suggested change

- The `kubelet` creates and then updates the `Lease` object every 10 seconds

- The kubelet creates and then updates its Lease object every 10 seconds

sftim · 2019-11-14T15:36:05Z

content/en/docs/concepts/architecture/nodes.md

+  for `NodeStatus` updates is 5 minutes (much longer than the 40 second default
+  timeout for unreachable nodes).
+- The `kubelet` creates and then updates the `Lease` object every 10 seconds
+  (the default update interval). `Lease` updates occur independently from the


Suggested change

(the default update interval). `Lease` updates occur independently from the

(the default update interval). Lease updates occur independently from the

wojtek-t

@sftim - done; PTAL

wojtek-t · 2019-11-14T16:50:48Z

content/en/docs/concepts/architecture/nodes.md

+
+The `kubelet` is responsible for creating and updating `NodeStatus` and `Lease`.
+
+- The `kubelet` updates the `NodeStatus` either when there is change in status,


wojtek-t · 2019-11-14T16:51:08Z

content/en/docs/concepts/architecture/nodes.md

+  or if there has been no update for a configured interval. The default interval
+  for `NodeStatus` updates is 5 minutes (much longer than the 40 second default
+  timeout for unreachable nodes).
+- The `kubelet` creates and then updates the `Lease` object every 10 seconds


wojtek-t · 2019-11-14T16:51:22Z

content/en/docs/concepts/architecture/nodes.md

+  for `NodeStatus` updates is 5 minutes (much longer than the 40 second default
+  timeout for unreachable nodes).
+- The `kubelet` creates and then updates the `Lease` object every 10 seconds
+  (the default update interval). `Lease` updates occur independently from the


wojtek-t · 2019-11-14T16:51:52Z

content/en/docs/concepts/architecture/nodes.md

+Compared to the Node resource, the Lease is a lightweight resource, which improves
+the performance of the node heartbeats as the cluster scales.
+
+The `kubelet` is responsible for creating and updating `NodeStatus` and `Lease`.


kbhawkey · 2019-11-14T19:15:18Z

content/en/docs/concepts/architecture/nodes.md

+Heartbeats, sent by Kubernetes nodes, help determine the availability of a node.
+There are two forms of heartbeats: updates of `NodeStatus` and the
+[Lease object](/docs/reference/generated/kubernetes-api/{{< latest-version >}}/#lease-v1-coordination-k8s-io).
+Each Node has an associated `Lease` object in the `kube-node-lease`


These changes look good. If you are cleaning up nits ...

There is one more Lease to clean up the backticks on line 181.

Also, I think command tools (kubelet, kubectl) typically are quoted with backticks, throughout the docs.
For example: https://kubernetes.io/docs/tasks/administer-cluster/out-of-resource/
Though, there are other places where the kubelet is not emphasized.

kubectl is 100% a command line tool. kubelet, whilst also an executable, isn't a tool that people usually run in a command line, at least not during typical cluster operation. I see kubelet fitting into the same slot as kube-scheduler, kube-controller-manager, and kube-proxy.

(I've used backticks for those names in this very comment but in the docs I typically wouldn't).

Fixed the Lease.

I agree with @sftim that kubelet is in the same category as kube-scheduler, etc.
[in this file kubelet is not in backsticks anywhere]

Hello @wojtek-t . It feels like these changes should be ready 😀 . Okay to override these comments, but if you have the energy for one more change, I'd suggest splitting/adjusting lines 183 - 184.

Lease is a lightweight resource, which improves the performance of the node heartbeats as the cluster scales.
OR
Lease is a smaller resource than the Node, which improves the performance of the node heartbeats as the cluster scales.

Line 186: The kubelet is responsible for creating and updating the NodeStatus and a Lease object.

wojtek-t · 2019-11-15T09:18:03Z

@sftim @kbhawkey - PTAL

wojtek-t · 2019-11-18T11:48:29Z

@sftim @kbhawkey - I applied the next comment. PTAL
[That said, can we have it merged? I have a feeling that we can do those iterations indefinitely...]

kbhawkey · 2019-11-18T13:11:33Z

/lgtm

kbhawkey · 2019-11-18T13:12:21Z

😁
/approve

k8s-ci-robot · 2019-11-18T13:12:35Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kbhawkey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~content/en/OWNERS~~ [kbhawkey]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

wojtek-t · 2019-11-18T13:27:59Z

@kbhawkey - thanks a lot!

* feat: graduate TaintNodesByCondition to GA (#17073) * Promote StartupProbe to beta (enabled by default). (#17164) * Watch bookmarks to GA (#17026) * feat: graduate ScheduleDaemonSetPods to GA (#17350) * Update Docker installation instructions (#17405) * Use exact version numbers for installing Docker in Ubuntu (#17428) * Move CSIMigration and CSIMigrationGCE to Beta in Kubernetes v1.17 (#17478) * Promote NodeLease feature to GA (#17189) * Update docs for csi topology ga (#17408) * Update RunAsUsername to beta (#17460) * doc:Update RunAsUsername to beta * doc: update samples - kubernetes.io/os is no longer beta * Updating based on review feedback * Promote Node-specific volume limits to GA (#17432) * Promote PodShareProcessNamespace to stable (#17192) * Promote PodShareProcessNamespace to stable * Add for_k8s_version to feature-state label Co-Authored-By: Tim Bannister <tim@scalefactory.com> * Readd version-check to shareProcessNamespace task * Update service load balancer finalizer doc for GA (#17438) * Update Topology Manager docs (#17451) * Added information on how device plugins can take advantage of Topology Manager * Updated the Topology Manager documentation to include additionalinformation and update some out of date sections * Fix broken Topology Manager link (#17746) Part of What's Next Device Plugin section * Update CRD defaulting docs for GA (#17450) * Add documentation for VolumeSnapshot Beta (#17233) * Updating EndpointSlice documentation for beta release in 1.17 (#17411) * (docs/dualstack): v1.17 updates (#17457) * Add placehold doc updates for dualstack in 1.17 Signed-off-by: Lachlan Evenson <lachlan.evenson@microsoft.com> * Add Downward API and /etc/hosts Pod IP validation Signed-off-by: Lachlan Evenson <lachlan.evenson@microsoft.com> * remove addressed known issue via k/k pr 85246 Signed-off-by: Lachlan Evenson <lachlan.evenson@microsoft.com> * Remove known issue and add flag as part of k/k 79993 Signed-off-by: Lachlan Evenson <lachlan.evenson@microsoft.com> * remove follow up placeholders Signed-off-by: Lachlan Evenson <lachlan.evenson@microsoft.com> * Update verbiage Signed-off-by: Lachlan Evenson <lachlan.evenson@microsoft.com> * Make IP addressing consistent throughout the task Signed-off-by: Lachlan Evenson <lachlan.evenson@microsoft.com> * Update to status.podIPs Signed-off-by: Lachlan Evenson <lachlan.evenson@microsoft.com> * Update content/en/docs/tasks/network/validate-dual-stack.md Use set instead of env Co-Authored-By: Khaled Henidak (Kal) <khnidk@outlook.com> * add topology.kubernetes.io/zone, topology.kubernetes.io/region and node.kubernetes.io/instance-type labels to docs (#17498) Signed-off-by: Andrew Sy Kim <kiman@vmware.com> * Service topology alpha documentation (#17459) * Update list of feature flags for in-tree plugins migrated to CSI (#17533) Signed-off-by: Deep Debroy <ddebroy@docker.com> * Update Node concept for TaintNodesByCondition going GA (#17577) * feat: graduate ResourceQuotaScopeSelectors to GA in 1.17 (#17554) * kubeadm: update the upgrade documentation for 1.17 (#17587) * doc: Simplify Windows deployments with RuntimeClass (#16697) * doc: Simplify Windows deployments with RuntimeClass * Updating on review feedback * doc: Adding windows-build label from enhancement 1301 * update doc for kubelet option --reserved-cpus (#17648) * feat: update TaintNodesByCondition in feature gates table (#17377) * Update docs for v1 resource quota configuration (#17547) * AdmissionConfiguration v1 (#17548) * Update WebhookAdmissionConfiguration examples (#17549) * Update AWS EBS Migration Feature state (#16126) * Add resource version section to api-concepts documentation (#16910) * Add Resource Version semantics section to api concepts * Clarify risks of going back in time, add details about compaction and watch cache sizes * Apply suggestions from liggitt Co-Authored-By: Jordan Liggitt <jordan@liggitt.net> * remove pesudocode, apply feedback * Fix typo * Clarify equality rules * Cleanup kubectl generators docs (#17609) * Write ReplicationController without a space * Drop mentioning unsupported cluster versions * Fix capitalization for “API group” * Tweak wording * Avoid using deprecated generator in example * add Antrea description in dev-1.17 (#17919) * Promote VolumeSubpathEnvExpansion to GA * Reference Documentation for the Kubernetes API for 1.17 (#18019) * Update feature-gates.md (#18033) * Reference Documentation for kubectl Commands for 1.17 (#18017) * Update for v1.17 (#18034) * Update config.toml(release-1.17) for 1.17 (#18031)

k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Oct 25, 2019

k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Oct 25, 2019

k8s-ci-robot requested review from dchen1107 and Rajakavitha1 October 25, 2019 11:29

kbhawkey reviewed Oct 25, 2019

View reviewed changes

sftim reviewed Oct 25, 2019

View reviewed changes

k8s-ci-robot added this to the 1.17 milestone Nov 4, 2019

wojtek-t mentioned this pull request Nov 6, 2019

Move frequent Kubelet heartbeats to Lease API kubernetes/enhancements#589

Closed

6 tasks

wojtek-t force-pushed the node_lease_ga branch from 9b56495 to 3bd6c53 Compare November 8, 2019 07:30

k8s-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 8, 2019

wojtek-t commented Nov 8, 2019

View reviewed changes

wojtek-t force-pushed the node_lease_ga branch from 3bd6c53 to ee251d9 Compare November 8, 2019 07:32

k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 8, 2019

sftim reviewed Nov 8, 2019

View reviewed changes

wojtek-t force-pushed the node_lease_ga branch from ee251d9 to a8d83ff Compare November 8, 2019 14:16

kbhawkey reviewed Nov 8, 2019

View reviewed changes

content/en/docs/concepts/architecture/nodes.md Show resolved Hide resolved

kbhawkey mentioned this pull request Nov 10, 2019

Improve Node, Taints, and Tolerations concepts #17509

Merged

wojtek-t force-pushed the node_lease_ga branch from a8d83ff to 906b9f9 Compare November 12, 2019 10:30

wojtek-t changed the title ~~[WIP] [Placeholder] Promote NodeLease feature to GA~~ Documentation for NodeLease feature being promoted to GA Nov 12, 2019

wojtek-t force-pushed the node_lease_ga branch from 5308363 to 2ef0bc8 Compare November 13, 2019 14:01

kbhawkey reviewed Nov 13, 2019

View reviewed changes

content/en/docs/concepts/architecture/nodes.md Outdated Show resolved Hide resolved

wojtek-t force-pushed the node_lease_ga branch from 2ef0bc8 to 09b1000 Compare November 13, 2019 15:01

k8s-ci-robot assigned kbhawkey Nov 13, 2019

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 13, 2019

sftim approved these changes Nov 14, 2019

View reviewed changes

sftim reviewed Nov 14, 2019

View reviewed changes

wojtek-t force-pushed the node_lease_ga branch from 09b1000 to 573a86e Compare November 14, 2019 16:52

k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 14, 2019

wojtek-t commented Nov 14, 2019

View reviewed changes

kbhawkey reviewed Nov 14, 2019

View reviewed changes

wojtek-t force-pushed the node_lease_ga branch from 573a86e to 75102e4 Compare November 15, 2019 09:17

Promote NodeLease feature to GA

718d644

wojtek-t force-pushed the node_lease_ga branch from 75102e4 to 718d644 Compare November 18, 2019 11:47

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 18, 2019

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 18, 2019

k8s-ci-robot merged commit 23d2123 into kubernetes:dev-1.17 Nov 18, 2019

mrbobbytables pushed a commit that referenced this pull request Dec 6, 2019

Promote NodeLease feature to GA (#17189)

1a884b1

	Each node has an associated `Lease` object in `kube-node-lease` namespace.
	Each Node has an associated `Lease` object in the `kube-node-lease` namespace.

	It is periodically renewed by the kubelet and both NodeStatus and the Lease
	The kubelet updates its Lease object frequently to show that its Node is healthy. In the control plane, both NodeStatus and the Lease

	Each Node has an associated `Lease` object in `kube-node-lease` namespace.
	Each Node has an associated Lease object in the `kube-node-lease` {{< glossary_tooltip term_id="namespace" text="namespace">}}.

	The `kubelet` is responsible for creating and updating `NodeStatus` and `Lease`.
	The kubelet is responsible for creating and updating `NodeStatus` and a Lease.


		The `kubelet` is responsible for creating and updating `NodeStatus` and `Lease`.

		- The `kubelet` updates the `NodeStatus` either when there is change in status,

	- The `kubelet` updates the `NodeStatus` either when there is change in status,
	- The kubelet updates the `NodeStatus` either when there is change in status,

	- The `kubelet` creates and then updates the `Lease` object every 10 seconds
	- The kubelet creates and then updates its Lease object every 10 seconds

	(the default update interval). `Lease` updates occur independently from the
	(the default update interval). Lease updates occur independently from the

Documentation for NodeLease feature being promoted to GA #17189

Documentation for NodeLease feature being promoted to GA #17189

Conversation

wojtek-t commented Oct 25, 2019

k8sio-netlify-preview-bot commented Oct 25, 2019 • edited Loading

wojtek-t commented Oct 25, 2019

k8s-ci-robot commented Oct 25, 2019

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sftim left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

makoscafee commented Nov 4, 2019

wojtek-t left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sftim left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

wojtek-t commented Nov 8, 2019

wojtek-t commented Nov 13, 2019

wojtek-t commented Nov 13, 2019

daminisatya commented Nov 13, 2019

sftim left a comment

Choose a reason for hiding this comment

wojtek-t commented Nov 14, 2019

sftim commented Nov 14, 2019

sftim left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sftim Nov 14, 2019 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

wojtek-t left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kbhawkey Nov 14, 2019 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

wojtek-t commented Nov 15, 2019

wojtek-t commented Nov 18, 2019

kbhawkey commented Nov 18, 2019

kbhawkey commented Nov 18, 2019

k8s-ci-robot commented Nov 18, 2019

wojtek-t commented Nov 18, 2019

k8sio-netlify-preview-bot commented Oct 25, 2019 •

edited

Loading

sftim Nov 14, 2019 •

edited

Loading

kbhawkey Nov 14, 2019 •

edited

Loading