Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Promote WindowsGMSA feature to GA. #19349

Merged
merged 1 commit into from
Mar 17, 2020
Merged

Promote WindowsGMSA feature to GA. #19349

merged 1 commit into from
Mar 17, 2020

Conversation

ddebroy
Copy link
Member

@ddebroy ddebroy commented Feb 27, 2020 •
edited
Loading

Doc update for promotion of GMSA feature to Stable

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 27, 2020
@k8sio-netlify-preview-bot
Copy link
Collaborator

k8sio-netlify-preview-bot commented Feb 27, 2020 •
edited
Loading

Deploy preview for kubernetes-io-vnext-staging processing.

Building with commit 961953c

https://app.netlify.com/sites/kubernetes-io-vnext-staging/deploys/5e6fdca93e8781000bb55510

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Feb 27, 2020
@ddebroy ddebroy mentioned this pull request Feb 27, 2020
Closed
@sftim
Copy link
Contributor

sftim commented Feb 29, 2020

I'll tell Prow this is a placeholder
/retitle [WIP] Promote WindowsGMSA feature to GA

@k8s-ci-robot k8s-ci-robot changed the title Placeholder PR for GMSA promotion to Stable [WIP] Promote WindowsGMSA feature to GA Feb 29, 2020
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 29, 2020
sftim
sftim reviewed Feb 29, 2020
View reviewed changes
Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@irvifa
Copy link
Member

irvifa commented Mar 3, 2020

Hi @ddebroy 👋 any plan on adding more docs on this part or is this already done?

@JeremyWx
Copy link

JeremyWx commented Mar 4, 2020

@irvifa the docs for this feature are complete.

@irvifa irvifa changed the title [WIP] Promote WindowsGMSA feature to GA Promote WindowsGMSA feature to GA. Mar 6, 2020
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 6, 2020
@irvifa
Copy link
Member

irvifa commented Mar 6, 2020

@JeremyWx thanks for the confirmation. cc @ddebroy

@sftim do we need additional tech reviewer for this? This is already complete

sftim
sftim reviewed Mar 6, 2020
View reviewed changes
Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 6, 2020
@sftim
Copy link
Contributor

sftim commented Mar 6, 2020

One thing though @ddebroy - can you rebase this against dev-1.18?

@VineethReddy02
Copy link
Contributor

👋 Please rebase this PR on dev-1.18 in order to avoid merge conflicts.

Feel free to /hold cancel after you've rebased.

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 7, 2020
@sftim
Copy link
Contributor

sftim commented Mar 8, 2020

@ddebroy please also update the PR description if this is no longer a placeholder PR.

@JeremyWx
Copy link

@sftim @ddebroy will be on leave for at least the next few weeks. He has given me access to his repo. To be clear, I will need to rebase and update the description for this to pass?

@sftim
Copy link
Contributor

sftim commented Mar 10, 2020

Ah, it's OK. An updated description makes reviewers more likely to see this, but it's fine.
Can you do the rebase though (and force-push it) @JeremyWx?

@JeremyWx
Copy link

@sftim yes I will get that done today, tomorrow at the latest.

@JeremyWx JeremyWx mentioned this pull request Mar 11, 2020
Closed
@kbhawkey
Copy link
Contributor

@JeremyWx @ddebroy , Is this pull request a duplicate of #19604 (close if a duplicate)?

@irvifa
Copy link
Member

irvifa commented Mar 14, 2020

Hi @JeremyWx @ddebroy
We are very close to the docs final deadline i.e All 1.18 enhancements docs should be in ready to merge state by Monday 16th March. Please make sure to complete all the docs reviews before the deadline.

Thanks!

@jimangel
Copy link
Member

/milestone 1.18

@k8s-ci-robot k8s-ci-robot added this to the 1.18 milestone Mar 16, 2020
@VineethReddy02
Copy link
Contributor

Hi @ddebroy
Today is the deadline for 1.18 docs to be ready to merge state. Can we know the status of this PR?

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 16, 2020
@ddebroy
Copy link
Member Author

ddebroy commented Mar 16, 2020

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 16, 2020
@ddebroy
Copy link
Member Author

ddebroy commented Mar 16, 2020

Rebased and updated the PR.

@ddebroy
Copy link
Member Author

ddebroy commented Mar 16, 2020 •
edited
Loading

@sftim @VineethReddy02 this is now ready.

sftim
sftim requested changes Mar 16, 2020
View reviewed changes
Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I saw one thing to fix on the feature gates page (I think): the docs should list the releases when this feature went alpha and then beta.

If this went straight to GA then please comment to document that and in that case the PR LGTM.

content/en/docs/reference/command-line-tools-reference/feature-gates.md Show resolved Hide resolved
@ddebroy
Doc update for GMSA promotion to Stable
961953c 
Signed-off-by: Deep Debroy <ddebroy@docker.com>
sftim
sftim reviewed Mar 16, 2020
View reviewed changes
Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 16, 2020
@VineethReddy02
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: VineethReddy02

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 17, 2020
@k8s-ci-robot k8s-ci-robot merged commit 91609e6 into kubernetes:dev-1.18 Mar 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sftim sftim sftim requested changes

@Bradamant3 Bradamant3 Awaiting requested review from Bradamant3

@daminisatya daminisatya Awaiting requested review from daminisatya

Assignees

@sftim sftim

@VineethReddy02 VineethReddy02

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
1.18
Development

Successfully merging this pull request may close these issues.
9 participants
@ddebroy @k8sio-netlify-preview-bot @sftim @irvifa @JeremyWx @VineethReddy02 @kbhawkey @jimangel @k8s-ci-robot