Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add content/es/docs/tasks/debug-application-cluster #22486

Merged
merged 1 commit into from
Jul 13, 2020
Merged

Add content/es/docs/tasks/debug-application-cluster #22486

merged 1 commit into from
Jul 13, 2020

Conversation

raelga
Copy link
Member

@raelga raelga commented Jul 13, 2020 •
edited
Loading

Solves the CLA and rebase issues of #13981

@raelga raelga self-assigned this Jul 13, 2020
@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jul 13, 2020
@k8s-ci-robot k8s-ci-robot added language/es Issues or PRs related to Spanish language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Jul 13, 2020
@raelga raelga force-pushed the es/docs/tasks/debug-application-cluster branch from 501c20e to e4d482e Compare July 13, 2020 10:07
@raelga
Copy link
Member Author

raelga commented Jul 13, 2020

/check-cla

@raelga raelga force-pushed the es/docs/tasks/debug-application-cluster branch from e4d482e to 6df3223 Compare July 13, 2020 10:15
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Jul 13, 2020
@netlify
Copy link

netlify bot commented Jul 13, 2020

Deploy preview for kubernetes-io-master-staging ready!

Built with commit 501c20e

https://deploy-preview-22486--kubernetes-io-master-staging.netlify.app

@raelga raelga mentioned this pull request Jul 13, 2020
Closed
@netlify
Copy link

netlify bot commented Jul 13, 2020

Deploy preview for kubernetes-io-master-staging ready!

Built with commit 6df3223

https://deploy-preview-22486--kubernetes-io-master-staging.netlify.app

@emedina
Copy link
Contributor

emedina commented Jul 13, 2020

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 13, 2020
@raelga
Copy link
Member Author

raelga commented Jul 13, 2020

Muchísimas ganas @emedina!

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: raelga

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 13, 2020
@k8s-ci-robot k8s-ci-robot merged commit 92ba70f into kubernetes:master Jul 13, 2020
sftim
sftim reviewed Jul 13, 2020
View reviewed changes
content/es/docs/tasks/debug-application-cluster/debug-init-containers.md
Comment on lines +22 to +24
{{% /capture %}}

{{% capture steps %}}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks invalid. I'll propose a pull request to fix it.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can do it, this comes from a really old branch. #13981

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done in #22494

@raelga raelga deleted the es/docs/tasks/debug-application-cluster branch July 13, 2020 17:50
@sftim sftim mentioned this pull request Jul 13, 2020
Merged
@raelga raelga mentioned this pull request Jul 13, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sftim sftim sftim left review comments

@alexbrand alexbrand Awaiting requested review from alexbrand

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

Assignees

@emedina emedina

@raelga raelga

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/es Issues or PRs related to Spanish language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@raelga @k8s-ci-robot @emedina @sftim