-
Notifications
You must be signed in to change notification settings - Fork 14.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add blog post: Using Finalizers to Control Deletion #26997
Add blog post: Using Finalizers to Control Deletion #26997
Conversation
Welcome @aaron-kasten! |
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Deploy preview for kubernetes-io-master-staging ready! Built with commit 07068ce https://deploy-preview-26997--kubernetes-io-master-staging.netlify.app |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi. “Finaliers” is misspelled, it should be Finalizers.
I've added some other feedback.
Would you be interested in turning this page into a task? For example, “Use finalizers to control deletion” could be an appropriate title.
content/en/blog/_posts/2021-03-03-deletes-finaliers-and-owner-references.md
Outdated
Show resolved
Hide resolved
content/en/blog/_posts/2021-03-03-deletes-finaliers-and-owner-references.md
Outdated
Show resolved
Hide resolved
content/en/blog/_posts/2021-03-03-deletes-finaliers-and-owner-references.md
Outdated
Show resolved
Hide resolved
content/en/blog/_posts/2021-03-03-deletes-finaliers-and-owner-references.md
Outdated
Show resolved
Hide resolved
5c58f32
to
d8331bb
Compare
@sftim thank you for the feedback! I integrated the changes - hopefully an improvement. I went with "Using finalizers to control deletion" opposed to "Use finalizers to control deletion" - will switch to "use" if you think its a better choice. |
@sftim what is the next step for approval? Are there any actions I need to take on this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple more fixes needed I think. Also, would you be willing to squash the commits in this article @aaron-kasten
(if you're not sure but you're happy to have the changes combined, we can do that squashing for you).
content/en/blog/_posts/2021-03-03-using-finalizers-to-control-deletion.md
Outdated
Show resolved
Hide resolved
content/en/blog/_posts/2021-03-03-using-finalizers-to-control-deletion.md
Outdated
Show resolved
Hide resolved
2b17605
to
ddbde0a
Compare
I think that's it... tell me if there's anything else. |
@sftim how does this PR look. Is it ready for merge? |
/retitle Add blog post: Using Finalizers to Control Deletion |
Preview: Using Finalizers to Control Deletion |
We'll follow the review process or something roughly like it. At the moment the blog team is a little short on volunteers I'm afraid. |
@sftim I understand. Tell me if there's anything I can do to help it along. |
content/en/blog/_posts/2021-03-03-using-finalizers-to-control-deletion.md
Outdated
Show resolved
Hide resolved
Confirmed, this works. Thanks! |
@nate-double-u is there action I should take on this? This sounds like a layout issue? |
…-finaliers-and-owner-references
I think that if folks are copying and pasting snippets from the article, then @sftim's layout works better (though it may be less readable as several bits of info are put onto the same line). I think I'd err on the side of things working for the most readers when copied from the article, so I'd suggest updating the layout. That said, this may be an issue with my setup (using zsh instead of bash), so I'd defer the decision to you and others who might have an opinion (does it work as is for other users?) |
@nate-double-u agreed - I think a least-common-denominator approach is best, which is represented by keeping everything on one line. The JSON is not so large that it makes the example confusing. |
@sftim @nate-double-u changes are in ... all set. |
new date deploy preview: Using Finalizers to Control Deletion |
content/en/blog/_posts/2021-04-30-using-finalizers-to-control-deletion.md
Outdated
Show resolved
Hide resolved
content/en/blog/_posts/2021-04-30-using-finalizers-to-control-deletion.md
Outdated
Show resolved
Hide resolved
…-finaliers-and-owner-references
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm still not sure how to get k8s into a state described in the Forcing a Deletion of a Namespace section, but when I create a new test namespace (kubectl create namespace test
) first, the snippet doesn't throw the BadRequest
error.
Thanks for this @aaron-kasten, it's an interesting article!
LGTM
@sftim is this ready? |
I've set a publication date for Friday |
Echoing https://kubernetes.slack.com/archives/CJDHVD54J/p1619639542085000?thread_ts=1619639438.084800&cid=CJDHVD54J My own approval |
LGTM label has been added. Git tree hash: d4fcbe65e10c806becb957553bcf3ef270fb73a6
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rolfedh, sftim The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Add block post describing operation of finalizers and owner references via
kubectl delete
This blog post contains the content of a presentation given at KubeCon, in blog form.
Submission to
kubenetes.io
recommended by CNCF.