Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update doc for BoundServiceAccountTokenVolume ga #28570

Merged
merged 1 commit into from
Jun 24, 2021
Merged

update doc for BoundServiceAccountTokenVolume ga #28570

merged 1 commit into from
Jun 24, 2021

Conversation

zshihang
Copy link
Contributor

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 22, 2021
@zshihang
Copy link
Contributor Author

/cc @liggitt

@k8s-ci-robot k8s-ci-robot added language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Jun 22, 2021
@netlify
Copy link

netlify bot commented Jun 22, 2021 •
edited
Loading

✔️ Deploy Preview for kubernetes-io-main-staging ready!

🔨 Explore the source changes: 3a9b198

🔍 Inspect the deploy log: https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/60d365c75c8b160007b6a170

😎 Browse the preview: https://deploy-preview-28570--kubernetes-io-main-staging.netlify.app

liggitt
liggitt reviewed Jun 22, 2021
View reviewed changes
Copy link
Member

@liggitt liggitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pretty sure this should be against the 1.22 branch

content/en/docs/reference/command-line-tools-reference/kubelet.md Outdated
@@ -44,14 +44,14 @@ kubelet [flags]
<tr>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes in this file look spurious

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done. didn't know it is auto generated.

@liggitt
Copy link
Member

liggitt commented Jun 22, 2021

changes lgtm other than the spurious generated kubelet file

@zshihang zshihang changed the base branch from main to dev-1.22 June 22, 2021 23:02
@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 22, 2021
@netlify
Copy link

netlify bot commented Jun 22, 2021 •
edited
Loading

👷 Deploy Preview for kubernetes-io-vnext-staging processing.

🔨 Explore the source changes: 3a9b198

🔍 Inspect the deploy log: https://app.netlify.com/sites/kubernetes-io-vnext-staging/deploys/60d365c78c37040008ee286b

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jun 22, 2021
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 22, 2021
tengqm
tengqm reviewed Jun 23, 2021
View reviewed changes
content/en/docs/reference/command-line-tools-reference/feature-gates.md Outdated
Comment on lines 62 to 63
| `BoundServiceAccountTokenVolume` | `false` | Alpha | 1.13 | 1.20 |
| `BoundServiceAccountTokenVolume` | `true` | Beta | 1.21 | |
| `BoundServiceAccountTokenVolume` | `true` | Beta | 1.21 | 1.22 |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When the feature has graduated or deprecated, please MOVE it rather than COPY it to the second table.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@zshihang zshihang force-pushed the main branch 3 times, most recently from 183631a to bee70ac Compare June 23, 2021 16:38
@tengqm
Copy link
Contributor

tengqm commented Jun 24, 2021

/assign @PI-Victor
/lgtm

@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 7065f14b0bf4dd795eac5428bee96f77ea3bc1c1

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 24, 2021
@PI-Victor
Copy link
Member

thanks!

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: PI-Victor

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 24, 2021
@PI-Victor
Copy link
Member

/milestone 1.22

@k8s-ci-robot k8s-ci-robot added this to the 1.22 milestone Jun 24, 2021
@k8s-ci-robot k8s-ci-robot merged commit 369169d into kubernetes:dev-1.22 Jun 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reylejano reylejano reylejano left review comments

@tengqm tengqm tengqm left review comments

@liggitt liggitt liggitt left review comments

@daminisatya daminisatya Awaiting requested review from daminisatya

@davidopp davidopp Awaiting requested review from davidopp

Assignees

@tengqm tengqm

@PI-Victor PI-Victor

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
1.22
Development

Successfully merging this pull request may close these issues.
6 participants
@zshihang @liggitt @tengqm @k8s-ci-robot @PI-Victor @reylejano