Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken link in k8s.io/docs/concepts/overview/working-with-objects/finalizers/ #30159

Merged
merged 3 commits into from
Oct 20, 2021

Conversation

sandipanpanda
Copy link
Member

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 20, 2021
@k8s-ci-robot k8s-ci-robot added language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Oct 20, 2021
@netlify
Copy link

netlify bot commented Oct 20, 2021

✔️ Deploy Preview for kubernetes-io-main-staging ready!

🔨 Explore the source changes: 55189bc

🔍 Inspect the deploy log: https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/61700860bc24c30008037a8f

😎 Browse the preview: https://deploy-preview-30159--kubernetes-io-main-staging.netlify.app

Copy link
Member

@anubha-v-ardhan anubha-v-ardhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mkorbi
Copy link
Contributor

mkorbi commented Oct 20, 2021

/lgtm
thank you for fixing it

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 20, 2021
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 7fba04f95fdc6955aaad2c57517660bf6f0e223d

@kbhawkey
Copy link
Contributor

/kind cleanup

@k8s-ci-robot k8s-ci-robot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Oct 20, 2021
@kbhawkey
Copy link
Contributor

/label tide/merge-method-squash

@k8s-ci-robot k8s-ci-robot added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Oct 20, 2021
@kbhawkey
Copy link
Contributor

Thanks @sandipanpanda .
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kbhawkey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 20, 2021
@k8s-ci-robot k8s-ci-robot merged commit d336055 into kubernetes:main Oct 20, 2021
PranshuSrivastava added a commit to PranshuSrivastava/website that referenced this pull request Oct 22, 2021
author PranshuSrivastava <iampranshu24@gmail.com> 1634765029 +0530
committer PranshuSrivastava <iampranshu24@gmail.com> 1634924787 +0530

updated  the container-runtime page to include info about dockershim deprecation

Example with data dir for restore

Update guestbook.md

[zh] Fix release cadence in deprecation policy page

Removed Nuage marketing

This entry is not necessary for Kubernetes to function.  Entry provides a link to the main corporate website, not to any relevant information.  No CNI.  Acronym refers to product marketing, not an actual technology.

[es] add volume and volumeMount for ephemeral storage

[zh] pdate controlling-access.md as --insecure-port flag deprecated

Removed Contiv.io

Project did not have direct integration with k8s.

URL to project info goes to malicious browser plugin install and ad-based squatter on contiv.io.

Added open contiv repo

Adding back repo and removing broken link

[zh] Update translate-compose-kubernetes.md

Update authentication.md

[de] Remove exec permission on markdown files

fix(homepage): kubecon dates

de-fix-kubecon-dates-20211020

Update content/de/_index.html

made requested changes

fixed hyperlinks

Fix broken link in k8s.io/docs/concepts/overview/working-with-objects/finalizers/ (kubernetes#30159)

* Fix broken link in finalizers.md

* Update finalizers.md

* Update finalizers.md

Concept files to sync for 1.22 - task13 - k8s Extension

Clean up pre-Docsy content and styles

These files being removed were already deprecated and are
not in fact used. Tidy them up.

Fix typo at network-policies.md

Update adding-windows-nodes.md

Added css to improve user experience with docs

Style diagrams based on intended size

Mark figures' intended size

This commit activates Sass styling to make image sizes more responsive
on the rendered page.

kubeadm: add more details about air-gapped and custom images

- Include more details about custom image repositories, such
as making sure that paths in custom repositories comply with
kubeadm execution.
- Move the section "without internet connection" above
the section about custom images.
- Link the "create-cluster-kubeadm.md" guide these new section
as a pre-req step for nodes.

added trailing whitespaces

made requested changes

made requested changes

Fix typo at network-policies.md

Update adding-windows-nodes.md

Added css to improve user experience with docs

Style diagrams based on intended size

Mark figures' intended size

This commit activates Sass styling to make image sizes more responsive
on the rendered page.

kubeadm: add more details about air-gapped and custom images

- Include more details about custom image repositories, such
as making sure that paths in custom repositories comply with
kubeadm execution.
- Move the section "without internet connection" above
the section about custom images.
- Link the "create-cluster-kubeadm.md" guide these new section
as a pre-req step for nodes.

added trailing whitespaces

[ru] Remove exec permission on markdown files
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Invalid link in k8s.io/docs/concepts/overview/working-with-objects/finalizers/
5 participants