-
Notifications
You must be signed in to change notification settings - Fork 14.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix broken link in k8s.io/docs/concepts/overview/working-with-objects/finalizers/ #30159
Conversation
✔️ Deploy Preview for kubernetes-io-main-staging ready! 🔨 Explore the source changes: 55189bc 🔍 Inspect the deploy log: https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/61700860bc24c30008037a8f 😎 Browse the preview: https://deploy-preview-30159--kubernetes-io-main-staging.netlify.app |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/lgtm |
LGTM label has been added. Git tree hash: 7fba04f95fdc6955aaad2c57517660bf6f0e223d
|
/kind cleanup |
/label tide/merge-method-squash |
Thanks @sandipanpanda . |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kbhawkey The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
author PranshuSrivastava <iampranshu24@gmail.com> 1634765029 +0530 committer PranshuSrivastava <iampranshu24@gmail.com> 1634924787 +0530 updated the container-runtime page to include info about dockershim deprecation Example with data dir for restore Update guestbook.md [zh] Fix release cadence in deprecation policy page Removed Nuage marketing This entry is not necessary for Kubernetes to function. Entry provides a link to the main corporate website, not to any relevant information. No CNI. Acronym refers to product marketing, not an actual technology. [es] add volume and volumeMount for ephemeral storage [zh] pdate controlling-access.md as --insecure-port flag deprecated Removed Contiv.io Project did not have direct integration with k8s. URL to project info goes to malicious browser plugin install and ad-based squatter on contiv.io. Added open contiv repo Adding back repo and removing broken link [zh] Update translate-compose-kubernetes.md Update authentication.md [de] Remove exec permission on markdown files fix(homepage): kubecon dates de-fix-kubecon-dates-20211020 Update content/de/_index.html made requested changes fixed hyperlinks Fix broken link in k8s.io/docs/concepts/overview/working-with-objects/finalizers/ (kubernetes#30159) * Fix broken link in finalizers.md * Update finalizers.md * Update finalizers.md Concept files to sync for 1.22 - task13 - k8s Extension Clean up pre-Docsy content and styles These files being removed were already deprecated and are not in fact used. Tidy them up. Fix typo at network-policies.md Update adding-windows-nodes.md Added css to improve user experience with docs Style diagrams based on intended size Mark figures' intended size This commit activates Sass styling to make image sizes more responsive on the rendered page. kubeadm: add more details about air-gapped and custom images - Include more details about custom image repositories, such as making sure that paths in custom repositories comply with kubeadm execution. - Move the section "without internet connection" above the section about custom images. - Link the "create-cluster-kubeadm.md" guide these new section as a pre-req step for nodes. added trailing whitespaces made requested changes made requested changes Fix typo at network-policies.md Update adding-windows-nodes.md Added css to improve user experience with docs Style diagrams based on intended size Mark figures' intended size This commit activates Sass styling to make image sizes more responsive on the rendered page. kubeadm: add more details about air-gapped and custom images - Include more details about custom image repositories, such as making sure that paths in custom repositories comply with kubeadm execution. - Move the section "without internet connection" above the section about custom images. - Link the "create-cluster-kubeadm.md" guide these new section as a pre-req step for nodes. added trailing whitespaces [ru] Remove exec permission on markdown files
This PR fixes a broken link in https://kubernetes.io/docs/concepts/overview/working-with-objects/finalizers/.
Fixes #30139