Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create an entry that describes the Kui tool within docs #30598

Merged
merged 2 commits into from
Nov 24, 2021
Merged

Create an entry that describes the Kui tool within docs #30598

merged 2 commits into from
Nov 24, 2021

Conversation

Babapool
Copy link
Member

@Babapool Babapool commented Nov 22, 2021 •
edited
Loading

Fixes #30584

It adds a new entry mentioning the Kui tool and its uses in the Other Tools section of the docs.
Files changed: https://kubernetes.io/docs/reference/tools/

Signed
Vitthal Kaul : vitthalsai2001@gmail.com

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Nov 22, 2021 •
edited
Loading

CLA Signed

The committers are authorized under a signed CLA.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 22, 2021
@k8s-ci-robot k8s-ci-robot added language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Nov 22, 2021
@netlify
Copy link

netlify bot commented Nov 22, 2021 •
edited
Loading

✔️ Deploy Preview for kubernetes-io-main-staging ready!

🔨 Explore the source changes: fddb617

🔍 Inspect the deploy log: https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/619e1ce85e381a0007fb91c3

😎 Browse the preview: https://deploy-preview-30598--kubernetes-io-main-staging.netlify.app

@Babapool
Copy link
Member Author

/check-cla

@Babapool
Copy link
Member Author

/retitle Create an entry that describes the Kui tool on content/en/docs/reference/tools/_index.md

@k8s-ci-robot
Copy link
Contributor

@Babapool: Re-titling can only be requested by trusted users, like repository collaborators.

In response to this:

/retitle Create an entry that describes the Kui tool on content/en/docs/reference/tools/_index.md

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

sftim
sftim reviewed Nov 23, 2021
View reviewed changes
Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

/lgtm

I've added some suggestions for how I'd phrase this.

content/en/docs/reference/tools/_index.md Outdated Show resolved Hide resolved
content/en/docs/reference/tools/_index.md Outdated Show resolved Hide resolved
content/en/docs/reference/tools/_index.md Outdated Show resolved Hide resolved
content/en/docs/reference/tools/_index.md Outdated Show resolved Hide resolved
content/en/docs/reference/tools/_index.md Outdated Show resolved Hide resolved
content/en/docs/reference/tools/_index.md Outdated Show resolved Hide resolved
content/en/docs/reference/tools/_index.md Outdated Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 23, 2021
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 306dc16aa571f9f9211f78c6220bd83b7c538aef

@Babapool
Copy link
Member Author

Thanks @sftim for your feedback. I will incorporate the changes and squash & merge the number of commits to 1.

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 24, 2021
sftim
sftim reviewed Nov 24, 2021
View reviewed changes
Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

Thanks

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 24, 2021
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: b8f37110f6cb7419cd55186fd236df7e0a569bec

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sftim

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 24, 2021
@k8s-ci-robot k8s-ci-robot merged commit f20afa3 into kubernetes:main Nov 24, 2021
@sftim sftim mentioned this pull request Nov 24, 2021
Closed
@Babapool Babapool mentioned this pull request Apr 20, 2022
Closed
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sftim sftim sftim left review comments

@jimangel jimangel Awaiting requested review from jimangel

Assignees

@sftim sftim

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Mention k-sigs/kui within docs
3 participants
@Babapool @k8s-ci-robot @sftim