-
Notifications
You must be signed in to change notification settings - Fork 14.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mark OpenStack Cinder CSI migration as GA for 1.24 #31969
Conversation
👷 Deploy Preview for kubernetes-io-vnext-staging processing. 🔨 Explore the source changes: 911c8bf 🔍 Inspect the deploy log: https://app.netlify.com/sites/kubernetes-io-vnext-staging/deploys/621cf05df1492f00079f3299 |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
e713606
to
2efa0ff
Compare
Signed-off-by: Davanum Srinivas <davanum@gmail.com>
2efa0ff
to
911c8bf
Compare
/assign @xing-yang |
| `CSIMigrationOpenStack` | `false` | Alpha | 1.14 | 1.17 | | ||
| `CSIMigrationOpenStack` | `true` | Beta | 1.18 | | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These two lines should be migrated into the second table rather than simply dropped from the first table. I.e. please move CSIMigrationOpenStack
to somewhere around line 264 and mark it as GA.
/retitle Mark OpenStack Cinder CSI migration as GA for 1.24 |
You can disable Cinder CSI migration for your cluster by setting the `CSIMigrationOpenStack` | ||
[feature gate](/docs/reference/command-line-tools-reference/feature-gates/) to `false`. | ||
If you disable the `CSIMigrationOpenStack` feature, the in-tree Cinder volume plugin takes responsibility | ||
for all aspects of Cinder volume storage management. | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd expect to see something like this as well:
#### OpenStack CSI migration complete
{{< feature-state for_k8s_version="v1.24" state="FIXME" >}}
To disable the `cinder` storage plugin from being loaded by the controller manager
and the kubelet, set the `InTreePluginFIXMEUnregister` flag to `true`.
similar to other storage mechanisms that support using CSI rather than in-tree drivers.
Is that the case for Cinder? If it's not, do we need to add some text to document why / what readers should do instead?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can see that there is an existing InTreePluginOpenStackUnregister
feature gate.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1. This section is missing for Cinder CSI migration.
Feature state for InTreePluginOpenStackUnregister is Alpha.
@dims friendly ping. |
@tengqm distracted by a few other things. Do you mind taking this over? (copy this commit to your own PR and make the necessary changes!) thanks, |
Will do. |
/close |
@tengqm: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Following up to kubernetes/kubernetes#107462 and kubernetes/enhancements#3126
Signed-off-by: Davanum Srinivas davanum@gmail.com