Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the links to Gateway API #32067

Merged
merged 2 commits into from
Mar 9, 2022
Merged

Update the links to Gateway API #32067

merged 2 commits into from
Mar 9, 2022

Conversation

omBratteng
Copy link
Contributor

@omBratteng omBratteng commented Mar 5, 2022 •
edited
Loading

Updated the links pointing to the Gateway API site. The site structure was changed in this PR (kubernetes-sigs/gateway-api#782), making this blog post link outdated.
Links referencing API spec has been pointed to v1alpha1 which was current at the time of the blog post.

@omBratteng
Update the link to Gateway controller implementations
23bf4ce 
Changed the link for `Gateway controller implementations`
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Mar 5, 2022 •
edited
Loading

CLA Signed

The committers are authorized under a signed CLA.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Mar 5, 2022
@k8s-ci-robot
Copy link
Contributor

Welcome @omBratteng!

It looks like this is your first PR to kubernetes/website 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/website has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 5, 2022
@k8s-ci-robot k8s-ci-robot added area/blog Issues or PRs related to the Kubernetes Blog subproject language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 5, 2022
@omBratteng omBratteng changed the title Update the link to Gateway controller implementations Update the links to Gateway API Mar 5, 2022
@omBratteng
Updated more of the outdated links
2bfad1b 
Links referencing API spec has been pointed to v1alpha1 which was current at the time of the blog post.
@netlify
Copy link

netlify bot commented Mar 5, 2022

✔️ Deploy Preview for kubernetes-io-main-staging ready!

🔨 Explore the source changes: 23bf4ce

🔍 Inspect the deploy log: https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/622372b2d2260600078e52c3

😎 Browse the preview: https://deploy-preview-32067--kubernetes-io-main-staging.netlify.app

@netlify
Copy link

netlify bot commented Mar 5, 2022

✔️ Deploy Preview for kubernetes-io-main-staging ready!

🔨 Explore the source changes: 2bfad1b

🔍 Inspect the deploy log: https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/6223760dbf71a000088617e3

😎 Browse the preview: https://deploy-preview-32067--kubernetes-io-main-staging.netlify.app

@sftim
Copy link
Contributor

sftim commented Mar 9, 2022

/kind cleanup

@k8s-ci-robot k8s-ci-robot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Mar 9, 2022
sftim
sftim approved these changes Mar 9, 2022
View reviewed changes
Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes are reasonable to make without adding an “article revised” notice.

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sftim

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 5bd4a436fe00cd296ef53e1d87892c9f8c1e91ba

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 9, 2022
@sftim
Copy link
Contributor

sftim commented Mar 9, 2022

Thanks @omBratteng

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 9, 2022
@k8s-ci-robot k8s-ci-robot merged commit b2a3b33 into kubernetes:main Mar 9, 2022
@omBratteng omBratteng deleted the patch-1 branch March 9, 2022 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sftim sftim sftim approved these changes

@nate-double-u nate-double-u Awaiting requested review from nate-double-u

@onlydole onlydole Awaiting requested review from onlydole

Assignees

@sftim sftim

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/blog Issues or PRs related to the Kubernetes Blog subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@omBratteng @k8s-ci-robot @sftim