Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add documentation for PR Wrangler Shadow program #32098

Merged
merged 1 commit into from
Apr 12, 2022
Merged

Add documentation for PR Wrangler Shadow program #32098

merged 1 commit into from
Apr 12, 2022

Conversation

Babapool
Copy link
Member

@Babapool Babapool commented Mar 7, 2022 •
edited
Loading

Fixes #31956

This PR updates the PR Wranglers page to include:

  • Documentation regarding the PR Shadow wrangler shadow program.
  • Steps to become a shadow wrangler.
  • Leanings the shadows will again after the completion of the wrangling week.

Pages Updated: https://github.com/kubernetes/website/blob/main/content/en/docs/contribute/participate/pr-wranglers.md

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. language/en Issues or PRs related to English language labels Mar 7, 2022
@k8s-ci-robot k8s-ci-robot added the sig/docs Categorizes an issue or PR as relevant to SIG Docs. label Mar 7, 2022
@netlify
Copy link

netlify bot commented Mar 7, 2022 •
edited
Loading

✅ Deploy Preview for kubernetes-io-main-staging ready!

Name Link
🔨 Latest commit 4a05cab
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/624c8d7d8f54270009f17ad8
😎 Deploy Preview https://deploy-preview-32098--kubernetes-io-main-staging.netlify.app/docs/contribute/participate/pr-wranglers
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@Babapool Babapool requested a review from reylejano March 10, 2022 18:20
@Babapool
Copy link
Member Author

@reylejano I have updated the PR with the new changes. PTAL. Thanks

@Babapool
Copy link
Member Author

Hi @reylejano @RinkiyaKeDad can you PTAL at this PR. Thanks.

@reylejano
Copy link
Member

/lgtm

@reylejano
Copy link
Member

/assign @natalisucks @divya-mohan0209

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 29, 2022
divya-mohan0209
divya-mohan0209 previously requested changes Mar 29, 2022
View reviewed changes
Copy link
Contributor

@divya-mohan0209 divya-mohan0209 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nits and a few corrections.

content/en/docs/contribute/participate/pr-wranglers.md Outdated Show resolved Hide resolved
content/en/docs/contribute/participate/pr-wranglers.md Outdated Show resolved Hide resolved
content/en/docs/contribute/participate/pr-wranglers.md Outdated Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 29, 2022
@reylejano
Copy link
Member

Reapply lgtm
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 29, 2022
@sftim sftim dismissed divya-mohan0209’s stale review April 5, 2022 17:45

Feedback seems to have been incorporated

sftim
sftim previously requested changes Apr 5, 2022
View reviewed changes
Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One thing to fix, and one capitalization nit

content/en/docs/contribute/participate/pr-wranglers.md Outdated Show resolved Hide resolved
content/en/docs/contribute/participate/pr-wranglers.md Outdated Show resolved Hide resolved
@sftim
Copy link
Contributor

sftim commented Apr 5, 2022

/lgtm cancel

We should fix the heading

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 5, 2022
@Babapool Babapool requested a review from sftim April 5, 2022 18:45
@reylejano
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 12, 2022
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 2eb3e737250b1bb60efab47ef40988ed889d608d

@sftim sftim dismissed their stale review April 12, 2022 17:24

Review was stale

@sftim
Copy link
Contributor

sftim commented Apr 12, 2022

/approve

Thank you

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sftim

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 12, 2022
@k8s-ci-robot k8s-ci-robot merged commit b69b3d7 into kubernetes:main Apr 12, 2022
@Babapool Babapool mentioned this pull request Apr 20, 2022
Closed
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jimangel jimangel Awaiting requested review from jimangel

@onlydole onlydole Awaiting requested review from onlydole

@reylejano reylejano Awaiting requested review from reylejano

@RinkiyaKeDad RinkiyaKeDad Awaiting requested review from RinkiyaKeDad

@divya-mohan0209 divya-mohan0209 Awaiting requested review from divya-mohan0209

@natalisucks natalisucks Awaiting requested review from natalisucks

@sftim sftim Awaiting requested review from sftim

Assignees

@natalisucks natalisucks

@divya-mohan0209 divya-mohan0209

@sftim sftim

@reylejano reylejano

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Document the PR Wrangler Shadow Program for SIG Docs
7 participants
@Babapool @reylejano @sftim @k8s-ci-robot @divya-mohan0209 @RinkiyaKeDad @natalisucks