Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve coredns page #32126

Merged
merged 1 commit into from
Mar 9, 2022
Merged

Improve coredns page #32126

merged 1 commit into from
Mar 9, 2022

Conversation

tengqm
Copy link
Contributor

@tengqm tengqm commented Mar 8, 2022

This PR refactors the coredns page by removing some outdated statements.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 8, 2022
@k8s-ci-robot k8s-ci-robot added the language/en Issues or PRs related to English language label Mar 8, 2022
@k8s-ci-robot k8s-ci-robot added the sig/docs Categorizes an issue or PR as relevant to SIG Docs. label Mar 8, 2022
@netlify
Copy link

netlify bot commented Mar 8, 2022 •
edited
Loading

✔️ Deploy Preview for kubernetes-io-main-staging ready!

🔨 Explore the source changes: 15f643e

🔍 Inspect the deploy log: https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/6228ac28b147dc0008f35f07

😎 Browse the preview: https://deploy-preview-32126--kubernetes-io-main-staging.netlify.app

sftim
sftim reviewed Mar 8, 2022
View reviewed changes
Copy link
Contributor

@sftim sftim left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @tengqm (remaining feedback is suggestions and nits).

In the page introduction, or thereabouts, it would be good to point out that for compatibility reasons, it's conventional to deploy CoreDNS as a Deployment Service named kube-dns in the kube-system namespace.

That detail often confuses people who upgrade.

/approve

content/en/docs/tasks/administer-cluster/coredns.md Show resolved Hide resolved
content/en/docs/tasks/administer-cluster/coredns.md Outdated Show resolved Hide resolved
content/en/docs/tasks/administer-cluster/coredns.md Outdated Show resolved Hide resolved
content/en/docs/tasks/administer-cluster/coredns.md Outdated Show resolved Hide resolved
content/en/docs/tasks/administer-cluster/coredns.md Outdated Show resolved Hide resolved
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sftim

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 8, 2022
@tengqm
Improve coredns page
15f643e 
This PR refactors the coredns page by removing some outdated statements.
@reylejano
Copy link
Member

Thank you @tengqm
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 9, 2022
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: f8387a5dcfa627132a096abeb24c88503649b8e2

@k8s-ci-robot k8s-ci-robot merged commit 782d8bc into kubernetes:main Mar 9, 2022
@tengqm tengqm deleted the update-coredns branch April 13, 2022 06:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sftim sftim sftim left review comments

@reylejano reylejano reylejano left review comments

@johnbelamaric johnbelamaric Awaiting requested review from johnbelamaric

@mehabhalodiya mehabhalodiya Awaiting requested review from mehabhalodiya

Assignees

@reylejano reylejano

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@tengqm @k8s-ci-robot @reylejano @johnbelamaric @sftim