Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ServiceIPStaticSubrange alpha feature in 1.24 #32344

Closed
wants to merge 1 commit into from
Closed

ServiceIPStaticSubrange alpha feature in 1.24 #32344

wants to merge 1 commit into from

Conversation

aojea
Copy link
Member

@aojea aojea commented Mar 18, 2022

/sig network
KEP kubernetes/enhancements#3070

@k8s-ci-robot k8s-ci-robot added sig/network Categorizes an issue or PR as relevant to SIG Network. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 18, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign annajung after the PR has been reviewed.
You can assign the PR to them by writing /assign @annajung in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Mar 18, 2022
@aojea
Copy link
Member Author

aojea commented Mar 18, 2022

/assign @nate-double-u @thockin

@netlify
Copy link

netlify bot commented Mar 18, 2022

✔️ Deploy Preview for kubernetes-io-main-staging ready!

🔨 Explore the source changes: 2726b74

🔍 Inspect the deploy log: https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/62343e688b2a1c0008842690

😎 Browse the preview: https://deploy-preview-32344--kubernetes-io-main-staging.netlify.app

tengqm
tengqm reviewed Mar 18, 2022
View reviewed changes
content/en/docs/reference/command-line-tools-reference/feature-gates.md
@@ -201,6 +201,7 @@ different Kubernetes components.
| `ServiceLBNodePortControl` | `true` | Beta | 1.22 | |
| `ServiceLoadBalancerClass` | `false` | Alpha | 1.21 | 1.21 |
| `ServiceLoadBalancerClass` | `true` | Beta | 1.22 | |
| `ServiceIPStaticSubrange` | `false` | Alpha | 1.24 | |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line should go before line 198.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

haha, yeah

content/en/docs/reference/command-line-tools-reference/feature-gates.md
@@ -1032,6 +1033,9 @@ Each feature gate is designed for enabling/disabling a specific feature:
topology of the cluster. See
[ServiceTopology](/docs/concepts/services-networking/service-topology/)
for more details.
- `ServiceIPStaticSubrange`: Enable a new strategy for Services ClusterIP allocations, so users can subdivide the ClusterIP range. Dynamic allocated ClusterIP addresses will be allocated preferently from the upper range allowing users to assign static ClusterIPs from the lower range with a low risk of collision. See
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please wrap the long line as we did for other entries.

Suggested change
- `ServiceIPStaticSubrange`: Enable a new strategy for Services ClusterIP allocations, so users can subdivide the ClusterIP range. Dynamic allocated ClusterIP addresses will be allocated preferently from the upper range allowing users to assign static ClusterIPs from the lower range with a low risk of collision. See
- `ServiceIPStaticSubrange`: Enable a new strategy for Services ClusterIP allocations,
so users can subdivide the ClusterIP range. Dynamic allocated ClusterIP addresses
will be allocated preferently from the upper range allowing users to assign static ClusterIPs
from the lower range with a low risk of collision. See

@tengqm
Copy link
Contributor

tengqm commented Mar 18, 2022

This should target at the dev-1.24 branch rather than main.
/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 18, 2022
@aojea
Copy link
Member Author

aojea commented Mar 18, 2022

This should target at the dev-1.24 branch rather than main. /hold

let me reopen a new one on that branch

Thanks

@aojea aojea closed this Mar 18, 2022
@nate-double-u
Copy link
Contributor

nate-double-u commented Mar 19, 2022 •
edited
Loading

You can change the target branch without opening a new PR, you can use the GitHub web UI to change it. (That way you don't lose the history of the PR)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tengqm tengqm tengqm left review comments

@onlydole onlydole Awaiting requested review from onlydole

@rajeshdeshpande02 rajeshdeshpande02 Awaiting requested review from rajeshdeshpande02

Assignees

@nate-double-u nate-double-u

@thockin thockin

Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. sig/network Categorizes an issue or PR as relevant to SIG Network. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@aojea @k8s-ci-robot @tengqm @nate-double-u @thockin