Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

storage capacity GA blog post #32659

Merged
merged 1 commit into from
Apr 28, 2022
Merged

storage capacity GA blog post #32659

merged 1 commit into from
Apr 28, 2022

Conversation

pohly
Copy link
Contributor

@pohly pohly commented Mar 30, 2022

kubernetes/enhancements#1472: storage capacity tracking GA

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 30, 2022
@k8s-ci-robot k8s-ci-robot added the area/blog Issues or PRs related to the Kubernetes Blog subproject label Mar 30, 2022
@k8s-ci-robot k8s-ci-robot requested a review from sftim March 30, 2022 17:15
@k8s-ci-robot k8s-ci-robot added language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Mar 30, 2022
@netlify
Copy link

netlify bot commented Mar 30, 2022 •
edited
Loading

✅ Deploy Preview for kubernetes-io-main-staging ready!

Name Link
🔨 Latest commit 0e56bf9
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/626a9c928ab32c00089c02fc
😎 Deploy Preview https://deploy-preview-32659--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@pohly pohly force-pushed the kubernetes-1.24-storage-capacity-ga branch from 533b14e to 94bf646 Compare April 7, 2022 14:50
@pohly pohly changed the title WIP: storage capacity GA blog post storage capacity GA blog post Apr 7, 2022
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 7, 2022
@sftim
Copy link
Contributor

sftim commented Apr 7, 2022

We'll need to assign a publication date and fix the path before this can merge. (something for the release comms team)

sftim
sftim reviewed Apr 8, 2022
View reviewed changes
Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One extra suggestion

content/en/blog/_posts/2022-TBD-storage-capacity-GA/index.md Outdated Show resolved Hide resolved
@pohly pohly force-pushed the kubernetes-1.24-storage-capacity-ga branch from 0d6f76e to 5b347cf Compare April 8, 2022 15:08
xing-yang
xing-yang reviewed Apr 13, 2022
View reviewed changes
content/en/blog/_posts/2022-TBD-storage-capacity-GA/index.md Outdated
cluster can be consumed by Pods with storage capacity tracking whereas Pods got
stuck without it.

## Problems we are *not* solving
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Problems we have not solved

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's indeed better because it doesn't rule out that we'll solve them in the future.

But then we also need to say "Problems we have solved", for consistency and to avoid the impression that we are still working on those, right?

I changed both.

content/en/blog/_posts/2022-TBD-storage-capacity-GA/index.md Outdated Show resolved Hide resolved
content/en/blog/_posts/2022-TBD-storage-capacity-GA/index.md Outdated Show resolved Hide resolved
content/en/blog/_posts/2022-TBD-storage-capacity-GA/index.md Outdated Show resolved Hide resolved
sftim
sftim reviewed Apr 13, 2022
View reviewed changes
Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks
A small nit

content/en/blog/_posts/2022-TBD-storage-capacity-GA/index.md Outdated Show resolved Hide resolved
@mickeyboxell
Copy link
Contributor

@pohly could we plan to have this ship on 6-MAY-2022?

@pohly
Copy link
Contributor Author

pohly commented Apr 28, 2022

I've changed to date: 2022-05-06 and force-pushed with all commits squashed and the path updated.

@pohly pohly force-pushed the kubernetes-1.24-storage-capacity-ga branch from ba9af02 to 239972f Compare April 28, 2022 09:53
sftim
sftim reviewed Apr 28, 2022
View reviewed changes
Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

content/en/blog/_posts/2022-05-06-storage-capacity-GA/index.md Outdated Show resolved Hide resolved
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sftim

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 28, 2022
@sftim
Copy link
Contributor

sftim commented Apr 28, 2022

This would need tech LGTM from sig storage, I think.

@pohly pohly force-pushed the kubernetes-1.24-storage-capacity-ga branch from 25be70d to 0e56bf9 Compare April 28, 2022 13:54
@pohly
Copy link
Contributor Author

pohly commented Apr 28, 2022

@xing-yang : does this look good to you?

@pohly
Copy link
Contributor Author

pohly commented Apr 28, 2022

/assign @xing-yang

@xing-yang
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 28, 2022
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: b7c7cbd7a6d25a65dbd82d0016a3d4d6230b7a93

@k8s-ci-robot k8s-ci-robot merged commit cc442b1 into kubernetes:main Apr 28, 2022
@sftim sftim mentioned this pull request May 17, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sftim sftim sftim left review comments

@tengqm tengqm tengqm left review comments

@xing-yang xing-yang xing-yang left review comments

@nate-double-u nate-double-u Awaiting requested review from nate-double-u

Assignees

@xing-yang xing-yang

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/blog Issues or PRs related to the Kubernetes Blog subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
SIG Docs Blog Project Board
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@pohly @sftim @mickeyboxell @k8s-ci-robot @xing-yang @tengqm