Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improvement: Updated all the links of the task "Monitoring, Logging, and Debugging" on all pages. #33220

Merged
merged 2 commits into from
May 11, 2022
Merged

Improvement: Updated all the links of the task "Monitoring, Logging, and Debugging" on all pages. #33220

merged 2 commits into from
May 11, 2022

Conversation

Shubham82
Copy link
Contributor

@Shubham82 Shubham82 commented Apr 26, 2022 •
edited
Loading

This PR fixed all the links of the tasks under Monitoring, Logging, and Debugging on all pages. This is due to the changes done in the PR: #32823
Fixes: #33211
Ref: #32823

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. language/en Issues or PRs related to English language labels Apr 26, 2022
@k8s-ci-robot k8s-ci-robot added the sig/docs Categorizes an issue or PR as relevant to SIG Docs. label Apr 26, 2022
@Shubham82 Shubham82 mentioned this pull request Apr 26, 2022
Closed
@Shubham82
Copy link
Contributor Author

Hi @jimangel @lavalamp
Could please take a look!

@netlify
Copy link

netlify bot commented Apr 26, 2022 •
edited
Loading

✅ Deploy Preview for kubernetes-io-main-staging ready!

Name Link
🔨 Latest commit d107670
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/626fa2493677260008568d6f
😎 Deploy Preview https://deploy-preview-33220--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

sftim
sftim reviewed Apr 26, 2022
View reviewed changes
Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should fix all the page moves from #32823 in one PR, and not just cover Auditing. Would you have the capacity to work on that @Shubham82? If not, we should merge this; if you have capacity for wider fixes, I recommend holding off.

As well as updating the Markdown, please also add a redirect for each page that #32823 moved.

For example, /docs/tasks/debug-application-cluster/debug-running-pod/ should redirect to /docs/tasks/debug/debug-applications/debug-running-pod/.

If you'd prefer to contribute a set of fixes over several smaller PRs @Shubham82 then that could work, but you may find that contributors for these PRs have to rebase these PRs or solve merge conflicts.

What approach do you like?

/lgtm
The changes match the PR description.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 26, 2022
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 0daea3d21607aab22884fa2bb12b5fd9b23331b3

@sethmccombs
Copy link
Contributor

@sftim I was working on fixing all of these, I noticed them today. I will sit tight until @Shubham82 reports back. If they only have the bandwidth for these fixes, I'm happy to take the rest of the changes forward

@Shubham82
Copy link
Contributor Author

Shubham82 commented Apr 27, 2022 •
edited
Loading

Hi @sftim Sound good to me, it should be in one PR, so it is easy for the reviewer also. I'm up for it. I will do the changes and push them in this PR.

@Shubham82
Copy link
Contributor Author

@sftim I was working on fixing all of these, I noticed them today. I will sit tight until @Shubham82 reports back. If they only have the bandwidth for these fixes, I'm happy to take the rest of the changes forward

Hi, @sethmccombs As I have already started I, will complete all changes.

@Shubham82
Copy link
Contributor Author

@sftim just one query should I change the links in blogs also?

@sftim
Copy link
Contributor

sftim commented Apr 27, 2022

If you're adding redirects, no need to revise any blog articles.

@Shubham82
Copy link
Contributor Author

If you're adding redirects, no need to revise any blog articles.

Yes, I am adding the redirects and updating the links on all pages except blogs.
Also, I will also change the PR Description.
Thanks

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 27, 2022
@k8s-ci-robot k8s-ci-robot requested a review from sftim April 27, 2022 12:38
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 27, 2022
@Shubham82 Shubham82 changed the title Improvement: Updated the links for Auditing. Improvement: Updated all the links of the task "Monitoring, Logging, and Debugging" in all pages. Apr 27, 2022
@Shubham82 Shubham82 changed the title Improvement: Updated all the links of the task "Monitoring, Logging, and Debugging" in all pages. Improvement: Updated all the links of the task "Monitoring, Logging, and Debugging" on all pages. Apr 27, 2022
@Shubham82
Copy link
Contributor Author

Hi @sftim
PTAL

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 29, 2022
@jihoon-seo jihoon-seo mentioned this pull request May 1, 2022
Closed
@Shubham82 Shubham82 force-pushed the update_link_for_Auditing branch from 16d7677 to d107670 Compare May 2, 2022 09:20
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 2, 2022
@Shubham82
Copy link
Contributor Author

Hi @sftim
I have done rebase and resolved the merge conflicts, Could you please take a look!

@shannonxtreme
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 2, 2022
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 22cf2d4de9244fda68130d0ce0ddcdeb041fe357

@jihoon-seo jihoon-seo mentioned this pull request May 4, 2022
Closed
@Shubham82
Copy link
Contributor Author

Hi @sftim @shannonxtreme
could you please approve this request!

Thanks

@shannonxtreme
Copy link
Contributor

shannonxtreme commented May 10, 2022 via email

@Shubham82
Copy link
Contributor Author

Thanks, @shannonxtreme.
It's ok I will wait.

@tengqm
Copy link
Contributor

tengqm commented May 11, 2022

/kind cleanup
/approve

@k8s-ci-robot k8s-ci-robot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label May 11, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tengqm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 11, 2022
@k8s-ci-robot k8s-ci-robot merged commit 07e1929 into kubernetes:main May 11, 2022
This was referenced Jun 7, 2022
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jimangel jimangel Awaiting requested review from jimangel

@lavalamp lavalamp Awaiting requested review from lavalamp

@sftim sftim Awaiting requested review from sftim

Assignees

@sftim sftim

@shannonxtreme shannonxtreme

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Link for Auditing is not working.
6 participants
@Shubham82 @k8s-ci-robot @sethmccombs @sftim @shannonxtreme @tengqm