Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ko] Reorg pages in dev-1.24-ko.1 #33781

Merged
merged 6 commits into from
Jul 1, 2022
Merged

[ko] Reorg pages in dev-1.24-ko.1 #33781

merged 6 commits into from
Jul 1, 2022

Conversation

jihoon-seo
Copy link
Member

@jihoon-seo jihoon-seo commented May 18, 2022 •
edited
Loading

일부러 여러 커밋으로 나눴으며,
필요 시 추후 squash 하겠습니다. 😊

  • Reorg the Debugging section (영문 PR: Reorg the monitoring task section #32823) (R4-R9 + D2-D6)
  • 위에 따른 관련 링크 업데이트 (R4-R9 + D2-D6)
  • Rename files (R1-R3)
  • 위에 따른 관련 링크 업데이트 (R1-R3 + D1)
  • 그 외 링크 업데이트

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels May 18, 2022
@k8s-ci-robot k8s-ci-robot requested review from ianychoi and jmyung May 18, 2022 00:51
@k8s-ci-robot k8s-ci-robot added language/ko Issues or PRs related to Korean language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels May 18, 2022
@netlify
Copy link

netlify bot commented May 18, 2022 •
edited
Loading

✅ Deploy Preview for k8s-dev-ko ready!

Name Link
🔨 Latest commit 464079a
🔍 Latest deploy log https://app.netlify.com/sites/k8s-dev-ko/deploys/62bedac45e408d0008264001
😎 Deploy Preview https://deploy-preview-33781--k8s-dev-ko.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

This was referenced May 19, 2022
Merged
Merged
This was referenced May 27, 2022
Merged
Merged
This was referenced May 31, 2022
Merged
Merged
Merged
Merged
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 8, 2022
@jihoon-seo jihoon-seo force-pushed the 220516_ko_Reorg_the_Debugging_section branch from 95e43db to 05e7bac Compare June 9, 2022 05:34
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 9, 2022
@jihoon-seo jihoon-seo mentioned this pull request Jun 17, 2022
Closed
@jihoon-seo jihoon-seo force-pushed the 220516_ko_Reorg_the_Debugging_section branch from 05e7bac to e141fa8 Compare July 1, 2022 01:58
@jihoon-seo jihoon-seo changed the title [ko] Reorg the Debugging section in dev-1.24-ko.1 [ko] Reorg pages dev-1.24-ko.1 Jul 1, 2022
@jihoon-seo jihoon-seo changed the title [ko] Reorg pages dev-1.24-ko.1 [ko] Reorg pages in dev-1.24-ko.1 Jul 1, 2022
seokho-son
seokho-son reviewed Jul 1, 2022
View reviewed changes
Copy link
Member

@seokho-son seokho-son left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

사소한 의견이 있습니다 :)

선택적으로 amend 해주시면 될 것 같습니다.

업데이트되지 않더라도 브랜치 스위칭 일정을 고려하여 적절한 시기에 승인하도록 하겠습니다.

content/ko/docs/tasks/debug/debug-application/debug-pods.md Outdated Show resolved Hide resolved
content/ko/docs/tasks/debug/debug-application/debug-pods.md Outdated Show resolved Hide resolved
@jihoon-seo jihoon-seo force-pushed the 220516_ko_Reorg_the_Debugging_section branch from e141fa8 to 464079a Compare July 1, 2022 11:30
@jihoon-seo
Copy link
Member Author

@seokho-son 감사합니다. 모두 반영했습니다. 😊

@seokho-son
Copy link
Member

/lgtm

@seokho-son
Copy link
Member

/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 1, 2022
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: ee32c1860289a4d3fdcf9c0531716b025604eeb6

@jihoon-seo
Copy link
Member Author

@seokho-son Prow가 comment-style command (특히 /approve) 에 반응하지 않는 경우가 가끔씩 있네요.. ㅎㅎ

@seokho-son
Copy link
Member

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: seokho-son

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 1, 2022
@k8s-ci-robot k8s-ci-robot merged commit 32f6b46 into kubernetes:dev-1.24-ko.1 Jul 1, 2022
@jihoon-seo jihoon-seo deleted the 220516_ko_Reorg_the_Debugging_section branch July 1, 2022 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seokho-son seokho-son seokho-son left review comments

@ianychoi ianychoi Awaiting requested review from ianychoi

@jmyung jmyung Awaiting requested review from jmyung

Assignees

@seokho-son seokho-son

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/ko Issues or PRs related to Korean language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jihoon-seo @seokho-son @k8s-ci-robot