Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sample for Ingress TLS #340

Merged
merged 1 commit into from
Apr 12, 2016

Conversation

javiercr
Copy link
Contributor

@javiercr javiercr commented Apr 7, 2016

v1beta1.IngressSpec expects an v1beta1.IngressTLS array.

Without this change executing the code in the example will return this error:

error validating "ingress.yml": error validating data: expected type array, for field spec.tls, got map; if you choose to ignore these errors, turn validation off with --validate=false

v1beta1.IngressSpec expects an v1beta1.IngressTLS array.
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@javiercr
Copy link
Contributor Author

javiercr commented Apr 7, 2016

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

@johndmulhausen
Copy link

Thanks @javiercr !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants