Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KMS v2alpha1 #35046

Merged
merged 1 commit into from
Aug 17, 2022
Merged

KMS v2alpha1 #35046

merged 1 commit into from
Aug 17, 2022

Conversation

ritazh
Copy link
Member

@ritazh ritazh commented Jul 15, 2022 •
edited
Loading

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. sig/auth Categorizes an issue or PR as relevant to SIG Auth. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jul 15, 2022
@netlify
Copy link

netlify bot commented Jul 15, 2022 •
edited
Loading

👷 Deploy Preview for kubernetes-io-vnext-staging processing.

Name Link
🔨 Latest commit f367ff6
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-vnext-staging/deploys/62fc37403f923500085011c1

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. language/en Issues or PRs related to English language labels Jul 15, 2022
@k8s-ci-robot k8s-ci-robot added the sig/docs Categorizes an issue or PR as relevant to SIG Docs. label Jul 15, 2022
@ritazh ritazh changed the title feat: KMS v2alpha1 [WIP] KMS v2alpha1 Jul 15, 2022
@ritazh
Copy link
Member Author

ritazh commented Jul 19, 2022

Hi @sftim, do you have any guidance for how we should structure the docs for KMS v2alpha1? Should we add new sections to the bottom of the existing kms provider doc https://github.com/kubernetes/website/pull/35046/files#diff-01157160365978e29ae4ee6cc3f75f56794f3d2197cb92af5ea304e07ed3cabc or should we start a new page?

@sftim
Copy link
Contributor

sftim commented Jul 19, 2022

I'd use tabs, I think.

@sftim
Copy link
Contributor

sftim commented Jul 19, 2022

The pages to update are:

Aim to write as if the feature is graduated, and then tweak what you have written to add a proviso (or even a warning) that the v2 API is alpha.

@ritazh ritazh mentioned this pull request Aug 1, 2022
Closed
8 tasks
@reylejano
Copy link
Member

/milestone 1.25
/assign @didicodes
/cc @kcmartin

@k8s-ci-robot k8s-ci-robot added this to the 1.25 milestone Aug 4, 2022
@reylejano
Copy link
Member

Hi @ritazh , the 1.25 Docs Ready for Review deadline is eod tomorrow, August 9th.
Please update this PR and have it at a ready-to-review state by eod tomorrow.
Thank you

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 10, 2022
@ritazh ritazh marked this pull request as ready for review August 10, 2022 00:43
@ritazh ritazh changed the title [WIP] KMS v2alpha1 KMS v2alpha1 Aug 10, 2022
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 10, 2022
@ritazh
Copy link
Member Author

ritazh commented Aug 16, 2022

@enj @aramase @didicodes I have addressed all the review comments. PTAL

@ritazh
Copy link
Member Author

ritazh commented Aug 16, 2022

@aramase I have incorporated your suggestions. PTAL

aramase
aramase reviewed Aug 16, 2022
View reviewed changes
Copy link
Member

@aramase aramase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 16, 2022
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: a959f59ff76b989b5238ae93595aa0bdcd44a7b9

@aramase
Copy link
Member

aramase commented Aug 16, 2022

/hold

for other reviews. Feel free to remove when it's ready for merge.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 16, 2022
enj
enj suggested changes Aug 16, 2022
View reviewed changes
Copy link
Member

@enj enj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost :)

@nilekhc re: hot reload in 1.26 - some of these docs will need to change to account for that.

content/en/docs/tasks/administer-cluster/kms-provider.md Outdated Show resolved Hide resolved
content/en/docs/tasks/administer-cluster/kms-provider.md Outdated Show resolved Hide resolved
content/en/docs/tasks/administer-cluster/kms-provider.md Show resolved Hide resolved
content/en/docs/tasks/administer-cluster/kms-provider.md Show resolved Hide resolved
content/en/docs/tasks/administer-cluster/kms-provider.md Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 16, 2022
@ritazh ritazh force-pushed the kms-v2alpha1 branch 2 times, most recently from c5818f8 to 7c92c4e Compare August 16, 2022 23:02
@ritazh
feat: KMS v2alpha1
f367ff6 
Signed-off-by: Rita Zhang <rita.z.zhang@gmail.com>
@enj
Copy link
Member

enj commented Aug 17, 2022

/lgtm
/approve
/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 17, 2022
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 17, 2022
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: ccc90f7f2f4f0820248c0bf20557c7529bf6fc17

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: enj, tengqm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit d9ef1f7 into kubernetes:dev-1.25 Aug 17, 2022
@aramase aramase mentioned this pull request Aug 17, 2022
Closed
@ritazh ritazh deleted the kms-v2alpha1 branch August 17, 2022 01:44
@ritazh ritazh mentioned this pull request Mar 21, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@romdalf romdalf romdalf left review comments

@sftim sftim sftim left review comments

@aramase aramase aramase left review comments

@enj enj enj requested changes

@tengqm tengqm tengqm left review comments

@divya-mohan0209 divya-mohan0209 Awaiting requested review from divya-mohan0209

@smarterclayton smarterclayton Awaiting requested review from smarterclayton

@kcmartin kcmartin Awaiting requested review from kcmartin

@ericchiang ericchiang Awaiting requested review from ericchiang

@didicodes didicodes Awaiting requested review from didicodes

Assignees

@enj enj

@aramase aramase

@didicodes didicodes

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/auth Categorizes an issue or PR as relevant to SIG Auth. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
1.25
Development

Successfully merging this pull request may close these issues.
9 participants
@ritazh @sftim @reylejano @aramase @didicodes @tengqm @k8s-ci-robot @enj @romdalf