Add docs for KubeletTracing feature gate 1.25 #35137

sallyom · 2022-07-18T20:14:25Z

Add KubeletTracing Alpha 1.25

netlify · 2022-07-18T20:15:04Z

👷 Deploy Preview for kubernetes-io-vnext-staging processing.

Name	Link
🔨 Latest commit	`221d4e8`
🔍 Latest deploy log	https://app.netlify.com/sites/kubernetes-io-vnext-staging/deploys/62fbf4849e96c3000834d1ff

sallyom · 2022-07-18T20:21:19Z

Issue
KEP
PR

jihoon-seo · 2022-07-19T03:04:10Z

/remove-area blog release-eng
/remove-language de es fr id ja ko vi zh
/remove-sig release

sftim · 2022-08-11T11:18:08Z

content/en/docs/concepts/cluster-administration/system-traces.md

+{{< feature-state for_k8s_version="v1.22, kube-apiserver" state="alpha" >}}
+{{< feature-state for_k8s_version="v1.25, kubelet" state="alpha" >}}


I'm afraid that this use isn't idiomatic. The version should always be just a version string.

I wasn't sure how to list each separately, I know. I tried a few different ways. Do you have a suggestion? Or, should I only list the latest? or the earliest? There will be other components added here, too (scheduler next, maybe?)

updated, added new feature state shortcode under kubelet traces

content/en/docs/concepts/cluster-administration/system-traces.md

sftim · 2022-08-11T11:19:01Z

content/en/docs/concepts/cluster-administration/system-traces.md

+To enable tracing, enable the `KubeletTracing`
+[feature gate](/docs/reference/command-line-tools-reference/feature-gates/)
+on the kubelet. Also, provide the kubelet with a
+[tracing configuration](https://github.com/kubernetes/component-base/blob/master/tracing/api/v1/types.go).


Watch out for referencing the master branch. Can we reference the v1.25 release branch instead?

sftim · 2022-08-11T11:19:33Z

content/en/docs/reference/command-line-tools-reference/feature-gates.md

+  OpenTelemetry trace spans. Sampling rate and collector address are configurable. When enabled without
+  a tracing configuration, a parent span's sampling decision is respected and the default collector
+  address of 0.0.0.0:4317 is set.


Please move:

Sampling rate and collector address are configurable. When enabled without
a tracing configuration, a parent span's sampling decision is respected and the default collector
address of 0.0.0.0:4317 is set.

into the concept docs.

jihoon-seo · 2022-08-12T00:57:13Z

/remove-area blog release-eng
/remove-sig release

sftim

Docs LGTM. This will need a new tech review - eg from @dashpole.

Some nits.

content/en/docs/concepts/cluster-administration/system-traces.md

content/en/docs/reference/command-line-tools-reference/feature-gates.md

sallyom · 2022-08-13T23:45:41Z

Docs LGTM. This will need a new tech review - eg from @dashpole.

Some nits.

committed all suggestions, ty

sftim · 2022-08-14T17:29:41Z

LGTM (for SIG Docs) including latest updates.

dashpole · 2022-08-15T15:36:45Z

content/en/docs/concepts/cluster-administration/system-traces.md

+
+The kubelet CRI interface and authenticated http servers are instrumented to generate
+trace spans. As with the apiserver, the endpoint and sampling rate are configurable.
+Trace context propagation is also configured. When enabled without a tracing configuration sampling rate,


For the sampling rate, the parent span's sampling decision is always respected first (i.e. always sample if parent is sampled, never sample if parent is not sampled). The configured sampling rate applies to spans without a parent.

updated, it now reads:

A parent span's sampling decision is always respected. A provided tracing configuration sampling rate will apply to spans without a parent. Enabled without a configured endpoint, the default OpenTelemetry Collector reciever address of "localhost:4317" is set.

That works for me!

dashpole · 2022-08-16T00:55:39Z

LGTM for Sig-Instrumentation

reylejano · 2022-08-16T19:22:30Z

@sallyom please rebase

Adding KubeletTracing documentation now that kubernetes/kubernetes#105126 has merged.

sallyom · 2022-08-16T19:49:15Z

rebased! ty for the reviews!

reylejano · 2022-08-16T19:54:56Z

Applying lgtm from SIG Instrumentation in this comment
/lgtm

/approve

k8s-ci-robot · 2022-08-16T19:55:15Z

LGTM label has been added.

Git tree hash: 1fed1357b919329bd54ba9d9e676839b1a63e9ad

k8s-ci-robot · 2022-08-16T19:56:04Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dashpole, reylejano

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~content/en/OWNERS~~ [reylejano]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot requested a review from natalisucks July 18, 2022 20:15

k8s-ci-robot added the language/en Issues or PRs related to English language label Jul 18, 2022

k8s-ci-robot requested a review from sftim July 18, 2022 20:15

k8s-ci-robot added the sig/docs Categorizes an issue or PR as relevant to SIG Docs. label Jul 18, 2022

sallyom force-pushed the kubelet-tracing-1-25 branch from 4f1732f to 5339182 Compare July 18, 2022 20:16

sallyom force-pushed the kubelet-tracing-1-25 branch 2 times, most recently from d3ec751 to e7e76f4 Compare July 18, 2022 20:18

k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jul 18, 2022

sallyom force-pushed the kubelet-tracing-1-25 branch from 16f1237 to 2daeadb Compare August 10, 2022 13:59

dashpole approved these changes Aug 10, 2022

View reviewed changes

sftim reviewed Aug 11, 2022

View reviewed changes

sallyom force-pushed the kubelet-tracing-1-25 branch 2 times, most recently from eb6c5cc to a85b183 Compare August 11, 2022 18:03

k8s-ci-robot removed area/blog Issues or PRs related to the Kubernetes Blog subproject area/release-eng Issues or PRs related to the Release Engineering subproject sig/release Categorizes an issue or PR as relevant to SIG Release. labels Aug 12, 2022

sftim reviewed Aug 12, 2022

View reviewed changes

content/en/docs/concepts/cluster-administration/system-traces.md Show resolved Hide resolved

content/en/docs/concepts/cluster-administration/system-traces.md Show resolved Hide resolved

content/en/docs/reference/command-line-tools-reference/feature-gates.md Show resolved Hide resolved

dashpole reviewed Aug 15, 2022

View reviewed changes

sallyom force-pushed the kubelet-tracing-1-25 branch from b73a7e6 to e6cae14 Compare August 15, 2022 22:30

k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 16, 2022

sallyom added 2 commits August 16, 2022 15:47

Update feature gate reference with KubeletTracing for 1.25

953311e

Adding KubeletTracing documentation now that kubernetes/kubernetes#105126 has merged.

add to cluster-admin/system-traces docs

221d4e8

sallyom force-pushed the kubelet-tracing-1-25 branch from e6cae14 to 221d4e8 Compare August 16, 2022 19:48

k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 16, 2022

k8s-ci-robot assigned reylejano Aug 16, 2022

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 16, 2022

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 16, 2022

k8s-ci-robot merged commit f210d88 into kubernetes:dev-1.25 Aug 16, 2022

sallyom mentioned this pull request Sep 15, 2022

Kubelet OpenTelemetry Tracing kubernetes/enhancements#2831

Open

12 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add docs for KubeletTracing feature gate 1.25 #35137

Add docs for KubeletTracing feature gate 1.25 #35137

sallyom commented Jul 18, 2022 •

edited

Loading

netlify bot commented Jul 18, 2022 •

edited

Loading

sallyom commented Jul 18, 2022

jihoon-seo commented Jul 19, 2022

sftim Aug 11, 2022

sallyom Aug 11, 2022

sallyom Aug 11, 2022

sftim Aug 11, 2022

sallyom Aug 11, 2022

sftim Aug 11, 2022

sallyom Aug 11, 2022

jihoon-seo commented Aug 12, 2022

sftim left a comment

sallyom commented Aug 13, 2022

sftim commented Aug 14, 2022

dashpole Aug 15, 2022

sallyom Aug 15, 2022

dashpole Aug 16, 2022

dashpole commented Aug 16, 2022

reylejano commented Aug 16, 2022

sallyom commented Aug 16, 2022

reylejano commented Aug 16, 2022

k8s-ci-robot commented Aug 16, 2022

k8s-ci-robot commented Aug 16, 2022

		{{< feature-state for_k8s_version="v1.22, kube-apiserver" state="alpha" >}}
		{{< feature-state for_k8s_version="v1.25, kubelet" state="alpha" >}}

Add docs for KubeletTracing feature gate 1.25 #35137

Add docs for KubeletTracing feature gate 1.25 #35137

Conversation

sallyom commented Jul 18, 2022 • edited Loading

netlify bot commented Jul 18, 2022 • edited Loading

👷 Deploy Preview for kubernetes-io-vnext-staging processing.

sallyom commented Jul 18, 2022

jihoon-seo commented Jul 19, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jihoon-seo commented Aug 12, 2022

sftim left a comment

Choose a reason for hiding this comment

sallyom commented Aug 13, 2022

sftim commented Aug 14, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dashpole commented Aug 16, 2022

reylejano commented Aug 16, 2022

sallyom commented Aug 16, 2022

reylejano commented Aug 16, 2022

k8s-ci-robot commented Aug 16, 2022

k8s-ci-robot commented Aug 16, 2022

sallyom commented Jul 18, 2022 •

edited

Loading

netlify bot commented Jul 18, 2022 •

edited

Loading