Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add docs for MatchLabelKeysInPodTopologySpread feature #35165

Merged
merged 1 commit into from
Aug 16, 2022
Merged

Add docs for MatchLabelKeysInPodTopologySpread feature #35165

merged 1 commit into from
Aug 16, 2022

Conversation

denkensk
Copy link
Member

Signed-off-by: Alex Wang wangqingcan1990@gmail.com

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 19, 2022
@netlify
Copy link

netlify bot commented Jul 19, 2022 •
edited
Loading

👷 Deploy Preview for kubernetes-io-vnext-staging processing.

Name Link
🔨 Latest commit cce49fe
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-vnext-staging/deploys/62f1cd8b5fa80500095f1c6f

@denkensk denkensk marked this pull request as draft July 19, 2022 11:32
@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. language/en Issues or PRs related to English language labels Jul 19, 2022
@k8s-ci-robot k8s-ci-robot added the sig/docs Categorizes an issue or PR as relevant to SIG Docs. label Jul 19, 2022
@cathchu
Copy link
Contributor

cathchu commented Jul 29, 2022

Hey there 👋 @denkensk , 1.25 Release Docs Shadow here!

Thanks for filing this placeholder. As a reminder, final docs PRs are due August 9th. Take a look at Documenting a release for additional information for the docs requirement for the release.

Thanks again!

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 1, 2022
@denkensk denkensk mentioned this pull request Aug 2, 2022
Open
8 tasks
@reylejano
Copy link
Member

/milestone 1.25
/assign @cathchu
/cc @kcmartin

@k8s-ci-robot k8s-ci-robot added this to the 1.25 milestone Aug 4, 2022
@denkensk denkensk force-pushed the doc-respect-PodTopologySpread branch from a4a7094 to e860332 Compare August 5, 2022 10:40
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 5, 2022
@denkensk denkensk changed the title [placeholder] doc-respect-PodTopologySpread doc-respect-PodTopologySpread Aug 5, 2022
@denkensk denkensk force-pushed the doc-respect-PodTopologySpread branch from e860332 to 8e79f30 Compare August 5, 2022 10:53
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 5, 2022
@denkensk denkensk marked this pull request as ready for review August 5, 2022 10:53
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 5, 2022
@denkensk
Copy link
Member Author

denkensk commented Aug 5, 2022

ping @cathchu It‘s ready to review.

@denkensk denkensk force-pushed the doc-respect-PodTopologySpread branch from 8e79f30 to 6e0dbb5 Compare August 6, 2022 00:29
@sftim
Copy link
Contributor

sftim commented Aug 6, 2022

/retitle Add docs for MatchLabelKeysInPodTopologySpread feature

@k8s-ci-robot k8s-ci-robot changed the title doc-respect-PodTopologySpread Add docs for MatchLabelKeysInPodTopologySpread feature Aug 6, 2022
sftim
sftim reviewed Aug 6, 2022
View reviewed changes
Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @denkensk

Here's a review.

content/en/docs/concepts/scheduling-eviction/topology-spread-constraints.md Outdated Show resolved Hide resolved
content/en/docs/reference/command-line-tools-reference/feature-gates.md Outdated Show resolved Hide resolved
@denkensk denkensk force-pushed the doc-respect-PodTopologySpread branch from 6e0dbb5 to db8a2c4 Compare August 8, 2022 11:22
@denkensk denkensk requested a review from sftim August 8, 2022 11:23
@denkensk
Copy link
Member Author

denkensk commented Aug 8, 2022

@sftim Updated. Pls take a look again. Thanks.

@reylejano
Copy link
Member

/assign @krol3

@denkensk denkensk force-pushed the doc-respect-PodTopologySpread branch from db8a2c4 to 5d72523 Compare August 9, 2022 02:24
@denkensk
add doc for MatchLabelKeysInPodTopologySpread
cce49fe 
Signed-off-by: Alex Wang <wangqingcan1990@gmail.com>
@denkensk denkensk force-pushed the doc-respect-PodTopologySpread branch from 5d72523 to cce49fe Compare August 9, 2022 02:59
@ahg-g
Copy link
Member

ahg-g commented Aug 9, 2022

/lgtm

from sig scheduling

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 9, 2022
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 90eb1a4d18bc9d6667880069c65c40fb0ea39027

@denkensk
Copy link
Member Author

ping @sftim for approve~ Thanks.

@cathchu
Copy link
Contributor

cathchu commented Aug 14, 2022

/assign @cathchu

@reylejano
Copy link
Member

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: reylejano

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 16, 2022
@k8s-ci-robot k8s-ci-robot merged commit 936b585 into kubernetes:dev-1.25 Aug 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahg-g ahg-g ahg-g left review comments

@rajeshdeshpande02 rajeshdeshpande02 Awaiting requested review from rajeshdeshpande02

@tengqm tengqm Awaiting requested review from tengqm

@kcmartin kcmartin Awaiting requested review from kcmartin

@mehabhalodiya mehabhalodiya Awaiting requested review from mehabhalodiya

@sftim sftim Awaiting requested review from sftim

Assignees

@krol3 krol3

@ahg-g ahg-g

@cathchu cathchu

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
1.25
Development

Successfully merging this pull request may close these issues.
7 participants
@denkensk @cathchu @reylejano @sftim @ahg-g @k8s-ci-robot @krol3