-
Notifications
You must be signed in to change notification settings - Fork 14.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mark EphemeralContainers as GA in 1.25 #35545
Conversation
👷 Deploy Preview for kubernetes-io-vnext-staging processing.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some early feedback/
content/en/docs/reference/command-line-tools-reference/feature-gates.md
Outdated
Show resolved
Hide resolved
@sftim There's more out of sync with api-reference than just ephemeral containers, so I think this must be updated all at once as part of the release process and I've only updated the section heading here. Nothing else changed for ephemeral containers this release, so I think this is ready for review. |
We update generated reference docs at release time. I would make the change to |
@sftim This section of the README tries to document the process: https://github.com/kubernetes/website/blob/main/README.md#building-the-api-reference-pages Running |
Just so I understand, why make @feloy should I just run the api-reference update as part of the |
For the moment, we are used to create a single PR to update the fields.yaml/toc.yaml files and the generated Markdown pages, for example #29668 But the change done here about moving a field from Beta level to non-Beta level is difficult to catch afterwards, and for this reason I would prefer it is done in this specific PR, or you could create some issue for me to remember to do it as part of the global PR.
Yes, you would have to run the |
The change in |
Co-authored-by: Tim Bannister <tim@scalefactory.com>
/assign @sethmccombs |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: reylejano The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
LGTM label has been added. Git tree hash: d86f9aed8c01847fabec13c11ddc0bb06551894e
|
This PR updates the website to reflect ephemeral containers graduating to GA.
Checklist before review: