-
Notifications
You must be signed in to change notification settings - Fork 14.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add echo-server image alternative for Apple Silicon chips #35928
Conversation
|
Welcome @pringon! |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
✅ Pull request preview available for checkingBuilt without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site settings. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, but I don't think this is the right fix.
_Note that the image used in the command above is currently incompatible with Apple Silicon, if the | ||
pod fails to start with `CrashLoopBackOff` try the command bellow._ | ||
|
||
```shell | ||
kubectl create deployment hello-node --image=polyverse/node-echo-server | ||
``` | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This fix isn't appropriate. Instead, we should fix k8s.gcr.io/echoserver
to run on AArch64 nodes.
I also agree that the fix should be with the container image |
@reylejano: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Issue mentioned in minikube repository.
I could find an issue in this repository, if someone is aware of a ticket tracking this then feel free to link it in. :)