Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add echo-server image alternative for Apple Silicon chips #35928

Closed
wants to merge 1 commit into from

Conversation

pringon
Copy link

@pringon pringon commented Aug 13, 2022

Issue mentioned in minikube repository.

I could find an issue in this repository, if someone is aware of a ticket tracking this then feel free to link it in. :)

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Aug 13, 2022

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: pringon / name: Dan Goje (46d4f5a)

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Aug 13, 2022
@k8s-ci-robot
Copy link
Contributor

Welcome @pringon!

It looks like this is your first PR to kubernetes/website 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/website has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. language/en Issues or PRs related to English language labels Aug 13, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign divya-mohan0209 for approval by writing /assign @divya-mohan0209 in a comment. For more information see:The Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the sig/docs Categorizes an issue or PR as relevant to SIG Docs. label Aug 13, 2022
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Aug 13, 2022
@netlify
Copy link

netlify bot commented Aug 13, 2022

Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 46d4f5a
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/62f78a39b6c0a30008b7c9c8
😎 Deploy Preview https://deploy-preview-35928--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, but I don't think this is the right fix.

Comment on lines +100 to +106
_Note that the image used in the command above is currently incompatible with Apple Silicon, if the
pod fails to start with `CrashLoopBackOff` try the command bellow._

```shell
kubectl create deployment hello-node --image=polyverse/node-echo-server
```

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fix isn't appropriate. Instead, we should fix k8s.gcr.io/echoserver to run on AArch64 nodes.

@reylejano
Copy link
Member

I also agree that the fix should be with the container image
Closing the PR, feel free to reopen if you feel otherwise
/close

@k8s-ci-robot
Copy link
Contributor

@reylejano: Closed this PR.

In response to this:

I also agree that the fix should be with the container image
Closing the PR, feel free to reopen if you feel otherwise
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@pringon pringon deleted the patch-1 branch October 30, 2022 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants