Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

removed tabs and spaces to fix the text. #392

Merged
merged 1 commit into from
Apr 19, 2016
Merged

removed tabs and spaces to fix the text. #392

merged 1 commit into from
Apr 19, 2016

Conversation

jmiddleton
Copy link
Contributor

The docs contains "shell" because there were tabs in the text. Also I changed wget for curl on OSX.

@jmiddleton
removed tabs and spaces to fix the text.
1e5f4f5 
The docs contains "shell" because there were tabs in the text. Also I changed wget for curl on OSX.
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.

  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@jmiddleton
Copy link
Contributor Author

I signed it!

On 18 Apr 2016, at 11:00 PM, googlebot notifications@github.com wrote:

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

Please visit https://cla.developers.google.com/ https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.

If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data https://cla.developers.google.com/clas and verify that your email is set on your git commits https://help.github.com/articles/setting-your-email-in-git/.
If you signed the CLA as a corporation, please let us know the company's name.
—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub #392 (comment)

@googlebot
Copy link

CLAs look good, thanks!

@johndmulhausen
Copy link

Thanks @jmiddleton !

@johndmulhausen johndmulhausen merged commit c3b8ccc into kubernetes:master Apr 19, 2016
rata
rata reviewed Apr 20, 2016
View reviewed changes
docs/getting-started-guides/docker.md
@@ -73,7 +73,7 @@ variable.
For example, OS X:

```shell
wget http://storage.googleapis.com/kubernetes-release/release/${K8S_VERSION}/bin/darwin/amd64/kubectl
curl -O http://storage.googleapis.com/kubernetes-release/release/${K8S_VERSION}/bin/darwin/amd64/kubectl
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, just curious. But why change wget?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rata wget does not work out of the box on Mac

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, thanks! Sorry, didn't get that from the commit title and thought it wasn't on purpose :)

gnomeontherun pushed a commit to gnomeontherun/kubernetes.github.io that referenced this pull request May 19, 2016
@johndmulhausen
Merge pull request kubernetes#392 from jmiddleton/patch-1
004ae7d 
removed tabs and spaces to fix the text.
mikutas pushed a commit to mikutas/k8s-website that referenced this pull request Feb 24, 2021
@kleimkuhler
Rollup stable-2.4.0 website changes (kubernetes#403)
6681164 
* Add docs for multi stage installation (kubernetes#387)
* Update the CLI and annotation docs for 2.4 (kubernetes#388)
* Update Troubleshooting page with new 2.4 checks (kubernetes#389)
* Update overview, getting started and architecture (kubernetes#393)
* Add PSP doc (kubernetes#392)
* Bump the supported k8s version to 1.12 (kubernetes#367)
* Add task 'Using Debugging Endpoints' (kubernetes#329)
* Add task 'Using Debugging Endpoints'
* 2.4 - Upgrade notes (kubernetes#396)
* Mark High Availability as non-experimental (kubernetes#399)
* 2.4 - Add documentation on using the debug container (kubernetes#327)

Signed-off-by: Kevin Leimkuhler <kleimkuhler@icloud.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jmiddleton @googlebot @johndmulhausen @rata