Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated the broken link for xfs.org site #39462

Merged
merged 3 commits into from
Mar 25, 2023

Conversation

SaumyaBhushan
Copy link
Contributor

workerB
fix: #38146

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 15, 2023
@k8s-ci-robot k8s-ci-robot added the language/en Issues or PRs related to English language label Feb 15, 2023
@k8s-ci-robot k8s-ci-robot added the sig/docs Categorizes an issue or PR as relevant to SIG Docs. label Feb 15, 2023
@netlify
Copy link

netlify bot commented Feb 15, 2023

Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 48eee13
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/641d25350bc07f00084384d0
😎 Deploy Preview https://deploy-preview-39462--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@tengqm
Copy link
Contributor

tengqm commented Feb 15, 2023

The new link is not accurate, but at least it is working.
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 15, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: a23959f92b0ad9b26bdadef86865248e26a2f87b

…ners.md

Co-authored-by: Rey Lejano <rlejano@gmail.com>
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 11, 2023
@SaumyaBhushan
Copy link
Contributor Author

Hi @shannonxtreme . I have updated the code but somehow checks are failing .

@Shubham82
Copy link
Contributor

I checked the logs, the following error is coming:

Error: Error building site: "/opt/build/repo/content/en/docs/reference/issues-security/official-cve-feed.md:31:1": failed to render shortcode "cve-feed": failed to process shortcode: "/opt/build/repo/layouts/shortcodes/cve-feed.html:13:20": execute of template failed: template: shortcodes/cve-feed.html:13:20: executing "shortcodes/cve-feed.html" at <.cve_url>: can't evaluate field cve_url in type interface {}

It is due to the changes done in the following PR: #39513

@Shubham82
Copy link
Contributor

Rebasing will resolve this issue, so you can rebase your branch and then push the commit.

@Shubham82
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 24, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 01fd8288b974a196711c2eb1788eadcf9475dd95

Copy link
Contributor

@divya-mohan0209 divya-mohan0209 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @SaumyaBhushan for the change!

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: divya-mohan0209

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 25, 2023
@k8s-ci-robot k8s-ci-robot merged commit e560418 into kubernetes:main Mar 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

xfs.org site is unreachable.
6 participants