Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ru]Replace k8s.gcr.io references with registry.k8s.io #39957

Conversation

asa3311
Copy link
Contributor

@asa3311 asa3311 commented Mar 13, 2023

No description provided.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/ru Issues or PRs related to Russian language labels Mar 13, 2023
@k8s-ci-robot k8s-ci-robot requested review from onlydole and shurup March 13, 2023 06:25
@k8s-ci-robot k8s-ci-robot added sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 13, 2023
@shurup
Copy link
Member

shurup commented Mar 13, 2023

Thank you, @asa3311! We did a massive replacement in #39245 before. However, some new content got merged since that time, and it had this old domain mentioned. I double-checked we don't have more k8s.gcr.io in the current content/ru directory.

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: shurup

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 13, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: baef8101558cdf02b268f2bae12011e06413a431

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 13, 2023
Copy link
Member

@Arhell Arhell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@Arhell Arhell removed their assignment Mar 14, 2023
@shurup
Copy link
Member

shurup commented Mar 14, 2023

We came across the "Build exceeded maximum allowed runtime" error here, which is not related to the PR itself (#35780).

@asa3311 can you, please, do this to trigger a rebuild for this PR?

git commit --amend
git push --force

@asa3311
Copy link
Contributor Author

asa3311 commented Mar 14, 2023

ok,I will rebuild

@asa3311
Copy link
Contributor Author

asa3311 commented Mar 14, 2023

@shurup Hi ,I try to rebuild,but,it also failed,what can I do?

@netlify
Copy link

netlify bot commented Mar 14, 2023

Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 9682aca
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/64108bed1ede750008fb03a7
😎 Deploy Preview https://deploy-preview-39957--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/ru Issues or PRs related to Russian language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants