Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[pt-br] Update tutorials/kubernetes-basics/create-cluster #41550

Merged
merged 2 commits into from
Jun 13, 2023
Merged

[pt-br] Update tutorials/kubernetes-basics/create-cluster #41550

merged 2 commits into from
Jun 13, 2023

Conversation

stormqueen1990
Copy link
Member

Umbrella issue: #41496

Changes

  • Update the cluster-intro tutorial to reflect the latest English version and remove Katacoda references.
  • Update the create-cluster/_index.md page to reflect the latest English version.

@stormqueen1990
[pt-br] Update cluster-intro tutorial.
e8d50d6 
* Update the cluster-intro tutorial to reflect the latest English version and remove Katacoda references.
* Update the create-cluster/_index.md page to reflect the latest English version.
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 8, 2023
@k8s-ci-robot k8s-ci-robot added the language/pt Issues or PRs related to Portuguese language label Jun 8, 2023
@k8s-ci-robot k8s-ci-robot added sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 8, 2023
@netlify
Copy link

netlify bot commented Jun 8, 2023 •
edited
Loading

✅ Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 2110014
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/64872fe282565a000822d9e2
😎 Deploy Preview https://deploy-preview-41550--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@stormqueen1990 stormqueen1990 changed the title [pt-br] Update cluster-intro tutorial [pt-br] Update tutorials/kubernetes/basics/create-cluster/cluster-intro.html Jun 9, 2023
@stormqueen1990 stormqueen1990 changed the title [pt-br] Update tutorials/kubernetes/basics/create-cluster/cluster-intro.html [pt-br] Update tutorials/kubernetes/basics/create-cluster Jun 9, 2023
@stormqueen1990 stormqueen1990 changed the title [pt-br] Update tutorials/kubernetes/basics/create-cluster [pt-br] Update tutorials/kubernetes-basics/create-cluster Jun 9, 2023
@MrErlison
Copy link
Member

MrErlison commented Jun 10, 2023 •
edited
Loading

Hi @stormqueen1990!

Thanks again for you great job!

/lgtm

@MrErlison
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 10, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 8b307fe1c92c7587f33dbceb60416a18afb82860

@MrErlison
Copy link
Member

/cc @jcjesus

Could you please provide a second review?

@jcjesus
Copy link
Contributor

jcjesus commented Jun 10, 2023

/cc @jcjesus

Could you please provide a second review?

Sure!

jcjesus
jcjesus requested changes Jun 12, 2023
View reviewed changes
Copy link
Contributor

@jcjesus jcjesus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @MrErlison, good job, there is just only typo to fix.
Thanks

content/pt-br/docs/tutorials/kubernetes-basics/create-cluster/cluster-intro.html Outdated Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 12, 2023
@stormqueen1990
Copy link
Member Author

/cc @MrErlison @jcjesus

jcjesus
jcjesus approved these changes Jun 12, 2023
View reviewed changes
Copy link
Contributor

@jcjesus jcjesus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done!
Thanks

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jcjesus

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 12, 2023
@jcjesus
Copy link
Contributor

jcjesus commented Jun 13, 2023

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 13, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: cbdd0259996ab570385e65a575effc7046cbe1ef

@k8s-ci-robot k8s-ci-robot merged commit a0a2464 into kubernetes:main Jun 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcjesus jcjesus jcjesus approved these changes

@MrErlison MrErlison Awaiting requested review from MrErlison

@yagonobre yagonobre Awaiting requested review from yagonobre

Assignees

@jcjesus jcjesus

@MrErlison MrErlison

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/pt Issues or PRs related to Portuguese language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@stormqueen1990 @MrErlison @k8s-ci-robot @jcjesus