Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ja] Update ephemeral-volumes.md #42038

Merged
merged 2 commits into from
Jul 24, 2023
Merged

[ja] Update ephemeral-volumes.md #42038

merged 2 commits into from
Jul 24, 2023

Conversation

Arhell
Copy link
Member

@Arhell Arhell commented Jul 16, 2023

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 16, 2023
@k8s-ci-robot k8s-ci-robot requested a review from kakts July 16, 2023 21:29
@k8s-ci-robot k8s-ci-robot added the language/ja Issues or PRs related to Japanese language label Jul 16, 2023
@k8s-ci-robot k8s-ci-robot requested a review from t-inu July 16, 2023 21:29
@k8s-ci-robot k8s-ci-robot added the sig/docs Categorizes an issue or PR as relevant to SIG Docs. label Jul 16, 2023
@netlify
Copy link

netlify bot commented Jul 16, 2023 •
edited
Loading

✅ Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit f05c3c4
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/64b857e28fb72d00086572f2
😎 Deploy Preview https://deploy-preview-42038--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

dipesh-rawat
dipesh-rawat reviewed Jul 17, 2023
View reviewed changes
Copy link
Member

@dipesh-rawat dipesh-rawat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change looks in sync with 'en' PR.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 17, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 1d6964174fb514f6c3cd0e53145ea170ed74abe6

Vikash-8090-Yadav
Vikash-8090-Yadav approved these changes Jul 17, 2023
View reviewed changes
Copy link
Member

@Vikash-8090-Yadav Vikash-8090-Yadav left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, 👍

@k8s-ci-robot
Copy link
Contributor

@Vikash-8090-Yadav: changing LGTM is restricted to collaborators

In response to this:

Great
/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

atoato88
atoato88 reviewed Jul 17, 2023
View reviewed changes
Copy link
Contributor

@atoato88 atoato88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left a comment, please check it.

content/ja/docs/concepts/storage/ephemeral-volumes.md Outdated Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 18, 2023
Arhell
Arhell commented Jul 20, 2023
View reviewed changes
Copy link
Member Author

@Arhell Arhell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@atoato88

dipesh-rawat
dipesh-rawat reviewed Jul 20, 2023
View reviewed changes
Copy link
Member

@dipesh-rawat dipesh-rawat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 20, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: f1564b4edf45802752eb4350dd088c71888bcff0

@nasa9084
Copy link
Member

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nasa9084, Vikash-8090-Yadav

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 24, 2023
@k8s-ci-robot k8s-ci-robot merged commit ff6d646 into kubernetes:main Jul 24, 2023
@Arhell Arhell deleted the ja-upd branch July 24, 2023 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dipesh-rawat dipesh-rawat dipesh-rawat left review comments

@Vikash-8090-Yadav Vikash-8090-Yadav Vikash-8090-Yadav approved these changes

@kakts kakts Awaiting requested review from kakts

@t-inu t-inu Awaiting requested review from t-inu

@atoato88 atoato88 Awaiting requested review from atoato88

@nasa9084 nasa9084 Awaiting requested review from nasa9084

Assignees

@atoato88 atoato88

@nasa9084 nasa9084

@dipesh-rawat dipesh-rawat

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/ja Issues or PRs related to Japanese language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Arhell @k8s-ci-robot @nasa9084 @atoato88 @dipesh-rawat @Vikash-8090-Yadav