-
Notifications
You must be signed in to change notification settings - Fork 14.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix storageclass pvc statement #42177
Fix storageclass pvc statement #42177
Conversation
✅ Pull request preview available for checkingBuilt without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
/sig storage |
883e4f0
to
05af8f1
Compare
05af8f1
to
84ce0f1
Compare
Hi @sftim, can you please review this. |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tengqm The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/auto-cc |
Can you add lgtm @tengqm |
@Affan-7 I intentionally left the technical LGTM to others. I'm aware of this behavior difference and the related change, but I do believe a technical LGTM is desirable. |
It may be beyond the expertise (or simply time budget) of the OP to amend this PR as I am requesting, but I believe this page in particular needs significant changes with respect to the
Is misleading at best, because the cluster administrator does not need to do anything to enable the admission controller. Several other sections documenting the difference between having the |
Would you be willing to open an issue about that shortcoming @Nuru? |
This comment was marked as resolved.
This comment was marked as resolved.
all PVCs. | ||
cluster responds to PVC creation as if the admission plugin were turned off. If more than one | ||
default StorageClass is specified, the newest default is used when the | ||
PVC is dynamically provisioned. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@RomanBednar @jsafrane Can you verify this? Based on this PR https://github.com/kubernetes/kubernetes/pull/117064/files, it is not always the newest.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMO it will be very rare / impossible that two StorageClasses have the same CreationTimestamp. IMO the sentence is good enough for users.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
^^^ Agreed, chances to hit that condition is very low.
based on #42177 (comment) /lgtm |
LGTM label has been added. Git tree hash: 8a12def215f05a4aee9de39d16ab35639613423c
|
Oops, this incorrectly marked #42176 as fixed. Sorry about that. |
This fixes #42176
Here is what I did:
I created two default storage classes. And applied the following manifest file for creating a PVC with no explicit 'storageClassName' attribute.
The PVC got bound with the newest storageclass(local-storage).
Here is a reference: kubernetes/kubernetes#110559