Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add feature blog post for sidecar containers #42323

Merged
merged 1 commit into from
Aug 18, 2023
Merged

Add feature blog post for sidecar containers #42323

merged 1 commit into from
Aug 18, 2023

Conversation

matthyx
Copy link
Contributor

@matthyx matthyx commented Aug 1, 2023

No description provided.

@k8s-ci-robot k8s-ci-robot added this to the 1.28 milestone Aug 1, 2023
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 1, 2023
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 1, 2023
@k8s-ci-robot k8s-ci-robot added area/blog Issues or PRs related to the Kubernetes Blog subproject language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Aug 1, 2023
@netlify
Copy link

netlify bot commented Aug 1, 2023 •
edited
Loading

👷 Deploy Preview for kubernetes-io-vnext-staging processing.

Name Link
🔨 Latest commit 9a027d5
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-vnext-staging/deploys/64d487d5d1947c000806e67e

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 1, 2023
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 10, 2023
@matthyx matthyx changed the title WIP Feature blog post for sidecar containers Feature blog post for sidecar containers Aug 10, 2023
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 10, 2023
@matthyx matthyx force-pushed the sidecar-blog branch 2 times, most recently from 920b3d0 to 3bfcc1d Compare August 10, 2023 06:08
@reylejano
Copy link
Member

As this is a feature blog for 1.28 and will be published after the 1.28 release day, please target the main branch

@reylejano
Copy link
Member

/assign @bradmccoydev @krol3 @mashby2022 @ramrodo @thschue

@matthyx matthyx changed the base branch from dev-1.28 to main August 11, 2023 19:19
@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 11, 2023
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 15, 2023
@tengqm
Copy link
Contributor

tengqm commented Aug 16, 2023

/approve
Reading this is a pleasure.
LGTM from docs perspective.

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 16, 2023
@gjkim42
Copy link
Member

gjkim42 commented Aug 16, 2023

Thanks!

/lgtm

@matthyx @tzneal
/hold
in case any of you want to update this before merging.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 16, 2023
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 16, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: e72abb6f57473935c9d0a0e9830693e8414f298e

@matthyx
Feature blog post for sidecar containers
d987348 
Signed-off-by: Matthias Bertschy <matthias.bertschy@gmail.com>
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 16, 2023
tzneal
tzneal approved these changes Aug 16, 2023
View reviewed changes
Copy link
Contributor

@tzneal tzneal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Thanks @matthyx !

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 16, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 548928c8817738a569e574ee42a49087c5c0b823

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tengqm, tzneal

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@divya-mohan0209
Copy link
Contributor

Hello folks, is this ready to be merged please?

@matthyx
Copy link
Contributor Author

matthyx commented Aug 18, 2023

yes, but published on the 25th please

@divya-mohan0209
Copy link
Contributor

Yep, the merge will happen today as soon as I unhold & the publishing will happen per the date field i.e. 25th August.
/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 18, 2023
@k8s-ci-robot k8s-ci-robot merged commit fc9493a into kubernetes:main Aug 18, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sftim sftim sftim left review comments

@tzneal tzneal tzneal approved these changes

@nate-double-u nate-double-u Awaiting requested review from nate-double-u

@onlydole onlydole Awaiting requested review from onlydole

@bradmccoydev bradmccoydev Awaiting requested review from bradmccoydev

@gjkim42 gjkim42 Awaiting requested review from gjkim42

@krol3 krol3 Awaiting requested review from krol3

@mashby2022 mashby2022 Awaiting requested review from mashby2022

@ramrodo ramrodo Awaiting requested review from ramrodo

@thschue thschue Awaiting requested review from thschue

Assignees

@tzneal tzneal

@ramrodo ramrodo

@krol3 krol3

@gjkim42 gjkim42

@bradmccoydev bradmccoydev

@thschue thschue

@mashby2022 mashby2022

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/blog Issues or PRs related to the Kubernetes Blog subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
SIG Docs Blog Project Board
Status: Published
Milestone
1.28
Development

Successfully merging this pull request may close these issues.