-
Notifications
You must be signed in to change notification settings - Fork 14.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[de] Removing old CSS includes from K8s basics tutorials #42541
Conversation
✅ Pull request preview available for checkingBuilt without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The proposed changes looks to be inline with 'en' changes as part of PR#34188.
LGTM
Seems okay to me ! /lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rlenferink The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
LGTM label has been added. Git tree hash: 4e9b1acbfc6aa1cf098f98480e886b0244ef939e
|
Thanks, @rlenferink! Not directly related to this PR, but since |
Thanks for bringing this up! In case you want to remove those, feel extremely welcome to open another PR. |
I'd be happy to, but simply removing this Katacoda JS file won't be enough — actually, that's why I didn't do it in this PR already. To get rid of Katacoda, many texts need corrections, which I can't do without German knowledge. I can open an issue for your localisation where this task will be described (so someone else can work on it) — if that helps. |
German tutorials still include old CSS files. However, if you visit these pages, the browser will try to access them and return 404 (e.g.). They were removed from the English tutorials in #34188. This PR removes them from the German localisation.
/sig docs
/language de
/area localization