Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[de] Removing old CSS includes from K8s basics tutorials #42541

Merged
merged 1 commit into from
Aug 16, 2023

Conversation

shurup
Copy link
Member

@shurup shurup commented Aug 15, 2023

German tutorials still include old CSS files. However, if you visit these pages, the browser will try to access them and return 404 (e.g.). They were removed from the English tutorials in #34188. This PR removes them from the German localisation.

/sig docs
/language de
/area localization

@k8s-ci-robot k8s-ci-robot added sig/docs Categorizes an issue or PR as relevant to SIG Docs. language/de Issues or PRs related to German language area/localization General issues or PRs related to localization cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Aug 15, 2023
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Aug 15, 2023
@netlify
Copy link

netlify bot commented Aug 15, 2023

Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 792debf
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/64db4db307b3d80007475d69
😎 Deploy Preview https://deploy-preview-42541--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@dipesh-rawat dipesh-rawat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The proposed changes looks to be inline with 'en' changes as part of PR#34188.
LGTM

@rlenferink
Copy link
Member

Seems okay to me !

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 16, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rlenferink

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 4e9b1acbfc6aa1cf098f98480e886b0244ef939e

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 16, 2023
@k8s-ci-robot k8s-ci-robot merged commit 8dda7bc into kubernetes:main Aug 16, 2023
4 checks passed
@shurup
Copy link
Member Author

shurup commented Aug 16, 2023

Thanks, @rlenferink!

Not directly related to this PR, but since https://katacoda.com/embed.js was included on those pages next to the CSS files I removed here, I also wanted to let you know that all Katacoda-related pieces should be removed from the localisation since these interactive tutorials are not supported anymore and need replacing. Here is an umbrella issue for this task #41496

@rlenferink
Copy link
Member

Thanks for bringing this up! In case you want to remove those, feel extremely welcome to open another PR.

@shurup
Copy link
Member Author

shurup commented Aug 17, 2023

I'd be happy to, but simply removing this Katacoda JS file won't be enough — actually, that's why I didn't do it in this PR already. To get rid of Katacoda, many texts need corrections, which I can't do without German knowledge. I can open an issue for your localisation where this task will be described (so someone else can work on it) — if that helps.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/localization General issues or PRs related to localization cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/de Issues or PRs related to German language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants