Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revise docs for API tracking of IP address assignment #44127

Merged
merged 2 commits into from
Nov 29, 2023
Merged

Revise docs for API tracking of IP address assignment #44127

merged 2 commits into from
Nov 29, 2023

Conversation

sftim
Copy link
Contributor

@sftim sftim commented Nov 29, 2023

A tweak to land after #43469 has merged.

/sig network
/milestone 1.29

@k8s-ci-robot k8s-ci-robot modified the milestone: 1.29 Nov 29, 2023
@k8s-ci-robot k8s-ci-robot added sig/network Categorizes an issue or PR as relevant to SIG Network. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Nov 29, 2023
@netlify Netlify
Copy link

netlify bot commented Nov 29, 2023 •
edited
Loading

👷 Deploy Preview for kubernetes-io-vnext-staging processing.

Name Link
🔨 Latest commit 387192d
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-vnext-staging/deploys/656719135a86b500084cf581

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. language/en Issues or PRs related to English language labels Nov 29, 2023
@k8s-ci-robot k8s-ci-robot added the sig/docs Categorizes an issue or PR as relevant to SIG Docs. label Nov 29, 2023
nate-double-u
nate-double-u reviewed Nov 29, 2023
View reviewed changes
Copy link
Contributor

@nate-double-u nate-double-u left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small suggestion, otherwise /lgtm

content/en/docs/reference/networking/virtual-ips.md Outdated Show resolved Hide resolved
@nate-double-u
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 29, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 9c5458af5138e57adbd3215a769a920e1df77da4

kundan2707
kundan2707 reviewed Nov 29, 2023
View reviewed changes
Copy link
Contributor

@kundan2707 kundan2707 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 29, 2023
@sftim sftim force-pushed the 20231129_revise_vips_api_ipam branch from 5909825 to 534cee6 Compare November 29, 2023 09:17
@sftim
Revise docs for API tracking of IP address assignment
1ea312d
@sftim
Fix style nits
387192d 
Update “Virtual IPs and Service Proxies” to align better with our style
guide and SIG conventions.
@sftim sftim force-pushed the 20231129_revise_vips_api_ipam branch from 534cee6 to 387192d Compare November 29, 2023 10:57
@katcosgrove
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 29, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: c0aa378ae5b278b696ffd4ec2c99dc9f7f9281cf

@katcosgrove
Copy link
Contributor

/assign @nate-double-u

@natalisucks
Copy link
Contributor

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: natalisucks

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 29, 2023
@k8s-ci-robot k8s-ci-robot merged commit b9b22e3 into kubernetes:dev-1.29 Nov 29, 2023
6 checks passed
@sftim sftim deleted the 20231129_revise_vips_api_ipam branch November 29, 2023 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@natalisucks natalisucks Awaiting requested review from natalisucks

@reylejano reylejano Awaiting requested review from reylejano

@kundan2707 kundan2707 Awaiting requested review from kundan2707

@nate-double-u nate-double-u Awaiting requested review from nate-double-u

Assignees

@nate-double-u nate-double-u

@katcosgrove katcosgrove

@kundan2707 kundan2707

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. sig/network Categorizes an issue or PR as relevant to SIG Network. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
1.29
Development

Successfully merging this pull request may close these issues.
6 participants
@sftim @nate-double-u @k8s-ci-robot @katcosgrove @natalisucks @kundan2707