ImageGCMaxAge beta bump #45153

haircommander · 2024-02-15T17:03:19Z

as well as document accompanying metric

netlify · 2024-02-15T17:03:24Z

👷 Deploy Preview for kubernetes-io-vnext-staging processing.

Name	Link
🔨 Latest commit	`067648a`
🔍 Latest deploy log	https://app.netlify.com/sites/kubernetes-io-vnext-staging/deploys/6602e1618c69b50008b15d70

dipesh-rawat · 2024-02-15T17:37:33Z

/retitle [WIP]: ImageGCMaxAge beta bump

dipesh-rawat · 2024-02-15T17:37:46Z

/sig node

reylejano · 2024-02-16T06:33:24Z

/milestone 1.30

fsmunoz · 2024-03-06T19:10:26Z

Hello @haircommander 👋 !

Please take a look at Documenting for a release - PR Ready for Review to get your PR ready for review before the deadline Tuesday March 12th 2024 18:00 PST.

Thank you!

dipesh-rawat

Please exclude changes to the following generated doc pages:

content/en/docs/reference/command-line-tools-reference/kube-apiserver.md
content/en/docs/reference/command-line-tools-reference/kube-controller-manager.md
content/en/docs/reference/command-line-tools-reference/kube-proxy.md
content/en/docs/reference/command-line-tools-reference/kube-scheduler.md
content/en/docs/reference/command-line-tools-reference/kubelet.md
content/en/docs/reference/instrumentation/metrics.md

These files are autogenerated as part of the release process, and the generated docs are committed into this repository separately. Hence, there's no need to modify them within this pull request.

katcosgrove · 2024-03-15T19:30:58Z

Hey @haircommander! Just a reminder that this needs to be reviewed and ready to merge by Docs Freeze on March 26, including a technical review. An exception request will be required if you cannot meet that deadline. Thank you!

sftim

Please omit the generated files from this PR; it's simpler to generate them once just before release day. Look for auto_generated: true at the start of the files.

I also added some inline feedback.

sftim · 2024-03-18T11:04:32Z

content/en/docs/concepts/architecture/garbage-collection.md

+This feature does not track image usage across Kubelet reboots. If the Kubelet
+is rebooted, the image age is reset, causing the Kubelet to wait the full


The kubelet doesn't have a bootloader, so:

Suggested change

This feature does not track image usage across Kubelet reboots. If the Kubelet

is rebooted, the image age is reset, causing the Kubelet to wait the full

This feature does not track image usage across kubelet restarts. If the kubelet

is restarted, the tracked image age is reset, causing the kubelet to wait the full

(updated)

sftim · 2024-03-18T11:04:45Z

content/en/docs/concepts/architecture/garbage-collection.md

+This feature does not track image usage across Kubelet reboots. If the Kubelet
+is rebooted, the image age is reset, causing the Kubelet to wait the full
+`ImageMaximumGCAge` duration before qualifying images for garbage collection
+based on image age


(nit)

Suggested change

based on image age

based on image age.

sftim · 2024-03-18T11:06:04Z

content/en/docs/reference/command-line-tools-reference/feature-gates/image-maximum-gc-age.md

 ---
-Enables the kubelet configuration field `imageMaximumGCAge`, allowing an administrator to specify the age after which an image will be garbage collected.
+Enables the kubelet configuration field `imageMaximumGCAge`, allowing an administrator to specify the age after which an image will be garbage collected.


Even better: leave this line unchanged.

drewhagen · 2024-03-18T16:38:13Z

Hey @SergeyKanzhelev @bsdnet @mrunalp @dchen1107!

Just a reminder that this PR needs a technical review by Docs Freeze on March 26. An exception request will be required if the deadline is missed. Thanks!

drewhagen · 2024-03-24T16:21:45Z

I'm reaching out from the Docs team. Just checking in as we approach Docs Freeze on Tuesday March 26th 18:00 PDT. This documentation appears to still be under review. To meet the Docs Freeze, this PR must have a technical review as well as lgtm and approve labels applied, without any unaddressed comments or concerns from SIG Docs. The status of this enhancement is marked as at risk for docs freeze.

@kubernetes/sig-node-leads Can we get a technical review for these docs to make the Docs Freeze deadline of March 26? Thanks!

fsmunoz · 2024-03-25T15:41:53Z

@haircommander hello, Release Lead Shadow for 1.30, acting as Docs shadow here; as @drewhagen mentioned above, the Docs Freeze is fast approaching (Tuesday March 26th 18:00 PDT).

From what I've seen, the technical review is pending (cc @SergeyKanzhelev @bsdnet @mrunalp @dchen1107 ), and there are also some pending review item from SIG Docs + others that need to be closed - could you take a look?

I think that with that the lgtm and approve can be obtained, hopefully in time for the Freeze deadline 🙏

haircommander · 2024-03-25T17:07:48Z

thanks for everyone's patience, I have updated the document with the suggestions

mrunalp

/approve
for sig-node

dipesh-rawat · 2024-03-26T00:58:28Z

content/en/docs/concepts/architecture/garbage-collection.md

+{{< note >}}
+```suggestion
+This feature does not track image usage across kubelet restarts. If the kubelet
+is restarted, the tracked image age is reset, causing the kubelet to wait the full
+`ImageMaximumGCAge` duration before qualifying images for garbage collection
+based on image age.
+```
+
+{{< /note>}}


The content within the markdown block was suggested (here) for addition in the PR, it seems that the backticks (```) should not be included in the actual change. If that is the case, it would be appropriate to remove these backticks.

Suggested change

{{< note >}}

```suggestion

This feature does not track image usage across kubelet restarts. If the kubelet

is restarted, the tracked image age is reset, causing the kubelet to wait the full

`ImageMaximumGCAge` duration before qualifying images for garbage collection

based on image age.

```

{{< /note>}}

{{< note >}}

This feature does not track image usage across kubelet restarts. If the kubelet

is restarted, the tracked image age is reset, causing the kubelet to wait the full

`ImageMaximumGCAge` duration before qualifying images for garbage collection

based on image age.

{{< /note>}}

dipesh-rawat · 2024-03-26T00:58:48Z

content/en/docs/reference/instrumentation/metrics.md

Please exclude the changes made to this generated file.

dipesh-rawat

The PR is currently lacking the change to transition the feature gate from Alpha to Beta. The necessary change should be made in the feature gate description file -
image-maximum-gc-age.md (here).

Please refer to the documentation here for further information.

haircommander · 2024-03-26T14:10:28Z

updated! thanks @dipesh-rawat

dipesh-rawat · 2024-03-26T14:49:59Z

content/en/docs/reference/command-line-tools-reference/feature-gates/image-maximum-gc-age.md

+  - stage: beta
+    defaultValue: true
+    fromVersion: "1.30"


The changes to the stages block appear incorrect. Please refer to the documentation here for further information. Additionally, I've provided some suggested changes below for your consideration. I hope these recommendations prove helpful.

Suggested change

- stage: beta

defaultValue: true

fromVersion: "1.30"

- stage: alpha

defaultValue: false

fromVersion: "1.29"

toVersion: "1.29"

- stage: beta

defaultValue: true

fromVersion: "1.30"

Signed-off-by: Peter Hunt <pehunt@redhat.com>

fsmunoz · 2024-03-26T16:30:59Z

@haircommander , did your forced-push address @sftim review? Mentioning it because it still appears as "changes requested", which could be in the way.

drewhagen · 2024-03-26T16:45:59Z

Please omit the generated files from this PR; it's simpler to generate them once just before release day. Look for auto_generated: true at the start of the files.

I also added some inline feedback.

Yup it looks like the changes requested in this post may be blocking merge.

Review was stale

kannon92 · 2024-03-26T16:54:24Z

LGTM from sig-node side.

dipesh-rawat

Thanks!

/lgtm
/approve

k8s-ci-robot · 2024-03-26T17:02:56Z

LGTM label has been added.

Git tree hash: b64b446355a9d9e0cd3514e9fe527544b0aa8b8b

k8s-ci-robot · 2024-03-26T17:02:57Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dipesh-rawat, mrunalp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~content/en/OWNERS~~ [dipesh-rawat]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

drewhagen · 2024-04-25T23:26:42Z

/milestone 1.30

k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 15, 2024

k8s-ci-robot changed the title ~~placeholder for ImageGCMaxAge beta bump~~ [WIP]: ImageGCMaxAge beta bump Feb 15, 2024

k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 15, 2024

k8s-ci-robot added the sig/node Categorizes an issue or PR as relevant to SIG Node. label Feb 15, 2024

k8s-ci-robot added this to the 1.30 milestone Feb 16, 2024

haircommander force-pushed the image-max-gc-beta-1.30 branch from b4da67c to 2300ca1 Compare March 11, 2024 17:02

haircommander changed the title ~~[WIP]: ImageGCMaxAge beta bump~~ ImageGCMaxAge beta bump Mar 11, 2024

k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 11, 2024

dipesh-rawat reviewed Mar 15, 2024

View reviewed changes

sftim previously requested changes Mar 18, 2024

View reviewed changes

haircommander force-pushed the image-max-gc-beta-1.30 branch from 2300ca1 to a93f668 Compare March 25, 2024 17:07

k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 25, 2024

mrunalp approved these changes Mar 25, 2024

View reviewed changes

dipesh-rawat reviewed Mar 26, 2024

View reviewed changes

content/en/docs/reference/instrumentation/metrics.md Outdated

Copy link

Member

dipesh-rawat Mar 26, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please exclude the changes made to this generated file.

dipesh-rawat suggested changes Mar 26, 2024

View reviewed changes

pacoxu mentioned this pull request Mar 26, 2024

kubelet image GC after a maximum age kubernetes/enhancements#4210

Open

8 tasks

haircommander force-pushed the image-max-gc-beta-1.30 branch from a93f668 to eb29831 Compare March 26, 2024 14:10

dipesh-rawat reviewed Mar 26, 2024

View reviewed changes

bump ImageMaximumGCAge KEP to beta

067648a

Signed-off-by: Peter Hunt <pehunt@redhat.com>

haircommander force-pushed the image-max-gc-beta-1.30 branch from eb29831 to 067648a Compare March 26, 2024 14:53

dipesh-rawat reviewed Mar 26, 2024

View reviewed changes

k8s-ci-robot assigned dipesh-rawat Mar 26, 2024

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 26, 2024

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 26, 2024

k8s-ci-robot merged commit cbf0322 into kubernetes:dev-1.30 Mar 26, 2024
6 checks passed

k8s-ci-robot added this to the 1.30 milestone Apr 25, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

ImageGCMaxAge beta bump #45153

ImageGCMaxAge beta bump #45153

haircommander commented Feb 15, 2024 •

edited

Loading

netlify bot commented Feb 15, 2024 •

edited

Loading

dipesh-rawat commented Feb 15, 2024

dipesh-rawat commented Feb 15, 2024

reylejano commented Feb 16, 2024

fsmunoz commented Mar 6, 2024

dipesh-rawat left a comment

katcosgrove commented Mar 15, 2024

sftim left a comment

sftim Mar 18, 2024 •

edited

Loading

sftim Mar 18, 2024

sftim Mar 18, 2024

drewhagen commented Mar 18, 2024

drewhagen commented Mar 24, 2024 •

edited

Loading

fsmunoz commented Mar 25, 2024

haircommander commented Mar 25, 2024

mrunalp left a comment

dipesh-rawat Mar 26, 2024

sftim Mar 26, 2024

dipesh-rawat Mar 26, 2024

dipesh-rawat left a comment

haircommander commented Mar 26, 2024

dipesh-rawat Mar 26, 2024

haircommander Mar 26, 2024

fsmunoz commented Mar 26, 2024 •

edited

Loading

drewhagen commented Mar 26, 2024 •

edited

Loading

kannon92 commented Mar 26, 2024

dipesh-rawat left a comment

k8s-ci-robot commented Mar 26, 2024

k8s-ci-robot commented Mar 26, 2024

drewhagen commented Apr 25, 2024

		This feature does not track image usage across Kubelet reboots. If the Kubelet
		is rebooted, the image age is reset, causing the Kubelet to wait the full

ImageGCMaxAge beta bump #45153

ImageGCMaxAge beta bump #45153

Conversation

haircommander commented Feb 15, 2024 • edited Loading

netlify bot commented Feb 15, 2024 • edited Loading

👷 Deploy Preview for kubernetes-io-vnext-staging processing.

dipesh-rawat commented Feb 15, 2024

dipesh-rawat commented Feb 15, 2024

reylejano commented Feb 16, 2024

fsmunoz commented Mar 6, 2024

dipesh-rawat left a comment

Choose a reason for hiding this comment

katcosgrove commented Mar 15, 2024

sftim left a comment

Choose a reason for hiding this comment

sftim Mar 18, 2024 • edited Loading

Choose a reason for hiding this comment

sftim Mar 18, 2024

Choose a reason for hiding this comment

sftim Mar 18, 2024

Choose a reason for hiding this comment

drewhagen commented Mar 18, 2024

drewhagen commented Mar 24, 2024 • edited Loading

fsmunoz commented Mar 25, 2024

haircommander commented Mar 25, 2024

mrunalp left a comment

Choose a reason for hiding this comment

dipesh-rawat Mar 26, 2024

Choose a reason for hiding this comment

sftim Mar 26, 2024

Choose a reason for hiding this comment

dipesh-rawat Mar 26, 2024

Choose a reason for hiding this comment

dipesh-rawat left a comment

Choose a reason for hiding this comment

haircommander commented Mar 26, 2024

dipesh-rawat Mar 26, 2024

Choose a reason for hiding this comment

haircommander Mar 26, 2024

Choose a reason for hiding this comment

fsmunoz commented Mar 26, 2024 • edited Loading

drewhagen commented Mar 26, 2024 • edited Loading

kannon92 commented Mar 26, 2024

dipesh-rawat left a comment

Choose a reason for hiding this comment

k8s-ci-robot commented Mar 26, 2024

k8s-ci-robot commented Mar 26, 2024

drewhagen commented Apr 25, 2024

haircommander commented Feb 15, 2024 •

edited

Loading

netlify bot commented Feb 15, 2024 •

edited

Loading

sftim Mar 18, 2024 •

edited

Loading

drewhagen commented Mar 24, 2024 •

edited

Loading

fsmunoz commented Mar 26, 2024 •

edited

Loading

drewhagen commented Mar 26, 2024 •

edited

Loading